March 2017 - core-libs-dev

RFR of JDK-8176721: @since value errors java.sql module
by Hamlin Li 15 Mar '17

15 Mar '17

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176721 webrev: http://cr.openjdk.java.net/~mli/8176721/webrev.00/ Thank you -Hamlin

2 3

RFR: 8176541: XML deprecation "since" values should use 1.x version form for 1.8 and earlier
by huizhe wang 15 Mar '17

15 Mar '17

Hi, Please review a correction of the "since" values for several deprecated classes / methods. diff --git a/src/java.xml/share/classes/javax/xml/stream/XMLEventFactory.java b/src/java.xml/share/classes/javax/xml/stream/XMLEventFactory.java --- a/src/java.xml/share/classes/javax/xml/stream/XMLEventFactory.java +++ b/src/java.xml/share/classes/javax/xml/stream/XMLEventFactory.java @@ -155,7 +155,7 @@ * #newFactory(java.lang.String, java.lang.ClassLoader)} * method defines no changes in behavior. */ *- @Deprecated(since="7")** **+ @Deprecated(since="1.7")* public static XMLEventFactory newInstance(String factoryId, ClassLoader classLoader) throws FactoryConfigurationError { diff --git a/src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java b/src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java --- a/src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java +++ b/src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java @@ -222,7 +222,7 @@ * java.util.ServiceConfigurationError service configuration error} or if * the implementation is not available or cannot be instantiated. */ *- @Deprecated(since="7")** **+ @Deprecated(since="1.7")* public static XMLInputFactory newFactory() throws FactoryConfigurationError { @@ -244,7 +244,7 @@ * #newFactory(java.lang.String, java.lang.ClassLoader)} method * defines no changes in behavior. */ *- @Deprecated(since="7")** **+ @Deprecated(since="1.7")* public static XMLInputFactory newInstance(String factoryId, ClassLoader classLoader) throws FactoryConfigurationError { diff --git a/src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java b/src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java --- a/src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java +++ b/src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java @@ -222,7 +222,7 @@ * Use the new method {@link #newFactory(java.lang.String, * java.lang.ClassLoader)} instead. */ *- @Deprecated(since="7")** **+ @Deprecated(since="1.7")* public static XMLInputFactory newInstance(String factoryId, ClassLoader classLoader) throws FactoryConfigurationError { diff --git a/src/java.xml/share/classes/org/xml/sax/AttributeList.java b/src/java.xml/share/classes/org/xml/sax/AttributeList.java --- a/src/java.xml/share/classes/org/xml/sax/AttributeList.java +++ b/src/java.xml/share/classes/org/xml/sax/AttributeList.java @@ -93,7 +93,7 @@ * @see org.xml.sax.DocumentHandler#startElement startElement * @see org.xml.sax.helpers.AttributeListImpl AttributeListImpl */ *-@Deprecated(since="5")** **+@Deprecated(since="1.5")* public interface AttributeList { diff --git a/src/java.xml/share/classes/org/xml/sax/DocumentHandler.java b/src/java.xml/share/classes/org/xml/sax/DocumentHandler.java --- a/src/java.xml/share/classes/org/xml/sax/DocumentHandler.java +++ b/src/java.xml/share/classes/org/xml/sax/DocumentHandler.java @@ -68,7 +68,7 @@ * @see org.xml.sax.Locator * @see org.xml.sax.HandlerBase */ *-@Deprecated(since="5")** **+@Deprecated(since="1.5")* public interface DocumentHandler { diff --git a/src/java.xml/share/classes/org/xml/sax/Parser.java b/src/java.xml/share/classes/org/xml/sax/Parser.java --- a/src/java.xml/share/classes/org/xml/sax/Parser.java +++ b/src/java.xml/share/classes/org/xml/sax/Parser.java @@ -73,7 +73,7 @@ * @see org.xml.sax.HandlerBase * @see org.xml.sax.InputSource */ *-@Deprecated(since="5")** **+@Deprecated(since="1.5")* public interface Parser { diff --git a/src/java.xml/share/classes/org/xml/sax/helpers/ParserFactory.java b/src/java.xml/share/classes/org/xml/sax/helpers/ParserFactory.java --- a/src/java.xml/share/classes/org/xml/sax/helpers/ParserFactory.java +++ b/src/java.xml/share/classes/org/xml/sax/helpers/ParserFactory.java @@ -64,7 +64,7 @@ * @version 2.0.1 (sax2r2) */ @SuppressWarnings( "deprecation" ) *-@Deprecated(since="5")** **+@Deprecated(since="1.5")* public class ParserFactory { private static SecuritySupport ss = new SecuritySupport(); Thanks, Joe

3 3

Review Request: JDK-8174977: Update license files with consistent license/notice names
by Mandy Chung 14 Mar '17

14 Mar '17

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174977/webrev.00/index.html Small edits to the license files, contributed by jeannette.hung(a)oracle.com. I am sponsoring it. Also I have reviewed it. Mandy

2 1

RFR of JDK-8176566: @since value errors in types of java.base module
by Hamlin Li 14 Mar '17

14 Mar '17

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176566 webrev: http://cr.openjdk.java.net/~mli/8176566/webrev.00/ Thank you -Hamlin

3 8

Review request 8153912: StackFrame::getFileName and StackFrame::getLineNumber not needed
by Mandy Chung 14 Mar '17

14 Mar '17

Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153912/webrev.00/index.html StackFrame::getFileName and StackFrame::getLineNumber are originally proposed with the view of any stack walking code can migrate to the StackWalker API without the use of StackTraceElement. File name and line number are useful for debugging and troubleshooting purpose. It has additional overhead to map from a method and BCI to look up the file name and line number. StackFrame::toStackTraceElement method returns StackTraceElement that includes the file name and line number. There is no particular benefit to duplicate getFileName and getLineNumber methods in StackFrame. It is equivalently convenient to call StackFrame.toStackTraceElement().getFileName() (or getLineNumber). This patch proposes to remove StackFrame::getFileName and StackFrame::getLineNumber methods since such information can be obtained from StackFrame.toStackTraceElement(). Mandy

7 45

JDK 9 RFR: 8066640: clarify security checks in ObjectInputStream.enableResolveObject
by Stuart Marks 14 Mar '17

14 Mar '17

.. and ObjectOutputStream.enableReplaceObject. https://bugs.openjdk.java.net/browse/JDK-8066640 Please review this small spec change for these methods. This aligns the specification to be in agreement with the actual implementation. Essentially the change replaces the current wording: << If enable is true, and there is a security manager installed, this method first calls the security manager's checkPermission method.... >> with the following: << If object replacement is currently not enabled, and if enable is true, and there is a security manager installed, this method first calls the security manager's checkPermission method.... >> Patch appended below, including some editorial and markup changes to improve consistency. Thanks! s'marks # HG changeset patch # User smarks # Date 1489442411 25200 # Mon Mar 13 15:00:11 2017 -0700 # Node ID 6b6e3d5ab6027d2243d2e786682a117a8245764a # Parent 173d03f43b765cbcddfc2dff9cbf816e088af906 8066640: clarify security checks in ObjectInputStream.enableResolveObject and ObjectOutputStream.enableReplaceObject Reviewed-by: XXX diff -r 173d03f43b76 -r 6b6e3d5ab602 src/java.base/share/classes/java/io/ObjectInputStream.java --- a/src/java.base/share/classes/java/io/ObjectInputStream.java Fri Mar 10 09:20:55 2017 -0800 +++ b/src/java.base/share/classes/java/io/ObjectInputStream.java Mon Mar 13 15:00:11 2017 -0700 @@ -812,23 +812,24 @@ } /** - * Enable the stream to allow objects read from the stream to be replaced. - * When enabled, the resolveObject method is called for every object being + * Enables the stream to do replacement of objects read from the stream. When + * enabled, the {@link #resolveObject} method is called for every object being * deserialized. * - * If enable is true, and there is a security manager installed, + * If object replacement is currently not enabled, and + * {@code enable} is true, and there is a security manager installed, * this method first calls the security manager's - * <code>checkPermission</code> method with the - * <code>SerializablePermission("enableSubstitution")</code> permission to - * ensure it's ok to enable the stream to allow objects read from the - * stream to be replaced. + * {@code checkPermission} method with the + * {@code SerializablePermission("enableSubstitution")} permission to + * ensure it's ok to enable the stream to do replacement of objects + * read from the stream. * - * @param enable true for enabling use of <code>resolveObject</code> for + * @param enable true for enabling use of {@code resolveObject} for * every object being deserialized * @return the previous setting before this method was invoked * @throws SecurityException if a security manager exists and its - * <code>checkPermission</code> method denies enabling the stream - * to allow objects read from the stream to be replaced. + * {@code checkPermission} method denies enabling the stream + * to do replacement of objects read from the stream. * @see SecurityManager#checkPermission * @see java.io.SerializablePermission */ diff -r 173d03f43b76 -r 6b6e3d5ab602 src/java.base/share/classes/java/io/ObjectOutputStream.java --- a/src/java.base/share/classes/java/io/ObjectOutputStream.java Fri Mar 10 09:20:55 2017 -0800 +++ b/src/java.base/share/classes/java/io/ObjectOutputStream.java Mon Mar 13 15:00:11 2017 -0700 @@ -589,22 +589,24 @@ } /** - * Enable the stream to do replacement of objects in the stream. When - * enabled, the replaceObject method is called for every object being + * Enables the stream to do replacement of objects written to the stream. When + * enabled, the {@link #replaceObject} method is called for every object being * serialized. * - * If <code>enable</code> is true, and there is a security manager - * installed, this method first calls the security manager's - * <code>checkPermission</code> method with a - * <code>SerializablePermission("enableSubstitution")</code> permission to - * ensure it's ok to enable the stream to do replacement of objects in the - * stream. + * If object replacement is currently not enabled, and + * {@code enable} is true, and there is a security manager installed, + * this method first calls the security manager's + * {@code checkPermission} method with the + * {@code SerializablePermission("enableSubstitution")} permission to + * ensure it's ok to enable the stream to do replacement of objects + * written to the stream. * - * @param enable boolean parameter to enable replacement of objects + * @param enable true for enabling use of {@code replaceObject} for + * every object being serialized * @return the previous setting before this method was invoked * @throws SecurityException if a security manager exists and its - * <code>checkPermission</code> method denies enabling the stream - * to do replacement of objects in the stream. + * {@code checkPermission} method denies enabling the stream + * to do replacement of objects written to the stream. * @see SecurityManager#checkPermission * @see java.io.SerializablePermission */

2 1

Unintentional abort with SIGUSR2
by Takao, Shinji 14 Mar '17

14 Mar '17

Hi all, I encountered an unintentional process abort with SIGSEGV when a Java process received a SIGUSR2. I was little surprised because I believed that the SIGUSR2 was to be ignored when it had no user definition. Is there any documentation for the behavior? # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007fca804a40a2, pid=2137, tid=0x00007fca81949740 # # JRE version: OpenJDK Runtime Environment (8.0_121-b13) (build 1.8.0_121-b13) # Java VM: OpenJDK 64-Bit Server VM (25.121-b13 mixed mode linux-amd64 compressed oops) # Problematic frame: # V [libjvm.so+0x8700a2] # # Core dump written. Default location: /xxx/xxx/core or core.2137 # # If you would like to submit a bug report, please visit: # http://bugreport.java.com/bugreport/crash.jsp # --------------- T H R E A D --------------- Current thread is native thread siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: 0x0000000000000110 Best regards, Shinji

4 3

RFR: testCommonPoolThreadContextClassLoader fails with "Should throw SecurityException"
by Martin Buchholz 14 Mar '17

14 Mar '17

flaky test bug fix for jdk9 https://bugs.openjdk.java.net/browse/JDK-8176551 ttp://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-integration/testC… <http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-integration/test…>

3 2

JDK 9 RFR of 8176221: Preferences docs contain reference to Sun's JRE
by Brian Burkhalter 13 Mar '17

13 Mar '17

Please review this simple doc-only change for [1]: --- a/src/java.prefs/share/classes/java/util/prefs/Preferences.java +++ b/src/java.prefs/share/classes/java/util/prefs/Preferences.java @@ -188,8 +188,8 @@ * administrator to replace the default preferences implementation with an * alternative implementation. * - * Implementation note: In Sun's JRE, the {@code PreferencesFactory} - * implementation is located as follows: + * @implNote + * The {@code PreferencesFactory} implementation is located as follows: * * <ol> Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8176221

2 1

JDK 9 VarHandle memory mode usage guide
by Doug Lea 13 Mar '17

13 Mar '17

[Reposting from concurrency-interest list] As may recall, JDK 9 VarHandles with new memory modes were incorporated without a full overhaul of the Java Memory Model that would be needed to formally specify them. For the past year or so I've been sporadically working on an expert-programmer guide that conveys as much information as possible while skirting the issues (like out-of-thin-air) that led to stalls in revising the JMM. Considering that there's now no chance for a JLS JMM update to occur before JDK 9 release, this might be the we can do. The current draft is available at http://gee.cs.oswego.edu/dl/html/j9mm.html If you are on this list, you are probably in the main target audience for this guide. Someday, a less imposing overview might be nice. Plus more examples. -Doug

1 0