March 2017 - core-libs-dev

Shouldn't InputStream/Files::readAllBytes throw something other than OutOfMemoryError?
by Anthony Vanelverdinghe 13 Mar '17

13 Mar '17

Files::readAllBytes is specified to throw an OutOfMemoryError "if an array of the required size cannot be allocated, for example the file is larger that 2G". Now in Java 9, InputStream::readAllBytes does the same. However, this overloads the meaning of OutOfMemoryError: either "the JVM is out of memory" or "the resultant array would require long-based indices". In my opinion, this overloading is problematic, because: - OutOfMemoryError has very clear semantics, and I don't see the link between OOME and the fact that a resultant byte[] would need to be >2G. If I have 5G of free heap space, and try to read a 3G file, I'd expect something like an UnsupportedOperationException, but definitely not an OutOfMemoryError. - the former meaning is an actual Error, whereas the latter is an Exception from which the application can recover. - developers might be tempted to catch the OOME and retry to read the file/input stream in chunks, no matter the cause of the OOME. What was the rationale for using OutOfMemory here? And would it still be possible to change this before Rampdown Phase 2? Kind regards, Anthony

4 5

Is @deprecated javadoc comment still useful?
by Weijun Wang 10 Mar '17

10 Mar '17

Hi, Mr Deprecator I'm adding @Deprecated annotations with arguments to a module and a class, and at the same time I add @deprecated javadoc comments. The resulting javadoc pages are attached. As you can see, the bold sentence (I assume it's generated from the annotation) and the line below contain the exact same information. However, they do not use the exact same words: subject vs planned, version vs release. This makes me uncomfortable. I've tried to remove the content of the javadoc comment and only keep the @deprecated tag, the result looks better. Is that the right way? Thanks Max

3 5

RFR JDK-8176029: Linebreak matcher is not equivalent to the pattern as stated in javadoc
by Xueming Shen 09 Mar '17

09 Mar '17

Hi, Please help review the change for JDK-8176029 issue: https://bugs.openjdk.java.net/browse/JDK-8176029 webrev: http://cr.openjdk.java.net/~sherman/8176029/webrev It appears the API doc for \R is correct, instead the implementation is buggy when dealing with sequence "\r\n" (u+000du+000a). The existing implementation fails to backtrack to match \r and then next.match() when the attempt \r\n + next.match() failed. As a simple obvious sample both following should return true. The existing implementation returns false for the second. "\r\n".match("\\R") "\r\n".match("\\R\\n") Thanks, Sherman

2 3

9 RFR of JDK-8176337: Mark several tests as intermittently failing
by Hamlin Li 08 Mar '17

08 Mar '17

Would you please review below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176337 webrev: http://cr.openjdk.java.net/~mli/8176337/webrev.00/ These tests are failing intermittently, they should be marked accordingly with @key intermittent java/nio/channels/FileChannel/Transfer.java (JDK-8140263 <https://bugs.openjdk.java.net/browse/JDK-8140263>) java/nio/channels/FileChannel/Transfers.java (JDK-8140263 <https://bugs.openjdk.java.net/browse/JDK-8140263>) java/io/FileInputStream/LargeFileAvailable.java (JDK-8174810 <https://bugs.openjdk.java.net/browse/JDK-8174810>) java/nio/channels/FileChannel/LoopingTruncate.java (JDK-8173386 <https://bugs.openjdk.java.net/browse/JDK-8173386>) java/lang/ProcessBuilder/Basic.java (JDK-8171426 <https://bugs.openjdk.java.net/browse/JDK-8171426>) sun/security/tools/keytool/DefaultSignatureAlgorithm.java (JDK-8172657 <https://bugs.openjdk.java.net/browse/JDK-8172657>) javax/net/ssl/DTLS/CipherSuite.java (JDK-8174072 <https://bugs.openjdk.java.net/browse/JDK-8174072>) Thank you -Hamlin

4 3

RFR 8176195/9, Fix misc module dependencies in jdk_core tests
by Felix Yang 08 Mar '17

08 Mar '17

Hi there, please review the changes to explicitly declare dependencies in tests. This will make better test selection with --limit-module option. Bug: https://bugs.openjdk.java.net/browse/JDK-8176195 Webrev: http://cr.openjdk.java.net/~xiaofeya/8176195/webrev.00/ I didn't use TEST.properties to declare dependency with jdk.charsets in jdk_nio tests, because there are still lots of tests in the same folder not depending it. Thanks, Felix

2 1

Review Request JDK-8175797: (ref) Reference::enqueue method should clear referent before enqueuing
by Mandy Chung 08 Mar '17

08 Mar '17

This proposes to update Reference::enqueue method to clear this reference object before enqueuing it to the registered queue consistent with what the garbage collector does that clears the reference object before putting it in the pending queue for enqueuing. It has been a common pattern that Reference::clear is called before or after enqueuing. I consider this a follow-up to JDK-8071507 that soft, weak, phantom references are automatically cleared references when implicitly or explicitly enqueued. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175797/webrev.00/index.html Thanks Mandy

4 4

JDK 9 RFR of JDK-8167525: update jdk tests to remove @compile --add-modules workaround
by Amy Lu 08 Mar '17

08 Mar '17

Please review the patch to remove the @compile --add-modules workaround. In the past, tests added --add-modules to @compile (JDK-8169231) or to @run (JDK-8156579) to workaround jtreg issue CODETOOLS-7901761. CODETOOLS-7901761 has been fixed in 4.2/b05, workaround in tests should be reverted. bug: https://bugs.openjdk.java.net/browse/JDK-8167525 webrev: http://cr.openjdk.java.net/~amlu/8167525/webrev.00/ Note that sun/nio/cs/OLD/TestIBMDB.java was added to ProblemList.txt in JDK-8169231, indicate this (JDK-8167525) as related bug. But now this test pass, so removed it from ProblemList.txt Thanks, Amy

2 1

Review Request JDK-8176333: jdeps error message should include a proper MR jar file name
by Mandy Chung 08 Mar '17

08 Mar '17

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8176333/webrev.00/ This is a simple fix to jdeps to print the MR JAR file name in the error message. The existing implementation icorrectly casts String[] as an Object that leads to print String[].toString() instead of the filename. Mandy

2 1

RFR (JAXP) 8175830: Provide javadoc description for jdk.xml.dom module
by huizhe wang 07 Mar '17

07 Mar '17

Hi, Please review a module description for jdk.xml.dom. JBS: https://bugs.openjdk.java.net/browse/JDK-8175830 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8175830/webrev/ Thanks, Joe

2 4

RFR(s): 8176304: Number of javax/management test fails due to undeclared dependencies
by Sergei Kovalev 07 Mar '17

07 Mar '17

Hi Team, Please take a look at the fix for javax.management tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8176304 Webrev: http://cr.openjdk.java.net/~skovalev/8176304/webrev.00/ Issue: number of tests failing with "--limit-module" command line option due to missed dependencies. In general missed dependencies are: jdk.management.agent and jdk.naming.rmi modules. -- With best regards, Sergei

2 1