May 2018 - core-libs-dev

[11] RFR: 8202088: Japanese new era implementation
by Naoto Sato 08 Jun '18

08 Jun '18

Hi, Please review the changes to the subject issue: https://bugs.openjdk.java.net/browse/JDK-8202088 The proposed change is located at: http://cr.openjdk.java.net/~naoto/8202088/webrev.01/ This is the implementation part of the upcoming Japanese new era, starting from May 1st, 2019. Current anticipation is that the new name won't be known till one month prior to the beginning of the era. So it's not possible to make changes to the JDK with the proper name. Instead, here we are going to implement the new era with a place holder name which will be immediately replaced with the proper name once it's known. The CSR is currently under review: https://bugs.openjdk.java.net/browse/JDK-8202336 Naoto

5 8

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1
by Ichiroh Takiguchi 07 Jun '18

07 Jun '18

Hello. 8202322 was integrated into jdk-11+15. I'm using XLC 13.1.3 on AIX 7.1.4. Build was failed because of "-qvisibility=hidden" on make/lib/LibCommon.gmk. According to "XL C/C++ for AIX 13.1.3" documentation [1], "-qvisibility=hidden" cannot create shared libraries entry points. For example, libverify.so was there, but entry points were not resolved by "-lverify" option. I think it should be "-qvisibility=default" (I tried, it worked) or "-qvisibility=protected" (I had not tried) ? I'm not familiar with -qvisibility option, but I'd like to find out right way. [1] https://www.ibm.com/support/knowledgecenter/SSGH3R_13.1.3/com.ibm.xlcpp1313… On 2018-05-16 16:08, Langer, Christoph wrote: > Hi Matthias, > > yes, reviewed. > > Best regards > Christoph > > From: Baesken, Matthias > Sent: Mittwoch, 16. Mai 2018 09:06 > To: Langer, Christoph <christoph.langer(a)sap.com>; > 'build-dev(a)openjdk.java.net' <build-dev(a)openjdk.java.net>; > ppc-aix-port-dev(a)openjdk.java.net; core-libs-dev(a)openjdk.java.net > Cc: Lindenmaier, Goetz <goetz.lindenmaier(a)sap.com> > Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on > xlc 12.1 > > Hi Christoph can I add you as second reviewer (other reviewer was > Erik Joelsson) can push the change ? > > Best regards, Matthias > > > > From: Langer, Christoph > Sent: Donnerstag, 26. April 2018 16:38 > To: Baesken, Matthias > <matthias.baesken(a)sap.com<mailto:matthias.baesken@sap.com>>; > 'build-dev(a)openjdk.java.net' > <build-dev(a)openjdk.java.net<mailto:build-dev@openjdk.java.net>>; > ppc-aix-port-dev(a)openjdk.java.net<mailto:ppc-aix-port-dev@openjdk.java.net>; > core-libs-dev(a)openjdk.java.net<mailto:core-libs-dev@openjdk.java.net> > Cc: Simonis, Volker > <volker.simonis(a)sap.com<mailto:volker.simonis@sap.com>> > Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on > xlc 12.1 > > Hi Matthias, > > to me the change in principal looks good. > > I'm wondering if it is possible to do a comparison like xlc < 13 (e.g. > extract major number before the first dot, then compare numerically) - > but maybe it is too complicated and the current single version compare > suits our needs ? > > Best regards > Christoph > > From: Baesken, Matthias > Sent: Donnerstag, 26. April 2018 16:14 > To: 'build-dev(a)openjdk.java.net' > <build-dev(a)openjdk.java.net<mailto:build-dev@openjdk.java.net>>; > ppc-aix-port-dev(a)openjdk.java.net<mailto:ppc-aix-port-dev@openjdk.java.net>; > core-libs-dev(a)openjdk.java.net<mailto:core-libs-dev@openjdk.java.net> > Cc: Langer, Christoph > <christoph.langer(a)sap.com<mailto:christoph.langer@sap.com>>; Simonis, > Volker <volker.simonis(a)sap.com<mailto:volker.simonis@sap.com>> > Subject: RFR : 8202322: AIX: symbol visibility flags not support on xlc > 12.1 > > Hello , could you please review this small adjustment to the symbol > visibility compilation settings on AIX ? > Currently we use XLC 12.1 to compile JDK on AIX . > > However XLC 12.1 does not support the "-qvisibility=hidden" > setting currently set on AIX. > It was introduced with XLC 13.1 . Christoph found some info about it > here : > > https://www.ibm.com/developerworks/aix/library/au-aix-symbol-visibility-par… > > Setting it only generates hundreds of warnings in the build log , > warnings look like this : > XlC12.1 > > bash-4.4$ xlC -qversion > IBM XL C/C++ for AIX, V12.1 (5765-J02, 5725-C72) > Version: 12.01.0000.0019 > > bash-4.4$ xlC -qvisibility=hidden sizeof.c -o sizeof_aixxlc > 1506-173 (W) Option visibility=hidden is not valid. Enter xlC for list > of valid options. > > Compare to XLC13.1 > > bash-3.00$ xlC -qversion > IBM XL C/C++ for AIX, V13.1 (5725-C72, 5765-J07) > Version: 13.01.0000.0008 > bash-3.00$ xlC -qvisibility=default sizeof.c -o sizeof_aixxlc > bash-3.00$ xlC -qvisibility=hidden sizeof.c -o sizeof_aixxlc > > > So it is better to avoid setting these flags when using xlc12.1 . > Please review : > > Bug : > > https://bugs.openjdk.java.net/browse/JDK-8202322 > > Change : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8202322/ > > > Best regards, Matthias

3 4

RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4
by Jan Lahoda 05 Jun '18

05 Jun '18

Hi, I'd like to upgrade the JOpt Simple library we are using to version 5.0.4. Bug: https://bugs.openjdk.java.net/browse/JDK-8203891 Complete webrev: http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/ Delta webrev only showing (all) JDK changes in JOpt Simple and related changes in tests needed for the upgrade, etc.: http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/joptsimple.delta/ Probably the biggest issue with this upgrade is that for two subsequent parameters: "--libs=", "/tmp" "/tmp" used to be interpreted as the parameter of "libs", but now the "libs" parameter is empty (as there's nothing behind the '='). See the changes to test/jdk/tools/jmod/JmodTest.java for an example. Hopefully, this is a reasonable change. How does this look? Thanks, Jan

4 6

[11] RFR: 8202026 8193552 : ISO 4217 Amendment #165 # 166 Update
by Leo Jiang 05 Jun '18

05 Jun '18

Hi, Please review the changes to address the ISO 4217 Amendment 165 166 update. Bug: https://bugs.openjdk.java.net/browse/JDK-8193552 165 https://bugs.openjdk.java.net/browse/JDK-8202026 166 CR: http://cr.openjdk.java.net/~ljiang/8202026/webrev.00/ Detail: #165 From: MAURITANIA Ouguiya MRO 478 2 To: MAURITANIA Ouguiya MRU 929 2 #166 From: VENEZUELA (BOLIVARIAN REPUBLIC OF) Bolívar VEF 937 2 To: VENEZUELA (BOLIVARIAN REPUBLIC OF) Bolívar Soberano VES 928 2 Thanks, Leo

4 7

RFR: implementation for JEP 334: JVM Constants API
by Vicente Romero 03 Jun '18

03 Jun '18

Hi all, Please review the proposed implementation for JEP 334 [1]. The webrev can be found at [2] and the javadoc at [3]. Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8203252 [2] http://cr.openjdk.java.net/~vromero/constant.api/webrev.07/constants.api.pa… [3] http://cr.openjdk.java.net/~vromero/constant.api/javadoc.07/overview-summar… PS. We are offering a MacBook Wheel to the authors of the first 5 comments :)

5 9

RFR: 8204194: Lazily create MethodHandleImpl$AsVarargsCollector.asCollectorCache
by Claes Redestad 31 May '18

31 May '18

Hi, please review this tiny fix that removes the eager creation of asCollectorCache, which saves us a few milliseconds on certain startup tests with no observed peak performance penalties. Bug: https://bugs.openjdk.java.net/browse/JDK-8204194 Patch: [1] Thanks! /Claes [1] diff -r 80c69f5cd21a src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java --- a/src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java Thu May 31 06:15:17 2018 -0700 +++ b/src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java Thu May 31 23:23:03 2018 +0200 @@ -499,7 +499,6 @@ super(type, target); this.target = target; this.arrayType = arrayType; - this.asCollectorCache = target.asCollector(arrayType, 0); } @Override

2 1

github
by Ivan Krylov 31 May '18

31 May '18

Тагир, привет, Слушай, а что с лицензией твоих примеров на гитхабе? Не мог бы ты какую-то лицензию упомянуть в шапке? Скажем, вот этот: https://gist.github.com/amaembo/cbe9e1a8f3f8d240beb080343670f0c2 Спасибо, Ваня

2 2

RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links
by Michal Vala 31 May '18

31 May '18

Hi, please review and eventually sponsor this small doc patch fixing method links in java.util.regex.Matcher webrev: http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8190417/webrev.00/ Thanks! -- Michal Vala OpenJDK QE Red Hat Czech

3 8

[8u-dev] Request for Review and Approval to Backport 8203368: ObjectInputStream filterCheck method throws NullPointerException
by Ivan Gerasimov 31 May '18

31 May '18

Hello! I'd like to backport the fix to JDK 8u-dev. Both source patch and the regression test had to be adjusted slightly due to the code divergence, thus the review request. Bug: https://bugs.openjdk.java.net/browse/JDK-8203368 Jdk 8u webrev: http://cr.openjdk.java.net/~igerasim/8203368/00/webrev/ Jdk 11 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/697b49a04e19 Jdk 11 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053318.html Thanks in advance! -- With kind regards, Ivan Gerasimov

3 2

RFR: JDK-8203827: Upgrade JLine to 2.14.6
by Jan Lahoda 31 May '18

31 May '18

Hi, I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6. The complete webrev is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/ To simplify reviewing, there is: -an antipatch that removes the JDK-specific changes and restores the vanilla 2.12.1 content: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/ -a patch that replaces the 2.12.1 content with 2.14.6: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/ -a patch that re-applies the JDK-specific changes (like including adjusting packages, and removal/commenting out of usage of features that would require undesirable dependencies, and any changes that had to be done to other modules): http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/ JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827 How does this look? Thanks, Jan

3 7