February 2019 - core-libs-dev

RFR: JDK-8217902: jpackage fails with --app-image option on mac
by Andy Herrick 28 Feb '19

28 Feb '19

JDK-8217902: jpackage fails with --app-image option on mac Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The fix is to remove the over-aggressive validation in DeployParams.validate() and update WinAppBundler to be the same as Mac code. [1] https://bugs.openjdk.java.net/browse/JDK-8217902 [2] http://cr.openjdk.java.net/~herrick/8217902/webrev.01/ /ANdy

2 3

RFR: JDK-8191709 : javapackager detects WiX 3.10 as 3.1 and fails to use WiX 3.6+ compatible code
by Alexander Matveev 28 Feb '19

28 Feb '19

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Problem was in how we compare versions. We used to compare it as float number, so 3.10 -> 3.1 which was less then 3.6. - Fixed by comparing major and minor version separately. - Fixed minor spelling error in resources. [1] https://bugs.openjdk.java.net/browse/JDK-8191709 [2] http://cr.openjdk.java.net/~almatvee/8191709/webrev.00/ Thanks, Alexander

3 4

RFR: jsr166 integration 2019-02
by Martin Buchholz 27 Feb '19

27 Feb '19

https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview… 8195057: java/util/concurrent/CountDownLatch/Basic.java failed w/ Xcomp https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/CountDow… https://bugs.openjdk.java.net/browse/JDK-8195057 8215359: InnocuousForkJoinWorkerThread.setContextClassLoader needlessly throws https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/Innocuou… https://bugs.openjdk.java.net/browse/JDK-8215359 8215363: needless signals in ForkJoinPool https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/forkjoin… https://bugs.openjdk.java.net/browse/JDK-8215363 Still in limbo: 8203662: remove increment of modCount from ArrayList and Vector replaceAll() https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/replaceA… https://bugs.openjdk.java.net/browse/JDK-8203662 8215249: Miscellaneous changes imported from jsr166 CVS 2019-02 https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/miscella… https://bugs.openjdk.java.net/browse/JDK-8215249

5 10

LTS releases and JEP 182: Policy for Retiring javac -source and -target Options ?
by Andrew Leonard 27 Feb '19

27 Feb '19

Hi, Does anyone know if this JEP will be modified to cater for the shorter release cycles and LTS releases? https://bugs.openjdk.java.net/browse/JDK-8046172 The original Impact statement stated: "but even with this new policy source code 10 or more years old should still be able to be compiled" however now, for example with JDK12 this policy will only support 1+3 = 12, 11, 10, 9, which means LTS JDK8 would not be recognised? "1+3" is essentially only 18 months now! Thoughts? or is there a new JEP I have missed that covers this? Thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leonard(a)uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

3 2

JDK 13 RFR of JDK-8218726: Minor Throwable.printStackTrace() typos
by Joe Darcy 27 Feb '19

27 Feb '19

Hello, Please review the patch below to fix a small typo ("at" -> "as") in text of Throwable introduced with some of the Project Coin changes. Thanks, -Joe diff -r 2c50e900e8af src/java.base/share/classes/java/lang/Throwable.java --- a/src/java.base/share/classes/java/lang/Throwable.java Wed Feb 27 11:33:57 2019 -0800 +++ b/src/java.base/share/classes/java/lang/Throwable.java Wed Feb 27 12:09:29 2019 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1994, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1994, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -616,7 +616,7 @@ * ... 1 more * </pre> * Note that the "... n more" notation is used on suppressed exceptions - * just at it is used on causes. Unlike causes, suppressed exceptions are + * just as it is used on causes. Unlike causes, suppressed exceptions are * indented beyond their "containing exceptions." * * <p>An exception can have both a cause and one or more suppressed

3 2

RFR: JDK-8219144 : Cannot find installed application on Mac
by Alexander Matveev 27 Feb '19

27 Feb '19

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). By default pkgbuild generates package with BundleIsRelocatable set to true, which means if an application already exist on system (installed, generated on given system or just copied from somewhere else), installer will not install into default location (/Application), but instead will update the existing version in place. This is why installed application was not found in default location, since it was already exist on system. Fixed by generating package with BundleIsRelocatable set to false. Note: We used --component option for pkgbuild and in this case pkgbuild was considered app as single component. With --root (required when using component property list), pkgbuild was considered Java runtime as child component of application. This is why child sub-component is removed from cpl. Java runtime is still part of app and will be installed. [1] https://bugs.openjdk.java.net/browse/JDK-8219144 [2] http://cr.openjdk.java.net/~almatvee/8219144/webrev.00/ Thanks, Alexander

2 1

[JDK 13] RFR 8219802: Problem list java/net/MulticastSocket/SetGetNetworkInterfaceTest.java
by Amy Lu 27 Feb '19

27 Feb '19

java/net/MulticastSocket/SetGetNetworkInterfaceTest.java Test fails due to JDK-8219083 (failures observed on windows-x64) and should be problem listed before mentioned issue fixed. Please review the patch. bug: https://bugs.openjdk.java.net/browse/JDK-8219802 Thanks, Amy --- old/test/jdk/ProblemList.txt 2019-02-27 09:37:33.000000000 +0800 +++ new/test/jdk/ProblemList.txt 2019-02-27 09:37:32.000000000 +0800 @@ -556,6 +556,8 @@ java/net/MulticastSocket/Test.java 7145658 macosx-all +java/net/MulticastSocket/SetGetNetworkInterfaceTest.java 8219083 windows-all + java/net/DatagramSocket/SendDatagramToBadAddress.java 7143960 macosx-all java/net/ServerSocket/AcceptInheritHandle.java 8211854 aix-ppc64

3 3

Fix proposal: JDK-8219378 NPE in ReflectionFactory.newMethodAccessor when langReflectAccess not initialized
by Andrew Leonard 27 Feb '19

27 Feb '19

Please can I request a sponsor for this fix to ReflectionFactory where langReflectAccess is not always correctly initialized. Webrev: http://cr.openjdk.java.net/~aleonard/8219378/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8219378 Thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leonard(a)uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

4 17

RFR(XS): 8215009: GCC 8 compilation eror in libjli
by Dmitry Chuyko 27 Feb '19

27 Feb '19

Hello, Please review a small fix in java_md_solinux.c: continuation is not truly compatible with pthread_create start_routine's signature but we control what actually happens. So it makes sense to add intermediate void* cast to silence the error. bug: https://bugs.openjdk.java.net/browse/JDK-8215009 webrev: http://cr.openjdk.java.net/~dchuyko/8215009/webrev.00/ testing: submit repo (mach5-one-dchuyko-JDK-8215009-20181207-1625-13615: PASSED) -Dmitry

4 17

RFR: JDK-8219695: Use a copy of javac's implementation of @argfile in jpackager
by Andy Herrick 26 Feb '19

26 Feb '19

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The fix is to include the code for processing @argfile from javac into jpackage. [1] https://bugs.openjdk.java.net/browse/JDK-8219695 [2] http://cr.openjdk.java.net/~herrick/8219695/ /Andy

3 2