February 2019 - core-libs-dev

RFR 8182117 : Document Zip File System Properties
by Lance Andersen 08 Feb '19

08 Feb '19

Hi all Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8182117 <https://bugs.openjdk.java.net/browse/JDK-8182117> which addresses the need to document the Zip File System properties and is also replacing the documentation that used to exist in the tech note: https://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/zipfilesystem…. The updated documentation can be seen below followed by the diff of the changes. ——————— Module jdk.zipfs <>Provides the implementation of the Zip file system provider. The Zip file system provider treats a Zip or JAR file as a file system providing the ability to manipulate the contents of the file. Accessing a Zip File System You can use the FileSystems <applewebdata://0B307EB5-DECC-44DF-8927-3891049153F4/java.base/java/nio/file/FileSystems.html> newFileSystem static factory methods to create a new Zip file system or to obtain a reference to an existing Zip file system. URI Scheme Used to Identity the Zip File System The URI scheme <applewebdata://0B307EB5-DECC-44DF-8927-3891049153F4/java.base/java/net/URI.html#getScheme()> that identifies the ZIP file system is jar. Zip File System Properties The following properties may be specified when creating a Zip file system: Property Name Data Type Default Value Description create java.lang.String false If the value is true, the Zip file system provider creates a new Zip or JAR file if it does not exist. encoding java.lang.String UTF-8 The value indicates the encoding scheme for the names of the entries in the Zip or JAR file. Examples: Construct a new Zip file system that is identified by a URI. If the Zip file does not exist, it will be created: URI uri = URI.create("jar:file:/home/luckydog/tennisTeam.zip"); Map<String, String> env = Map.of("create", "true"); FileSystem zipfs = FileSystems.newFileSystem(uri, env); Construct a new Zip file system that is identified by specifying a path and using automatic file type detection. Iterate from the root of the JAR displaying each found entry: FileSystem zipfs = FileSystems.newFileSystem( Paths.get("tennisteam.jar"), null); Files.walk(zipfs.getPath("/")) .forEach(System.out::println); Since: 9 —————————— Here is the actual diff: ——————— $ hg diff diff -r cd310319fead src/jdk.zipfs/share/classes/module-info.java --- a/src/jdk.zipfs/share/classes/module-info.java Sun Jan 27 14:55:57 2019 -0500 +++ b/src/jdk.zipfs/share/classes/module-info.java Mon Feb 04 12:30:50 2019 -0500 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2014, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,14 +24,87 @@ */ /** - * Provides the implementation of the zip file system provider. + * Provides the implementation of the Zip file system provider. + * The Zip file system provider treats a Zip or JAR file as a file system + * providing the ability to manipulate the contents of the file. + * <p> * - * <p> The zip file system provider treats a zip or JAR file as a file system - * and provides the ability to manipulate the contents of the file. - * The zip file system provider can be created by - * {@link java.nio.file.FileSystems#newFileSystem - * FileSystems.newFileSystem} if installed. + * <h3>Accessing a Zip File System</h3> * + * You can use the {@linkplain java.nio.file.FileSystems FileSystems} {@code newFileSystem} + * static factory methods to create a new Zip file system or to obtain a reference to an + * existing Zip file system. + * + * <h3>URI Scheme Used to Identity the Zip File System</h3> + * + * The URI {@link java.net.URI#getScheme scheme} that identifies the ZIP file system is {@code jar}. + * + * <h3>Zip File System Properties</h3> + * + * The following properties may be specified when creating a Zip + * file system: + * <p> + * <table class="striped"> + * <caption style="display:none"> + * Configurable properties that may be specified when creating + * a new Zip file system + * </caption> + * <thead> + * <tr> + * <th scope="col">Property Name</th> + * <th scope="col">Data Type</th> + * <th scope="col">Default Value</th> + * <th scope="col">Description</th> + * </tr> + * </thead> + * + * <tbody> + * <tr> + * <td scope="row">create</td> + * <td>java.lang.String</td> + * <td>false</td> + * <td> + * If the value is {@code true}, the Zip file system provider + * creates a new Zip or JAR file if it does not exist. + * </td> + * </tr> + * <tr> + * <td scope="row">encoding</td> + * <td>java.lang.String</td> + * <td>UTF-8</td> + * <td> + * The value indicates the encoding scheme for the + * names of the entries in the Zip or JAR file. + * </td> + * </tr> + * </tbody> + * </table> + * + * <h3>Examples:</h3> + * + * Construct a new Zip file system that is identified by a URI. If the Zip file does not exist, + * it will be created: + * <pre> + * {@code + * + * URI uri = URI.create("jar:file:/home/luckydog/tennisTeam.zip"); + * Map<String, String> env = Map.of("create", "true"); + * FileSystem zipfs = FileSystems.newFileSystem(uri, env); + * } + * </pre> + * + * Construct a new Zip file system that is identified by specifying a path + * and using automatic file type detection. Iterate from the root of the JAR displaying each + * found entry: + * <pre> + * {@code + * + * FileSystem zipfs = FileSystems.newFileSystem( + * Paths.get("tennisteam.jar"), null); + * Files.walk(zipfs.getPath("/")) + * .forEach(System.out::println); + * } + * </pre> * @provides java.nio.file.spi.FileSystemProvider * @moduleGraph * @since 9 $ -------------------- <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com <mailto:Lance.Andersen@oracle.com>

5 13

jpackage windows --version-swap --icon-swap weirdness
by Jon Harper 08 Feb '19

08 Feb '19

Hi list, I'm using jpackage EA from https://jdk.java.net/jpackage/ to create a windows executable on windows 2012 R2 (jpackager create-image ...) The resulting exe file doesn't have the correct vendor and version information (it has openjdk 13 instead of my vendor name and version). It has the correct logo. Can anyone help with this, or is anyone interested ? Has anyone made the icon and vendor work with exes ? I did some troubleshooting, including writing my own program that updates the version using BeginUpdateResource, UpdateResource and EndUpdateResource, I see very differing behaviors depending on what exe I change. With an exe that I compiled myself using mingw32 (gcc 5.1), calling jpackager --icon-swap and jpackager --version-swap on it works. Using a copy of git.exe from git for windows portable, everytime I call jpackage --version-swap (or my own program) on this exe AFTER having done a jpackage --icon-swap on it, I get a crash and the exe is not updated (updating the version with my simple program has the same behavior). Calling jpackage --version-swap first and then jpackage --icon-swap results in an exe that has the correct icon and correct versioninfo (although this exe is now "poisonned", you can't change its version again..) Running jpackage --version-info again on the binary generated by jpackage doesn't do anything but doesn't crash. The behavior is the same whether I use my own icon (a 48x48 icon created with the gimp) or if replace my icon file with javalogo_white_48.ico I can run more tests if necessary. Any help is appreciated, Cheers, Jon

2 1

RFR 8205991: Cannot start application (WinLauncher) if path contains non-ascii character
by Tornai András 08 Feb '19

08 Feb '19

Hi all, The issue was reported some time ago and it was closed (wont-fix) since javapackager was removed from JDK11. Hopefully jpackage will come back with JDK13 so I retested it with the latest jpackage* and it seems that the issue is still there. Are there any plans to fix this? Regards, András * https://jdk.java.net/jpackage/ jdk13/Build 8 (2019/1/8)

2 1

RFR: JDK-8217687: jpackage --help improvements
by Andy Herrick 08 Feb '19

08 Feb '19

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). JDK-8217687: jpackage --help improvements Changes to help text, internal names, and several tests. [1] https://bugs.openjdk.java.net/browse/JDK-8217687 [2] http://cr.openjdk.java.net/~herrick/8217687/webrev.01/

2 2

RFR: JDK-8214564 : --win-upgrade-uuid does not work as expected
by Alexander Matveev 07 Feb '19

07 Feb '19

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Upgrade did not work, because <MajorUpgrade> element was missing. Fixed by adding this element if --win-upgrade-uuid was provided. - Minor code clean up. Removed JPackageCreateImageBuildRootTest.java.rej. - Added JPackageCreateInstallerWinUpgradeUUIDTest for msi and exe. Note: For exe files which are not present in newer installation will not be removed. This is default behavior of InnoSetup installations. For msi older version will be completely removed before new one is installed. We will allow downgrades, upgrades and same version re-install for both msi and exe. [1] https://bugs.openjdk.java.net/browse/JDK-8214564 [2] http://cr.openjdk.java.net/~almatvee/8214564/webrev.00/ Thanks, Alexander

2 1

[PATCH] Improvements in jdk.internal.org.objectweb.asm.Type
by Сергей Цыпанов 07 Feb '19

07 Feb '19

Hello, several days ago I’ve proposed some improvements into asm library: - https://gitlab.ow2.org/asm/asm/commit/ef945457bc19dbc09c02bd21b52f1950990f3… - https://gitlab.ow2.org/asm/asm/commit/9b914d524b7fe7ea694fc11ec784e67133ba3… The patches were accepted and then it turned out the code I’ve patched is similar to what we have in JDK. So I propose the same changes to be accepted into JDK 12. They improve code by using more simple constructions and replacing redundant hand-written code with JDK-provided API. As of performance, usage of String::replace instead of handwritten replacement (see Type::appendDescriptor) is much faster and memory-effective (tested with JDK 11) even on simplest class names like java.lang.String: Benchmark Mode Cnt Score Error Units CharacterReplaceBenchmark.manualReplace avgt 25 57,036 ± 1,132 ns/op CharacterReplaceBenchmark.stringReplace avgt 25 17,648 ± 0,699 ns/op CharacterReplaceBenchmark.manualReplace:·gc.alloc.rate.norm avgt 25 112,000 ± 0,001 B/op CharacterReplaceBenchmark.stringReplace:·gc.alloc.rate.norm avgt 25 56,000 ± 0,001 B/op Corresponding benchmark available here: https://github.com/stsypanov/benchmarks/blob/master/benchmark-runners/src/m… https://github.com/stsypanov/benchmarks/blob/master/benchmark-source/src/ma… Usage of String::substring instead of StringBuilder.append(CharSequence, int, int) (see Type::getDescriptor) is also faster and memory-effective, results described here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-January/057834.ht… Also, is there any workload to measure effect of attached patch? Regards, Sergey Tsypanov

2 1

Review Request JDK-8218461: test/jdk/java/lang/invoke/VarHandles should be generated rather than manually edited
by Mandy Chung 06 Feb '19

06 Feb '19

This patch fixes up X-VarHandleTest* template files that are used to generate VarHandles tests. Since VarHandle::equals and VarHandle::hashCode methods are no longer implemented [1], I rename the testEqualsAndHashCode method to testEquals and further clean up the test case. Webrev: http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8218461/webrev.00/ Thanks Mandy [1] https://bugs.openjdk.java.net/browse/JDK-8215648

3 4

Review Request JDK-8218419: Can't get annotations that are present on packages in -Xbootclasspath/a
by Mandy Chung 06 Feb '19

06 Feb '19

BootClassLoader mistakenly overrides the 1-arg loadClassOrNull method instead of the 2-arg loadClassOrNull method. A class defined to the bootstrap class loader is intended to call JVM entry point to find such class rather than ClassLoader::defineClass method via the implementation-specific BootClassLoader instance. The patch is trivial; BootClassLoader overrides the two-arg loadClassOrNull instead. Webrev at: http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8218419/webrev.00 Thanks Mandy

2 2

RFR: JDK-8217894: jpackage CLI syntax changes
by Andy Herrick 06 Feb '19

06 Feb '19

Please review the jpackage fix for [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). In response to internal and external feedback, the following syntax changes are being made to jpackage Command Line Interface (CLI): 1.) remove "create-jre-installer <type>" mode, and add --runtime-installer option. 2.) remove the <type> arg from create-image mode, and add --installer-type option. 3.) rename the --class option to --main-class 4.) remove the --limit-modules option 5.) rename the --force option to --overwrite and improve it's help text. [1] https://bugs.openjdk.java.net/browse/JDK-8217894 [2] http://cr.openjdk.java.net/~herrick/8217894/webrev.01/index.html /Andy

4 6

RFR : 8217093: Support extended-length paths in parse_manifest.c on windows
by Baesken, Matthias 06 Feb '19

06 Feb '19

Hello, please review this small adjustment to parse_manifest.c . It adds support for extended - length paths (on Window) . (see https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file#maxim… For extended length paths ) Additionally , some small memory leaks are fixed in find_file . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8217093 http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.0/ Best rergards, Matthias

4 19