November 2021 - core-libs-dev

RFR: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"
by Daniel D.Daugherty 19 Nov '21

19 Nov '21

This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0. So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this [BACKOUT] has passed the macosx-aarch64 test task that was failing before. ------------- Commit messages: - Revert "8276150: Quarantined jpackage apps are labeled as "damaged"" Changes: https://git.openjdk.java.net/jdk/pull/6483/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6483&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277494 Stats: 102 lines in 2 files changed: 22 ins; 69 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/6483.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6483/head:pull/6483 PR: https://git.openjdk.java.net/jdk/pull/6483

3 6

RFR: 8275386: Change nested classes in jdk.jlink to static nested classes
by Andrey Turbanov 19 Nov '21

19 Nov '21

Non-static classes hold a link to their parent classes, which can be avoided. ------------- Commit messages: - [PATCH] Change nested classes in jdk.jlink to static nested classes Changes: https://git.openjdk.java.net/jdk/pull/5983/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5983&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275386 Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/5983.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5983/head:pull/5983 PR: https://git.openjdk.java.net/jdk/pull/5983

4 4

RFR: 8274946: Cleanup unnecessary calls to Throwable.initCause() in java.rmi
by Andrey Turbanov 19 Nov '21

19 Nov '21

Pass cause exception as constructor parameter is shorter and easier to read. ------------- Commit messages: - [PATCH] Cleanup unnecessary calls to Throwable.initCause() in java.rmi module Changes: https://git.openjdk.java.net/jdk/pull/5854/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5854&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274946 Stats: 20 lines in 5 files changed: 0 ins; 10 del; 10 mod Patch: https://git.openjdk.java.net/jdk/pull/5854.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5854/head:pull/5854 PR: https://git.openjdk.java.net/jdk/pull/5854

4 3

RFR: 8274333: Redundant null comparison after Pattern.split
by Andrey Turbanov 19 Nov '21

19 Nov '21

In couple of classes, result part of arrays of Pattern.split is compared with `null`. Pattern.split (and hence String.split) never returns `null` in array elements. Such comparisons are redundant. ------------- Commit messages: - [PATCH] Remove redundant 'null' comparison after Pattern.split Changes: https://git.openjdk.java.net/jdk/pull/5708/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5708&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274333 Stats: 15 lines in 2 files changed: 4 ins; 5 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/5708.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5708/head:pull/5708 PR: https://git.openjdk.java.net/jdk/pull/5708

6 5

RFR: 8274949: Use String.contains() instead of String.indexOf() in java.base
by Andrey Turbanov 19 Nov '21

19 Nov '21

String.contains was introduced in Java 5. Some code in java.base still uses old approach with `String.indexOf` to check if String contains specified substring. I propose to migrate such usages. Makes code shorter and easier to read. ------------- Commit messages: - [PATCH] Use String.contains() instead of String.indexOf() in java.base - [PATCH] Use String.contains() instead of String.indexOf() in java.base Changes: https://git.openjdk.java.net/jdk/pull/5559/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5559&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274949 Stats: 40 lines in 17 files changed: 0 ins; 3 del; 37 mod Patch: https://git.openjdk.java.net/jdk/pull/5559.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5559/head:pull/5559 PR: https://git.openjdk.java.net/jdk/pull/5559

6 6

RFR: JDKJDK-8276150: Quarantined jpackage apps are labeled as "damaged"
by Andy Herrick 19 Nov '21

19 Nov '21

JDKJDK-8276150: Quarantined jpackage apps are labeled as "damaged" ------------- Commit messages: - JDKJDK-8276150: Quarantined jpackage apps are labeled as "damaged" Changes: https://git.openjdk.java.net/jdk/pull/6396/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6396&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276150 Stats: 102 lines in 2 files changed: 69 ins; 22 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/6396.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6396/head:pull/6396 PR: https://git.openjdk.java.net/jdk/pull/6396

2 2

Supporting charset GB18030-2005
by Pushkar N Kulkarni 18 Nov '21

18 Nov '21

Hi there, OpenJDK currently supports version 2000 of the GB18030 (https://en.wikipedia.org/wiki/GB_18030) character set viz. GB18030-2000. The character mappings corresponding to Unicode codepoints '\u1E3F' and '\uE7C7' were swapped in a new version of the character set named GB18030-2005. I learn that this corrected a mistake in version 2000. OpenJDK does not support version 2005 as yet. Can someone please help me with reasons for the same, if any? We do have users requesting for 2005 support. While Linux (RHEL 7/8) has moved to supporting GB18030-2005 via glibc, Windows 10 and AIX 7.2 still have GB18030-2000 base. That means OpenJDK cannot move to GB18030-2005 base as yet. However, we can support both the versions until all the supported platforms move to GB18030-2005 base. Would that be an acceptable proposition? If we can have an enhancement request opened, I'd be glad to contribute the GB18030-2005 charset implementation. Thanks! Pushkar N Kulkarni, Developer, IBM Runtimes Simplicity is prerequisite for reliability - Edsger W. Dijkstra

2 4

RFR: 8276970: Default charset for PrintWriter that wraps PrintStream
by Naoto Sato 18 Nov '21

18 Nov '21

Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a PrintStream to its charset. This issue was raised during the conversations in https://github.com/openjdk/jdk/pull/5771 A corresponding CSR has also been drafted: https://bugs.openjdk.java.net/browse/JDK-8277078 ------------- Commit messages: - 8276970: Default charset for PrintWriter that wraps PrintStream Changes: https://git.openjdk.java.net/jdk/pull/6401/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6401&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276970 Stats: 129 lines in 4 files changed: 121 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk/pull/6401.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6401/head:pull/6401 PR: https://git.openjdk.java.net/jdk/pull/6401

5 18

RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales
by Naoto Sato 18 Nov '21

18 Nov '21

Please review the subject fix. In light of JEP400, Java runtime can/should start in UTF-8 charset if the underlying native encoding is not supported. ------------- Commit messages: - Use UTF-8 if jnuEncoding is not supported - Utilized 2-arg Charset.forName() - 8275007: Java fails to start with null charset if LC_ALL is set to certain Changes: https://git.openjdk.java.net/jdk/pull/6282/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6282&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275007 Stats: 22 lines in 3 files changed: 4 ins; 7 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/6282.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6282/head:pull/6282 PR: https://git.openjdk.java.net/jdk/pull/6282

7 48

RFR: 8276609: Invalid system property `jdk.serialFilter` set on the commd d line should cause `ExceptionInInitializerError`
by Roger Riggs 16 Nov '21

16 Nov '21

When set on the command line `jdk.serialFilter` to an invalid value, the invalid value is logged but the application is allowed to start without setting the filter. This leaves the application without the protections of the serial filter. The specification should be clarify that an `ExceptionInInitializerError` is thrown. ------------- Commit messages: - 8276609: Invalid system property `jdk.serialFilter` set on the command line should cause `ExceptionInInitializerError` Changes: https://git.openjdk.java.net/jdk/pull/6317/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6317&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276609 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/6317.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6317/head:pull/6317 PR: https://git.openjdk.java.net/jdk/pull/6317

4 5