November 2021 - core-libs-dev

RFR: 8275766: (tz) Update Timezone Data to 2021e
by Yoshiki Sato 02 Nov '21

02 Nov '21

Please review the integration of tzdata2021e (including tzdata2021d) to the JDK. The fix has passed all relevant JTREG regression tests and JCK tests. 8275754: (tz) Update Timezone Data to 2021d 8275849: TestZoneInfo310.java fails with tzdata2021e ------------- Commit messages: - 8275754: (tz) Update Timezone Data to 2021d Changes: https://git.openjdk.java.net/jdk/pull/6144/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6144&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275766 Stats: 52 lines in 6 files changed: 29 ins; 6 del; 17 mod Patch: https://git.openjdk.java.net/jdk/pull/6144.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6144/head:pull/6144 PR: https://git.openjdk.java.net/jdk/pull/6144

5 6

RFR: 8275735: [linux] Remove deprecated Metrics api (kernel memory limit)
by Severin Gehwolf 02 Nov '21

02 Nov '21

Please review this change to remove some API which no longer works as expected as recent OCI runtimes start to drop support for `--kernel-memory` switch. See the bug for references. This part of the API is not present in hotspot code. Testing: Container tests (cgroup v1) on Linux x86_64 (all pass) ------------- Commit messages: - 8275735: [linux] Remove deprecated Metrics api (kernel memory limit) Changes: https://git.openjdk.java.net/jdk/pull/6156/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6156&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275735 Stats: 104 lines in 6 files changed: 0 ins; 100 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/6156.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6156/head:pull/6156 PR: https://git.openjdk.java.net/jdk/pull/6156

3 4

RFR: 8252990: Intrinsify Unsafe.storeStoreFence
by Aleksey Shipilev 02 Nov '21

02 Nov '21

`Unsafe.storeStoreFence` currently delegates to stronger `Unsafe.storeFence`. We can teach compilers to map this directly to already existing rules that handle `MemBarStoreStore`. Like explicit `LoadFence`/`StoreFence`, we introduce the special node to differentiate explicit fence and implicit store-store barriers. This node is usually used to simulate safe `final`-field like constructions in special JDK classes, like `ConstantCallSite` and friends. Motivational performance difference on benchmarks from JDK-8276054 on ARM32: Benchmark Mode Cnt Score Error Units Multiple.plain avgt 3 2.669 ± 0.004 ns/op Multiple.release avgt 3 16.688 ± 0.057 ns/op Multiple.storeStore avgt 3 14.021 ± 0.144 ns/op // Better MultipleWithLoads.plain avgt 3 4.672 ± 0.053 ns/op MultipleWithLoads.release avgt 3 16.689 ± 0.044 ns/op MultipleWithLoads.storeStore avgt 3 14.012 ± 0.010 ns/op // Better MultipleWithStores.plain avgt 3 14.687 ± 0.009 ns/op MultipleWithStores.release avgt 3 45.393 ± 0.192 ns/op MultipleWithStores.storeStore avgt 3 38.048 ± 0.033 ns/op // Better Publishing.plain avgt 3 27.079 ± 0.201 ns/op Publishing.release avgt 3 27.088 ± 0.241 ns/op Publishing.storeStore avgt 3 27.009 ± 0.259 ns/op // Within error, hidden by allocation Single.plain avgt 3 2.670 ± 0.002 ns/op Single.releaseFence avgt 3 6.675 ± 0.001 ns/op Single.storeStoreFence avgt 3 8.012 ± 0.027 ns/op // Worse, seems to be ARM32 implementation artifact As expected, this does not affect x86_64 at all, because both `release` and `storeStore` are effectively no-ops, only affecting compiler optimizations: Benchmark Mode Cnt Score Error Units Multiple.plain avgt 3 0.406 ± 0.002 ns/op Multiple.release avgt 3 0.409 ± 0.018 ns/op Multiple.storeStore avgt 3 0.406 ± 0.001 ns/op MultipleWithLoads.plain avgt 3 4.328 ± 0.006 ns/op MultipleWithLoads.release avgt 3 4.600 ± 0.014 ns/op MultipleWithLoads.storeStore avgt 3 4.602 ± 0.006 ns/op MultipleWithStores.plain avgt 3 0.812 ± 0.001 ns/op MultipleWithStores.release avgt 3 0.812 ± 0.002 ns/op MultipleWithStores.storeStore avgt 3 0.812 ± 0.002 ns/op Publishing.plain avgt 3 6.370 ± 0.059 ns/op Publishing.release avgt 3 6.358 ± 0.436 ns/op Publishing.storeStore avgt 3 6.367 ± 0.054 ns/op Single.plain avgt 3 0.407 ± 0.039 ns/op Single.releaseFence avgt 3 0.406 ± 0.001 ns/op Single.storeStoreFence avgt 3 0.406 ± 0.001 ns/op Additional testing: - [x] Linux x86_64 fastdebug `tier1` ------------- Commit messages: - Formatting - Little cleanup - 8252990: Intrinsify Unsafe.storeStoreFence Changes: https://git.openjdk.java.net/jdk/pull/6136/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6136&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252990 Stats: 39 lines in 16 files changed: 33 ins; 5 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/6136.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6136/head:pull/6136 PR: https://git.openjdk.java.net/jdk/pull/6136

4 12

RFR: JDK-8276236: Table headers missing in Formatter api docs
by Ludvig Janiuk 02 Nov '21

02 Nov '21

Adds table headers to all tables in Formatter api docs. I inferred the header "Unicode" for the columns that contained unicode codepoints. Formatter api docs: https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Form… ------------- Commit messages: - Fixes JDK-8276236 Changes: https://git.openjdk.java.net/jdk/pull/6195/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6195&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276236 Stats: 80 lines in 1 file changed: 80 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/6195.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6195/head:pull/6195 PR: https://git.openjdk.java.net/jdk/pull/6195

3 3

RFR: JDK-8272192 Shortcut String equality checks by checking equality of the value array
by q2q-2q2 02 Nov '21

02 Nov '21

Shortcut String equality checks by checking equality of the value array ------------- Commit messages: - JDK-8272192 Changes: https://git.openjdk.java.net/jdk/pull/5370/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5370&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272192 Stats: 62 lines in 3 files changed: 60 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5370.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5370/head:pull/5370 PR: https://git.openjdk.java.net/jdk/pull/5370

5 5

RFR: 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc
by Masanori Yano 02 Nov '21

02 Nov '21

Could you please review the 8276164 bug fixes? I suggest adding the missing javadoc of `@throws IndexOutOfBoundsException`. ------------- Commit messages: - 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc Changes: https://git.openjdk.java.net/jdk/pull/6168/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6168&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276164 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/6168.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6168/head:pull/6168 PR: https://git.openjdk.java.net/jdk/pull/6168

2 4

RFR: 8275167: x86 intrinsic for unsignedMultiplyHigh
by Vamsi Parasa 02 Nov '21

02 Nov '21

Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction. This change show 1.87X improvement on a micro benchmark. ------------- Commit messages: - fix typo in function name - 8275167: x86 intrinsic for unsignedMultiplyHigh Changes: https://git.openjdk.java.net/jdk/pull/5933/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5933&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275167 Stats: 59 lines in 11 files changed: 59 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/5933.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5933/head:pull/5933 PR: https://git.openjdk.java.net/jdk/pull/5933

5 19

RFR: 8276234: Trivially clean up locale-related code
by Pavel Rappo 01 Nov '21

01 Nov '21

Please review this PR. A comprehensive test job has been scheduled; I'll notify this thread once that job has completed. ------------- Commit messages: - Fix *code* typo - Be more immutable - Fix typos Changes: https://git.openjdk.java.net/jdk/pull/6191/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6191&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276234 Stats: 10 lines in 3 files changed: 0 ins; 1 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/6191.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6191/head:pull/6191 PR: https://git.openjdk.java.net/jdk/pull/6191

5 10