November 2021 - core-libs-dev

RFR: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters
by Anirvan Sarkar 06 Nov '21

06 Nov '21

This fixes Properties.loadFromXML/storeToXML so that it works correctly for supplementary characters. ------------- Commit messages: - 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters Changes: https://git.openjdk.java.net/jdk/pull/6216/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6216&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276207 Stats: 90 lines in 3 files changed: 58 ins; 16 del; 16 mod Patch: https://git.openjdk.java.net/jdk/pull/6216.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6216/head:pull/6216 PR: https://git.openjdk.java.net/jdk/pull/6216

2 2

RFR: JDK-8276572: Fake libsyslookup.so library causes tooling issues
by Andrew John Hughes 05 Nov '21

05 Nov '21

The lack of anything to compile in `syslookup.c` is leading to a number of issues in our tooling, on some architectures more than others (s390x seems to be the most problematic). They expect to be able to retrieve debuginfo and compiler flags from generated .so files and fail with libsyslookup.so This simple patch adds a dummy function to `syslookup.c` so it appears more like a regular file to be compiled. I can't see this causing a problem with the symbol lookup, but we could filter it out on the Java side if need be. ------------- Commit messages: - JDK-8276572: Fake libsyslookup.so library causes tooling issues Changes: https://git.openjdk.java.net/jdk/pull/6245/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6245&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276572 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/6245.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6245/head:pull/6245 PR: https://git.openjdk.java.net/jdk/pull/6245

4 12

RFR: 8276635: Use blessed modifier order in compiler code
by Magnus Ihse Bursie 05 Nov '21

05 Nov '21

I ran bin/blessed-modifier-order.sh on source owned by compiler. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound. ------------- Commit messages: - 8276635: Use blessed modifier order in compiler code Changes: https://git.openjdk.java.net/jdk/pull/6253/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6253&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276635 Stats: 45 lines in 24 files changed: 0 ins; 0 del; 45 mod Patch: https://git.openjdk.java.net/jdk/pull/6253.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6253/head:pull/6253 PR: https://git.openjdk.java.net/jdk/pull/6253

2 3

RFR: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
by Jaikiran Pai 05 Nov '21

05 Nov '21

Can I please get a review for this change which fixes the issue reported in https://bugs.openjdk.java.net/browse/JDK-8275509? The `ModuleDescriptor.hashCode()` method uses the hash code of its various components to compute the final hash code. While doing so it ends up calling hashCode() on (collection of) various `enum` types. Since the hashCode() of enum types is generated from a call to `java.lang.Object.hashCode()`, their value isn't guaranteed to stay the same across multiple JVM runs. The commit here proposes to use the ordinal of the enum as the hash code. As Alan notes in the mailing list discussion, any changes to the ordinal of the enum (either due to addition of new value, removal of a value or just reordering existing values, all of which I think will be rare in these specific enum types) isn't expected to produce the same hash code across those changed runtimes and that should be okay. The rest of the ModuleDescriptor.hashCode() has been reviewed too and apart from calls to the enum types hashCode(), rest of the calls in that implementation, either directly or indirectly end up as calls on `java.lang.String.hashCode()` and as such aren't expected to cause non-deterministic values. A new jtreg test has been added to reproduce this issue and verify the fix. ------------- Commit messages: - minor test comment fix - 8275509: ModuleDescriptor.hashCode isn't reproducible across builds Changes: https://git.openjdk.java.net/jdk/pull/6078/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6078&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275509 Stats: 178 lines in 2 files changed: 174 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/6078.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6078/head:pull/6078 PR: https://git.openjdk.java.net/jdk/pull/6078

5 36

RFR: JDK-8276650: GenGraphs does not produce deterministic output
by Mandy Chung 04 Nov '21

04 Nov '21

The dot graph should print the edges in alphatical order. A simple fix to sort the edges before printing them. ------------- Commit messages: - JDK-8276650: GenGraphs does not produce deterministic output Changes: https://git.openjdk.java.net/jdk/pull/6266/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6266&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276650 Stats: 41 lines in 2 files changed: 2 ins; 1 del; 38 mod Patch: https://git.openjdk.java.net/jdk/pull/6266.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6266/head:pull/6266 PR: https://git.openjdk.java.net/jdk/pull/6266

3 4

RFR: JDK-8276653: Missing row headers in j.l.Character docs
by Ludvig Janiuk 04 Nov '21

04 Nov '21

The first table is missing row headers, adding them to aid screen readers. ------------- Commit messages: - Added row headers in Character docs Changes: https://git.openjdk.java.net/jdk/pull/6262/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6262&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276653 Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/6262.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6262/head:pull/6262 PR: https://git.openjdk.java.net/jdk/pull/6262

2 2

RFR: JDK-8276652: Missing row headers in MethodHandles.Lookup docs
by Ludvig Janiuk 04 Nov '21

04 Nov '21

Added row headers missing in the table captioned "Access mode summary". This carries no visual change, but might be useful for screen readers. ------------- Commit messages: - Added table headers Changes: https://git.openjdk.java.net/jdk/pull/6261/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6261&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276652 Stats: 34 lines in 1 file changed: 0 ins; 0 del; 34 mod Patch: https://git.openjdk.java.net/jdk/pull/6261.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6261/head:pull/6261 PR: https://git.openjdk.java.net/jdk/pull/6261

2 2

RFR: JDK-8276649: MethodHandles.Lookup docs: table could be list
by Ludvig Janiuk 04 Nov '21

04 Nov '21

Inferring from the flow of the text, the table should have been a list all along, so I've made it that way. Before and after for comparison: ![image](https://user-images.githubusercontent.com/6298393/140376551-6f8ac0c9-5336-4da0-8504-01af806ecae0.png) ![image](https://user-images.githubusercontent.com/6298393/140376679-54716d82-f431-46f7-b959-022374b6f893.png) ------------- Commit messages: - Oops, trailing whitespace - Single column table -> list Changes: https://git.openjdk.java.net/jdk/pull/6260/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6260&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276649 Stats: 34 lines in 1 file changed: 0 ins; 20 del; 14 mod Patch: https://git.openjdk.java.net/jdk/pull/6260.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6260/head:pull/6260 PR: https://git.openjdk.java.net/jdk/pull/6260

2 5

RFR: 8276629: Use blessed modifier order in core-libs code
by Magnus Ihse Bursie 04 Nov '21

04 Nov '21

I ran bin/blessed-modifier-order.sh on source owned by core-libs. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound. ------------- Commit messages: - 8276629: Use blessed modifier order in core-libs code Changes: https://git.openjdk.java.net/jdk/pull/6250/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6250&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276629 Stats: 44 lines in 28 files changed: 0 ins; 0 del; 44 mod Patch: https://git.openjdk.java.net/jdk/pull/6250.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6250/head:pull/6250 PR: https://git.openjdk.java.net/jdk/pull/6250

7 9

RFR: 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11
by Ivan Šipka 04 Nov '21

04 Nov '21

cc @ctornqvi ------------- Commit messages: - 8274122: added to problem list Changes: https://git.openjdk.java.net/jdk/pull/6025/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6025&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275650 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/6025.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6025/head:pull/6025 PR: https://git.openjdk.java.net/jdk/pull/6025

5 22