December 2021 - core-libs-dev

[jdk18] Integrated: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled
by Stuart Marks 22 Dec '21

22 Dec '21

On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks <smarks(a)openjdk.org> wrote: > Enable the security manager in rmiregistry's launcher arguments. This pull request has now been integrated. Changeset: 04ee9211 Author: Stuart Marks <smarks(a)openjdk.org> URL: https://git.openjdk.java.net/jdk18/commit/04ee9211fcc59178b3bfdfdda5e0def9b… Stats: 7 lines in 2 files changed: 4 ins; 0 del; 3 mod 8278967: rmiregistry fails to start because SecurityManager is disabled Reviewed-by: alanb, erikj ------------- PR: https://git.openjdk.java.net/jdk18/pull/45

1 0

RFR: Merge jdk18
by Jesper Wilhelmsson 22 Dec '21

22 Dec '21

Forwardport JDK 18 -> JDK 19 ------------- Commit messages: - Merge - 8274315: JFR: One closed state per file or stream - 8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters - 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in __write_sample_info__ - 8279007: jstatd fails to start because SecurityManager is disabled - 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM. - 8279045: Intrinsics missing vzeroupper instruction The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=6918&range=00.0 - jdk18: https://webrevs.openjdk.java.net/?repo=jdk&pr=6918&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/6918/files Stats: 260 lines in 21 files changed: 170 ins; 55 del; 35 mod Patch: https://git.openjdk.java.net/jdk/pull/6918.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6918/head:pull/6918 PR: https://git.openjdk.java.net/jdk/pull/6918

1 2

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled [v2]
by Stuart Marks 22 Dec '21

22 Dec '21

> Enable the security manager in rmiregistry's launcher arguments. Stuart Marks has updated the pull request incrementally with one additional commit since the last revision: Change java.security.manager to "allow"; filter warning lines from VersionCheck ------------- Changes: - all: https://git.openjdk.java.net/jdk18/pull/45/files - new: https://git.openjdk.java.net/jdk18/pull/45/files/e899bd2d..f713e731 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18&pr=45&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18&pr=45&range=00-01 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk18/pull/45.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/45/head:pull/45 PR: https://git.openjdk.java.net/jdk18/pull/45

3 3

RFR: Merge jdk18
by Jesper Wilhelmsson 21 Dec '21

21 Dec '21

Forwardport JDK 18 -> JDK 19 ------------- Commit messages: - Merge - 8278627: Shenandoah: TestHeapDump test failed - 8279074: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macosx-aarch64 - 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases. - 8278087: Deserialization filter and filter factory property error reporting under specified - 8279011: JFR: JfrChunkWriter incorrectly handles int64_t chunk size as size_t - 8274323: compiler/codegen/aes/TestAESMain.java failed with "Error: invalid offset: -1434443640" after 8273297 - 8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS - 8278413: C2 crash when allocating array of size too large - 8278970: [macos] SigningPackageTest is failed with runtime exception - ... and 9 more: https://git.openjdk.java.net/jdk/compare/f31dead6...d5d5bad9 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=6911&range=00.0 - jdk18: https://webrevs.openjdk.java.net/?repo=jdk&pr=6911&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/6911/files Stats: 1086 lines in 80 files changed: 695 ins; 107 del; 284 mod Patch: https://git.openjdk.java.net/jdk/pull/6911.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6911/head:pull/6911 PR: https://git.openjdk.java.net/jdk/pull/6911

1 2

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled
by Alan Bateman 21 Dec '21

21 Dec '21

On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks <smarks(a)openjdk.org> wrote: > Enable the security manager in rmiregistry's launcher arguments. As things stand, `rmiregsitry -J-Djava.security.manager` and `rmiregistry -J-Djava.security.manager=allow` are equivalent because rmiregistry sets the default SM. Some difference may be observed if someone is running rmiregistry with a custom system class loader set, or custom file system provider, or running it with a JVM TI agent that is looking at events between VMStart and VMInit but these seem somewhat obscure scenarios for a command line program If rmiregstry worked with ToolProvider then I think there would be more to discuss. If the final patch is to have the launcher set the default security manager then we may want to change RegistryImpl.createRegistry to fail if not set. The warning that is emitted for both cases is expected. JEP 411 is very clear that it there is no mechanism to suppress it. We may need to add a release note to document that rmiregistry will emit a warning a startup, that will at least be something to point at in the event that anyone asks or reports an issue. ------------- PR: https://git.openjdk.java.net/jdk18/pull/45

2 1

possible bug in jdeps as ToolProvider
by Raymond Augé 21 Dec '21

21 Dec '21

Hello everyone, At Alan's request [3] I'm posting this here. Alan mentions this is likely a manifestation of JDK-8277681 [4]. From the description I would agree. Here is a copy of the original message for posterity. ------------------- I believe I have found a small bug in jdeps tool when used as ToolProvider. I am invoking the jdeps impl via the ToolProvider API as follows (this code is also available here [2]): try (final StringWriter stdout = new StringWriter(); final StringWriter stderr = new StringWriter(); final PrintWriter pwout = new PrintWriter(stdout); final PrintWriter pwerr = new PrintWriter(stderr)) { return (ToolProvider.findFirst("jdeps").orElseThrow().run(pwout, pwerr, args) == 0) ? stdout.toString() : "Error: ".concat(stderr.toString()); } catch (Throwable t) { t.printStackTrace(); return "Error: " + t.getMessage(); } However repeat invocations result in the following exception: java.lang.Error: java.util.concurrent.ExecutionException: com.sun.tools.jdeps.MultiReleaseException at jdk.jdeps/com.sun.tools.jdeps.DependencyFinder.waitForTasksCompleted(DependencyFinder.java:271) at jdk.jdeps/com.sun.tools.jdeps.DependencyFinder.parse(DependencyFinder.java:133) at jdk.jdeps/com.sun.tools.jdeps.DepsAnalyzer.run(DepsAnalyzer.java:129) at jdk.jdeps/com.sun.tools.jdeps.ModuleExportsAnalyzer.run(ModuleExportsAnalyzer.java:74) at jdk.jdeps/com.sun.tools.jdeps.JdepsTask$ListModuleDeps.run(JdepsTask.java:1047) at jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:574) at jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:533) at jdk.jdeps/com.sun.tools.jdeps.Main.run(Main.java:64) at jdk.jdeps/com.sun.tools.jdeps.Main$JDepsToolProvider.run(Main.java:73) [snip] Caused by: java.util.concurrent.ExecutionException: com.sun.tools.jdeps.MultiReleaseException at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191) at jdk.jdeps/com.sun.tools.jdeps.DependencyFinder.waitForTasksCompleted(DependencyFinder.java:267) ... 24 more Caused by: com.sun.tools.jdeps.MultiReleaseException at jdk.jdeps/com.sun.tools.jdeps.VersionHelper.add(VersionHelper.java:62) at jdk.jdeps/com.sun.tools.jdeps.ClassFileReader$JarFileReader.readClassFile(ClassFileReader.java:360) at jdk.jdeps/com.sun.tools.jdeps.ClassFileReader$JarFileIterator.hasNext(ClassFileReader.java:402) at jdk.jdeps/com.sun.tools.jdeps.DependencyFinder.lambda$parse$5(DependencyFinder.java:179) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) In order to get around the error I do the following: public static final Field field; public static final Map<?,?> map; static { try { Class<?> clazz = Class.forName("com.sun.tools.jdeps.VersionHelper"); field = clazz.getDeclaredField("nameToVersion"); field.setAccessible(true); map = (Map<?,?>)field.get(null); } catch (ReflectiveOperationException e) { throw new RuntimeException(e); } } and tack a finally to the end of the try above: finally { map.clear(); } Now, additionally to be able to do that, I need to add an `--add-opens`: --add-opens jdk.jdeps/com.sun.tools.jdeps=ALL-UNNAMED I believe the solution is to clear the map in [1] when jdeps finishes. Finally, I would send a PR myself except I do not (yet) have an OCA and the solution seems simple enough if someone can confirm that this is indeed a bug. Ray [1] https://github.com/openjdk/jdk/blob/master/src/jdk.jdeps/share/classes/com/… [2] https://gist.github.com/rotty3000/d9feec79a66f14c2360fee9b9a1b2852 [3] https://mail.openjdk.java.net/pipermail/jdk-dev/2021-December/006291.html [4] https://bugs.openjdk.java.net/browse/JDK-8277681

2 6

[jdk18] Integrated: 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases.
by Roger Riggs 21 Dec '21

21 Dec '21

8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases. ------------- Commit messages: - Backport 8c0bb53f5ba6e71b81c9cb99e6f1587150fe531a Changes: https://git.openjdk.java.net/jdk18/pull/58/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=58&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278044 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18/pull/58.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/58/head:pull/58 PR: https://git.openjdk.java.net/jdk18/pull/58

1 1

[jdk18] Integrated: 8278087: Deserialization filter and filter factory property error reporting under specified
by Roger Riggs 21 Dec '21

21 Dec '21

8278087: Deserialization filter and filter factory property error reporting under specified ------------- Commit messages: - Backport f90425a1cbbc686045c87086af586e62f05f6c49 Changes: https://git.openjdk.java.net/jdk18/pull/55/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=55&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278087 Stats: 219 lines in 4 files changed: 136 ins; 15 del; 68 mod Patch: https://git.openjdk.java.net/jdk18/pull/55.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/55/head:pull/55 PR: https://git.openjdk.java.net/jdk18/pull/55

1 1

RFR: 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases.
by Roger Riggs 21 Dec '21

21 Dec '21

The specification of ObjectInputStream constructors that invoke `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention exceptions that may be thrown by the apply() method. In both constructors, add the following to the paragraph the describes invoking the factory: * When the filter factory {@code apply} method is invoked it may throw a runtime exception * preventing the {@code ObjectInputStream} from being constructed. ------------- Commit messages: - 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases. Changes: https://git.openjdk.java.net/jdk/pull/6704/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6704&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278044 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/6704.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6704/head:pull/6704 PR: https://git.openjdk.java.net/jdk/pull/6704

3 5

RFR: 8278087: Redesign exceptions thrown for invalid jdk.serialFilter and jdk.serialFilterFactory.
by Roger Riggs 21 Dec '21

21 Dec '21

The effects of invalid values of `jdk.serialFilter` and `jdk.serialFilterFactory` properties are incompletely specified. The behavior for invalid values of the properties is different and use an unconventional exception type, `ExceptionInInitializerError` and leave the `OIF.Config` class uninitialized. The exceptions in the `ObjectInputFilter.Config` class initialization caused by invalid values of the two properties, either by system properties supplied on the command line or security properties are logged. The `Config` class marks either or both the filter and filter factory values as unusable and remembers the exception message. Subsequent calls to the methods that get or set the filter or filter factory or create an `ObjectInputStream` throw `java.lang.IllegalStateException` with the remembered exception message. Constructing an `ObjectInputStream` calls both `Config.getSerialFilter` and `Config.getSerialFilterFactory`. The nature of the invalid property is reported as an `IllegalStateException` on first use. This PR supercedes https://github.com/openjdk/jdk/pull/6508 Document that setting an invalid property jdk.serialFilter disables deserialization ------------- Commit messages: - 8278087: Redesign exceptions thrown for invalid jdk.serialFilter and jdk.serialFilterFactory. Changes: https://git.openjdk.java.net/jdk/pull/6645/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6645&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278087 Stats: 218 lines in 4 files changed: 137 ins; 15 del; 66 mod Patch: https://git.openjdk.java.net/jdk/pull/6645.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6645/head:pull/6645 PR: https://git.openjdk.java.net/jdk/pull/6645

4 12