December 2021 - core-libs-dev

RFR: JDK-8278953: Clarify Class.getDeclaredConstructor specification
by Joe Darcy 21 Dec '21

21 Dec '21

Cleanup and regularization of the specs of the four get[Declared]Constructor[s] methods. ------------- Commit messages: - JDK-8278953: Clarify Class.getDeclaredConstructor specification Changes: https://git.openjdk.java.net/jdk/pull/6897/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6897&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278953 Stats: 20 lines in 1 file changed: 11 ins; 4 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/6897.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6897/head:pull/6897 PR: https://git.openjdk.java.net/jdk/pull/6897

3 5

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled
by Stuart Marks 20 Dec '21

20 Dec '21

On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks <smarks(a)openjdk.org> wrote: > Enable the security manager in rmiregistry's launcher arguments. I think there's little to worry about with custom configurations of the `rmiregistry` tool. What somebody might do is to enable a customized security manager using properties... of course they'd also have to ensure that the customized SM is somewhere in the classpath as well, by adding more command line options. That seems fairly unlikely to me. Anyone who wants to run an RMI registry service in some specialized configuration would probably just set things up themselves and then use the `LocateRegistry.createRegistry` API instead of trying to tinker with the `rmiregistry` command. If `rmiregistry` enables the SM using properties, then yes we can probably change the code to assert that the SM is running instead of conditionally enabling it like it does now. Next headache is that `tools/launcher/VersionCheck.jtr` fails because it sees the warning messages instead of the version string. (Argh!) Interestingly this test passes even though `rmiregistry` currently fails to operate normally, because it runs well enough to print its version string, but not well enough to start up a registry service. (Double argh!) The warnings policy is a separate issue being discussed elsewhere. ------------- PR: https://git.openjdk.java.net/jdk18/pull/45

1 0

RFR: 8261404: Class.getReflectionFactory() is not thread-safe
by liach 17 Dec '21

17 Dec '21

Simply changes this to only read the static field once to prevent `null` on second read. ------------- Commit messages: - 8261404: Class.getReflectionFactory() is not thread-safe Changes: https://git.openjdk.java.net/jdk/pull/6870/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6870&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261404 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/6870.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6870/head:pull/6870 PR: https://git.openjdk.java.net/jdk/pull/6870

3 7

[jdk18] RFR: 8278907: JPackage test - SigningPackageTest is failed with runtime exception
by Alexander Matveev 17 Dec '21

17 Dec '21

This is regression from JDK-8263155. MacHelper.java is now calling test verification callback with all content in DMG root. SigningPackageTest expects only path with app name in it and thus it fails when trying to verify app inside ".background" folder. Fixed by checking that provided path for verification is actually an application we expecting. All other paths are ignored. ------------- Commit messages: - 8278907: JPackage test - SigningPackageTest is failed with runtime exception Changes: https://git.openjdk.java.net/jdk18/pull/42/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=42&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278907 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk18/pull/42.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/42/head:pull/42 PR: https://git.openjdk.java.net/jdk18/pull/42

3 3

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v6]
by Roger Riggs 17 Dec '21

17 Dec '21

On Thu, 9 Dec 2021 13:03:39 GMT, Сергей Цыпанов <duke(a)openjdk.java.net> wrote: >> Instead of something like >> >> long x; >> long y; >> return (x < y) ? -1 : ((x == y) ? 0 : 1); >> >> we can use `return Long.compare(x, y);` >> >> All replacements are done with IDE. > > Сергей Цыпанов has updated the pull request incrementally with two additional commits since the last revision: > > - 8277868: Use Long.compare() for mostSigBits as well > - Revert "8277868: Adjust JavaDoc of UUID" > > This reverts commit f3b95d0e247cf6452955f4f24684fd60d5cb8902. As it turns out replacing the code was not 100% equivalent and a test failure resulted. See https://bugs.openjdk.java.net/browse/JDK-8278937 Double.compare and the original code handle the non-numeric forms of Double differently. ------------- PR: https://git.openjdk.java.net/jdk/pull/6575

1 0

[jdk18] Integrated: 8278587: StringTokenizer(String, String, boolean) documentation bug
by Naoto Sato 17 Dec '21

17 Dec '21

8278587: StringTokenizer(String, String, boolean) documentation bug ------------- Commit messages: - Backport 8f5fdd864b6f1cf4a2d9d961d8d4118960f0751e Changes: https://git.openjdk.java.net/jdk18/pull/43/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=43&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278587 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk18/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/43/head:pull/43 PR: https://git.openjdk.java.net/jdk18/pull/43

1 1

RFR: Merge jdk18
by Jesper Wilhelmsson 17 Dec '21

17 Dec '21

Forwardport JDK 18 -> JDK 19 ------------- Commit messages: - Merge - 8278574: update --help-extra message to include default value of --finalization option - 8278389: SuspendibleThreadSet::_suspend_all should be volatile/atomic - 8278575: update jcmd GC.finalizer_info to list finalization status The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=6873&range=00.0 - jdk18: https://webrevs.openjdk.java.net/?repo=jdk&pr=6873&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/6873/files Stats: 29 lines in 4 files changed: 12 ins; 1 del; 16 mod Patch: https://git.openjdk.java.net/jdk/pull/6873.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6873/head:pull/6873 PR: https://git.openjdk.java.net/jdk/pull/6873

1 1

[jdk18] RFR: 8276826: Clarify the ModuleDescriptor.Version specification’s treatment of repeated punctuation characters
by Mark Reinhold 17 Dec '21

17 Dec '21

Please review this tiny specification clarification. ------------- Commit messages: - 8278465: Clarify the ModuleDescriptor.Version specification’s treatment of repeated punctuation characters Changes: https://git.openjdk.java.net/jdk18/pull/39/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=39&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276826 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/39/head:pull/39 PR: https://git.openjdk.java.net/jdk18/pull/39

3 4

RFR: 8278587: StringTokenizer(String, String, boolean) documentation bug
by Naoto Sato 16 Dec '21

16 Dec '21

This is a doc fix to `StringTokenizer`, where the original spec does not account for the delimiter's length in the case of a supplementary character. Corresponding CSR has been drafted: https://bugs.openjdk.java.net/browse/JDK-8278814 ------------- Commit messages: - 8278587: StringTokenizer(String, String, boolean) documentation bug Changes: https://git.openjdk.java.net/jdk/pull/6836/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6836&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278587 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/6836.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6836/head:pull/6836 PR: https://git.openjdk.java.net/jdk/pull/6836

6 8

RFR: 8277868: Use Comparable.compare() instead of surrogate code
by Сергей Цыпанов 16 Dec '21

16 Dec '21

Instead of something like long x; long y; return (x < y) ? -1 : ((x == y) ? 0 : 1); we can use `return Long.compare(x, y);` All replacements are done with IDE. ------------- Commit messages: - 8277868: Use Comparable.compare() instead of surrogate code Changes: https://git.openjdk.java.net/jdk/pull/6575/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6575&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277868 Stats: 70 lines in 12 files changed: 2 ins; 44 del; 24 mod Patch: https://git.openjdk.java.net/jdk/pull/6575.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6575/head:pull/6575 PR: https://git.openjdk.java.net/jdk/pull/6575

6 14