February 2021 - core-libs-dev

RFR: 8261030: Avoid loading GenerateJLIClassesHelper at runtime
by Claes Redestad 04 Feb '21

04 Feb '21

This moves the tracing methods added to GenerateJLIClassesHelper in JDK-8252725 to MethodHandleStatics, which avoids loading at runtime some code meant for jlink. ------------- Commit messages: - Remove unused import, copyrights - Move tracing methods and constants from GenerateJLIClassesHelper to MethodHandleStatics Changes: https://git.openjdk.java.net/jdk/pull/2376/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2376&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261030 Stats: 69 lines in 4 files changed: 34 ins; 30 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/2376.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2376/head:pull/2376 PR: https://git.openjdk.java.net/jdk/pull/2376

2 3

RFR: 8261036: Reduce classes loaded by CleanerFactory initialization
by Claes Redestad 04 Feb '21

04 Feb '21

This patch refactors CleanerFactory and InnocuousThread so that we need to load fewer PrivilegedActions. This slightly reduce the number of classes we always load on bootstrap, slightly reducing static and dynamic footprint (default CDS archive -4Kb). ------------- Commit messages: - Reduce classes loaded by CleanerFactory initialization Changes: https://git.openjdk.java.net/jdk/pull/2380/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2380&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261036 Stats: 49 lines in 2 files changed: 26 ins; 9 del; 14 mod Patch: https://git.openjdk.java.net/jdk/pull/2380.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2380/head:pull/2380 PR: https://git.openjdk.java.net/jdk/pull/2380

2 5

RFR: Merge jdk16
by Jesper Wilhelmsson 04 Feb '21

04 Feb '21

Forwardport JDK 16 -> JDK 17 ------------- Commit messages: - Merge - 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35) - 8260704: ParallelGC: oldgen expansion needs release-store for _end - 8260927: StringBuilder::insert is incorrect without Compact Strings - 8258378: Final nroff manpage update for JDK 16 - 8257215: JFR: Events dropped when streaming over a chunk rotation - 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled - 8260632: Build failures after JDK-8253353 - 8260339: JVM crashes when executing PhaseIdealLoop::match_fill_loop - 8260608: add a regression test for 8260370 - ... and 2 more: https://git.openjdk.java.net/jdk/compare/f025bc1d...dad835ee The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=2392&range=00.0 - jdk16: https://webrevs.openjdk.java.net/?repo=jdk&pr=2392&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/2392/files Stats: 2645 lines in 56 files changed: 2497 ins; 69 del; 79 mod Patch: https://git.openjdk.java.net/jdk/pull/2392.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2392/head:pull/2392 PR: https://git.openjdk.java.net/jdk/pull/2392

1 1

RFR: 8261010: Delete the Netbeans "default" license header
by Sergey Bylokhov 03 Feb '21

03 Feb '21

Trivial cleanup, the "default" license header is removed in a few components. ------------- Commit messages: - Initial fix Changes: https://git.openjdk.java.net/jdk/pull/2368/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2368&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261010 Stats: 14 lines in 3 files changed: 0 ins; 14 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2368.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2368/head:pull/2368 PR: https://git.openjdk.java.net/jdk/pull/2368

3 3

RFR: 8166026: Refactor java/lang shell tests to java
by Ivan Šipka 03 Feb '21

03 Feb '21

Refactor `test/jdk/java/lang/Thread/UncaughtExceptions.sh` as java test. ------------- Commit messages: - 8166026: Refactor java/lang shell tests to java Changes: https://git.openjdk.java.net/jdk/pull/1578/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1578&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8166026 Stats: 411 lines in 2 files changed: 206 ins; 205 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/1578.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1578/head:pull/1578 PR: https://git.openjdk.java.net/jdk/pull/1578

2 11

RFR: 8260617: Merge ZipFile encoding check with the initial hash calculation
by Claes Redestad 03 Feb '21

03 Feb '21

- Merge checkEncoding into the byte[]-based normalizedHash. The latter is only used from ZipFile.initCEN right after the checkEncoding today, so verifying this is equivalent is straightforward. - Factor out the logic to calculate hash, check encoding etc into the addEntry method to allow JITs to chew off larger chunks of the logic early on Roughly 1.2x speedup on the JarFileMeta microbenchmarks, which include the time required to open the jar file and thus exercising the optimized code. Testing: tier1-4 ------------- Commit messages: - Refactor ZipFile.initCEN, merging checkEncoding and normalizedHash Changes: https://git.openjdk.java.net/jdk/pull/2306/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2306&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260617 Stats: 132 lines in 2 files changed: 31 ins; 68 del; 33 mod Patch: https://git.openjdk.java.net/jdk/pull/2306.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2306/head:pull/2306 PR: https://git.openjdk.java.net/jdk/pull/2306

2 11

RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX
by Ioi Lam 03 Feb '21

03 Feb '21

- JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which allowed the same JDK library to use different version of HotSpot. However, HSX is no longer supported so this API should be removed. - Implementations of APIs such as JVM_DTraceActivate, were removed in [JDK-8068976](https://bugs.openjdk.java.net/browse/JDK-8068976), so their declarations should be removed from jvm.h ------------- Commit messages: - 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX Changes: https://git.openjdk.java.net/jdk/pull/2338/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2338&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260193 Stats: 110 lines in 3 files changed: 0 ins; 109 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2338.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2338/head:pull/2338 PR: https://git.openjdk.java.net/jdk/pull/2338

5 11

Trying to fix JDK-8013527 - 1st Prototype
by Johannes Kuhn 03 Feb '21

03 Feb '21

JDK-8013527[1] has somehow become the umbrella bug for "Using MethodHandles to call caller sensitive methods leads to interesting results". To recap: A caller sensitive method knows about who called it, and can behave differently when called from an other context. Examples are: Class.forName, MethodHandles.lookup, Method.invoke... A MethodHandle on the other hand should not be caller sensitive. To archive this, a MethodHandle will "bind" the lookup class as caller for caller sensitive methods. This is currently done by injecting a hidden class (InjectedInvoker" that acts as a trampoline for calling caller sensitive methods. This injected invoker shares many properties of the original caller: Same ClassLoader, same Module, same Package, same ProtectionDomain, but it's not the same class or a nestmate of it. For caller sensitive methods that do look at more than just the injected invoker, this leads to "unexpected" results when called through a MethodHandle: * MethodHandles.lookup() returns a full privileged lookup for the injected invoker. * jlr.Field.get*/set*, jlr.Constructor.newInstance, jlr.Method.invoke may fail with an IllegalAccessException if the target is private. See JDK-8257874[2]. ----------------------------------- After reading one of John Rose's comments[3], I thought that this might be a way to solve this general problem. So I implemented some of it here[4]. The basic idea is that there is a private overload of the caller sensitive method which accepts the caller as a tailing argument. The good news: * tier1 Tests pass. * ((Lookup) lookup.findStatic(MethodHandles.class, "lookup", MethodType.methodType(Lookup.class)).invokeExact()).lookupClass() == lookup.lookupClass(); * JDK-8257874 can't be reproduced with Field.* or Constructor. * Performance is likely better. (InjectedInvoker collects all arguments into an Object[].) The bad news: * If you use a MethodHandle to call Method.invoke for a caller sensitive method, then you can still observe the injected invoker. ----------------------------------- Moving forward, there are 3 ways: 1. Do nothing. Won't fix any bug. 2. Use the current prototype, and accept Method.invoke is odd when calling it through a MethodHandle. 3. Go all in: * Require **every** caller sensitive method to have a private overload. * Method.invoke will also use that private overload. The problems with the 3rd approach are: * What about methods that can be called virtually? (Thread.getContextClassLoader()) * Requires a few changes to MethodAccessor. Maybe implementing JDK-6824466[5] first? * What about methods that do stack walks? I have to think more about the problems listed above - but maybe you have some input that could help me on that. - Johannes [1]: https://bugs.openjdk.java.net/browse/JDK-8013527 [2]: https://bugs.openjdk.java.net/browse/JDK-8257874 [3]: https://bugs.openjdk.java.net/browse/JDK-8020968?focusedCommentId=13611844&… [4]: https://github.com/openjdk/jdk/pull/2117/files [5]: https://bugs.openjdk.java.net/browse/JDK-6824466

2 1

RFR: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy'
by Alexander Matveev 03 Feb '21

03 Feb '21

We did not able to run "hdiutil convert" due to hdiutil did not able to acquire lock on DMG image file. In this condition we got "Resource busy" from "hdiutil detach" and on repeated attempt we was getting "File Not Found" error. According to some research "Resource Busy" is normal error message for "hdiutil detach" and can happen, but it should go away soon assuming nothing else is broken. I think due to we using "-force" flag we still ejected DMG image and left system in bad stage. After re-fixing repeated detach with force this issue is not longer reproducible. I still left code for forced detach if we did not able to detach it. Also, I added work around (in case we had to do forced detach) is to convert copy of original DMG image. This work around seems to solves problem as well when hdiutil cannot acquire lock on file. I also fixed in same way detach in our test helper. ------------- Commit messages: - 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject disk2 - Resource busy' Changes: https://git.openjdk.java.net/jdk/pull/2345/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2345&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259570 Stats: 162 lines in 3 files changed: 151 ins; 1 del; 10 mod Patch: https://git.openjdk.java.net/jdk/pull/2345.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2345/head:pull/2345 PR: https://git.openjdk.java.net/jdk/pull/2345

3 6

Integrated: JDK-8261003 : Bad Copyright header format after JDK-8183372
by Mahendra Chhipa 02 Feb '21

02 Feb '21

JDK-8261003 : Bad Copyright header format after JDK-8183372 ------------- Commit messages: - JDK-8261003 : Bad Copyright header format after JDK-8183372 Changes: https://git.openjdk.java.net/jdk/pull/2365/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2365&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261003 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2365.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2365/head:pull/2365 PR: https://git.openjdk.java.net/jdk/pull/2365

2 2