February 2021 - core-libs-dev

RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java
by Mahendra Chhipa 02 Feb '21

02 Feb '21

https://bugs.openjdk.java.net/browse/JDK-8183372 ------------- Commit messages: - JDK-8183372 : Refactor java/lang/Class shell tests to java Changes: https://git.openjdk.java.net/jdk/pull/2170/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2170&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8183372 Stats: 296 lines in 4 files changed: 137 ins; 115 del; 44 mod Patch: https://git.openjdk.java.net/jdk/pull/2170.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2170/head:pull/2170 PR: https://git.openjdk.java.net/jdk/pull/2170

4 38

RFR: 8260959: remove RECORDS from PreviewFeature.Feature enum
by Vicente Romero 02 Feb '21

02 Feb '21

Please review this simple fix that is removing the RECORDS enum constant from the PreviewFeature.Feature enum, now that RECORDS are final in 16 this constant can be safely removed. Thanks, Vicente ------------- Commit messages: - 8260959: remove RECORDS from PreviewFeature.Feature enum Changes: https://git.openjdk.java.net/jdk/pull/2360/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2360&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260959 Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2360.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2360/head:pull/2360 PR: https://git.openjdk.java.net/jdk/pull/2360

1 0

[jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings
by Aleksey Shipilev 02 Feb '21

02 Feb '21

Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by default. But the bug is actually generic: $ CONF=linux-x86_64-server-fastdebug make run-test TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-XX:-CompactStrings" test Insert.insertOffset(): failure java.lang.AssertionError: expected [??abc] but found [efabc] at org.testng.Assert.fail(Assert.java:94) at org.testng.Assert.failNotEquals(Assert.java:496) at org.testng.Assert.assertEquals(Assert.java:125) at org.testng.Assert.assertEquals(Assert.java:178) at org.testng.Assert.assertEquals(Assert.java:188) at Insert.insertOffset(Insert.java:45) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) I believe this is a regression from [JDK-8254082](https://bugs.openjdk.java.net/browse/JDK-8254082). Additional testing: - [x] Linux x86_64 `tier1` default, passes - [x] Linux x86_64 `tier1`, `-XX:-CompactStrings`, passes modulo two testbugs ([JDK-8260933](https://bugs.openjdk.java.net/browse/JDK-8260933), [JDK-8260934](https://bugs.openjdk.java.net/browse/JDK-8260934)) - [x] Linux ARM32, affected test now passes ------------- Commit messages: - 8260927: StringBuilder::insert is incorrect without Compact Strings Changes: https://git.openjdk.java.net/jdk16/pull/143/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=143&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260927 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk16/pull/143.diff Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/143/head:pull/143 PR: https://git.openjdk.java.net/jdk16/pull/143

5 9

RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java
by Daniel D.Daugherty 02 Feb '21

02 Feb '21

A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details). ------------- Commit messages: - 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java Changes: https://git.openjdk.java.net/jdk/pull/2341/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2341&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260860 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2341.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2341/head:pull/2341 PR: https://git.openjdk.java.net/jdk/pull/2341

4 6

[jdk16] RFR: 8258378: Final nroff manpage update for JDK 16
by Magnus Ihse Bursie 02 Feb '21

02 Feb '21

Before RC phase we need to ensure we have the final set of manpage updates published in OpenJDK. ------------- Commit messages: - 8258378: Final nroff manpage update for JDK 16 Changes: https://git.openjdk.java.net/jdk16/pull/142/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=142&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258378 Stats: 238 lines in 27 files changed: 98 ins; 111 del; 29 mod Patch: https://git.openjdk.java.net/jdk16/pull/142.diff Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/142/head:pull/142 PR: https://git.openjdk.java.net/jdk16/pull/142

3 5

Why does Set.of disallow duplicate elements?
by dfranken.jdk＠gmail.com 02 Feb '21

02 Feb '21

Dear users, While looking at the implementation of Set.of(...) I noticed that duplicate elements are not allowed, e.g. Set.of(1, 1) will throw an IllegalArgumentException. Why has it been decided to do this? My expectation was that duplicates would simply be removed. If I do for instance new HashSet<>(<collection containing duplicates>) it works and duplicates are removed. To me, it looks a bit inconsistent to have duplicates removed for a collection passed in the constructor, but not for a collection (even though it is a vararg array) passed to a static factory method. Kind regards, Dave Franken

6 6

RFR: JDK-8257086: Clarify differences between {Float, Double}.equals and ==
by Joe Darcy 02 Feb '21

02 Feb '21

Updates to the specifications of Double.{equals, compareTo} to explain more explicitly why the obvious wrappers around "==" and "<"/"==" are not sufficient for floating-point values. Once the wording is worked out, I'll replicate it for the analogous methods on Float. ------------- Commit messages: - Fix whitespace - Initial work for JDK-8257086. Changes: https://git.openjdk.java.net/jdk/pull/1699/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1699&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257086 Stats: 65 lines in 1 file changed: 47 ins; 0 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/1699.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1699/head:pull/1699 PR: https://git.openjdk.java.net/jdk/pull/1699

5 17

RFR: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues
by Athijegannathan Sundararajan 01 Feb '21

01 Feb '21

Fixed compilation issues with the test. Test compiles and runs fine locally. ------------- Commit messages: - 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues Changes: https://git.openjdk.java.net/jdk/pull/2091/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2091&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259814 Stats: 16 lines in 1 file changed: 5 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/2091.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2091/head:pull/2091 PR: https://git.openjdk.java.net/jdk/pull/2091

3 5

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v3]
by Alexey Semenyuk 01 Feb '21

01 Feb '21

> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. App launcher is pure C and doesn't have C++ code. App launcher lib incorporates bulk of C++ code from app launcher. > At startup app launcher loads launcher shared lib and calls functions it provides to get data for launching JVM (path to jli lib and arguments for JLI_Launch function call). > App launcher unloads launcher shared lib before launching JVM to remove C++ runtime from the process memory. > > Getting rid of C++ code from app launcher required to rewrite app installation location lookup code from C++ to C. LinuxPackage.c source is C alternative for https://github.com/openjdk/jdk/blob/master/src/jdk.jpackage/linux/native/ap… and https://github.com/openjdk/jdk/blob/master/src/jdk.jpackage/linux/native/ap…. > > Layout of jpackage's native code changed: > - `common`: code shared between all jpackage binaries. > - `applauncher`: launcher only code. > - `applauncherlib`: launcher lib code on Linux and launcher code on other platforms. > - `applaunchercommon`: code shared between launcher and launcher lib on Linux and launcher code on other platforms. Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: 8254702: jpackage app launcher crashes on CentOS ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2320/files - new: https://git.openjdk.java.net/jdk/pull/2320/files/b493bcfd..91744255 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2320&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2320&range=01-02 Stats: 9 lines in 13 files changed: 0 ins; 9 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2320.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2320/head:pull/2320 PR: https://git.openjdk.java.net/jdk/pull/2320

1 0

Comment on 8260692: Matematically wrong implementations of RoundingMode.HALF_UP and .HALF_DOWN
by Raffaello Giulietti 01 Feb '21

01 Feb '21

Hi, in my opinion, and contrary to the report [1], the described issue is not a bug. While the wording used in the spec of java.math.RoundingMode could be improved, it is nonetheless clear enough to avoid any confusion about what HALF_DOWN and HALF_UP mean in this context. The actual values reported are all correct while the expected ones are not. I think the issue can be closed as not relevant. Greetings Raffaello ---- [1] https://bugs.openjdk.java.net/browse/JDK-8260692

2 1