April 2021 - core-libs-dev

RFR: JDK-8265496: improve null check in DeflaterOutputStream/InflaterInputStream
by Hamlin Li 27 Apr '21

27 Apr '21

code like below will create Deflater before null check, although it's not a real mem leak, but it's better to do null check before new Deflater. try { DeflaterOutputStream dos = new DeflaterOutputStream(null); } catch (NullPointerException e) { passed = true; } Similar issues exist in several other classes. ------------- Commit messages: - JDK-8265496: improve null check in DeflaterOutputStream/InflaterInputStream Changes: https://git.openjdk.java.net/jdk/pull/3681/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3681&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265496 Stats: 7 lines in 7 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/3681.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3681/head:pull/3681 PR: https://git.openjdk.java.net/jdk/pull/3681

4 7

RFR: 4926314: Optimize Reader.read(CharBuffer)
by Philippe Marschall 26 Apr '21

26 Apr '21

Implement three optimiztations for Reader.read(CharBuffer) * Add a code path for heap buffers in Reader#read to use the backing array instead of allocating a new one. * Change the code path for direct buffers in Reader#read to limit the intermediate allocation to `TRANSFER_BUFFER_SIZE`. * Implement `InputStreamReader#read(CharBuffer)` and delegate to `StreamDecoder`. * Implement `StreamDecoder#read(CharBuffer)` and avoid buffer allocation. ------------- Commit messages: - 4926314: Optimize Reader.read(CharBuffer) Changes: https://git.openjdk.java.net/jdk/pull/1915/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1915&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-4926314 Stats: 101 lines in 3 files changed: 68 ins; 8 del; 25 mod Patch: https://git.openjdk.java.net/jdk/pull/1915.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1915/head:pull/1915 PR: https://git.openjdk.java.net/jdk/pull/1915

7 47

RFR: 8265961: Fix comments in logging.properties
by Pavel Rappo 26 Apr '21

26 Apr '21

I had been looking for an example of a "properties" file when spotted a typo in `logging.properties`. I decided to proofread the file. That resulted in finding a few other issues. ------------- Commit messages: - Initial commit Changes: https://git.openjdk.java.net/jdk/pull/3688/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3688&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265961 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/3688.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3688/head:pull/3688 PR: https://git.openjdk.java.net/jdk/pull/3688

5 9

RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI
by Conor Cleary 26 Apr '21

26 Apr '21

### Description This fix is part of a previous effort to both cleanup/modernise JNDI code, the details of which can be seen in [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number JNDI methods under `java.naming` use Anonymous Inner Classes in cases where only a single object unique to the requirements of the method is used. The issues these occurrences of AICs cause are highlighted below. - AICs, in the cases concerned with this fix, are used where only one operation is required. While AICs can be useful for more complex implementations (using interfaces, multiple methods needed, local fields etc.), Lambdas are better suited here as they result in a more readable and concise solution. ### Fixes - Where applicable, occurrences of AICs were replaced with lambdas to address the issues above resulting primarily in more readable/concise code. ------------- Commit messages: - 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI Changes: https://git.openjdk.java.net/jdk/pull/3416/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3416&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8048199 Stats: 75 lines in 5 files changed: 0 ins; 42 del; 33 mod Patch: https://git.openjdk.java.net/jdk/pull/3416.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3416/head:pull/3416 PR: https://git.openjdk.java.net/jdk/pull/3416

7 23

RFR: 8265746: Update java.time to use instanceof pattern variable (part II)
by Patrick Concannon 26 Apr '21

26 Apr '21

Hi, Could someone please review the second half of my update for the `java.time` package to make use of the `instanceof` pattern variable? This PR was split into two parts due to the large number of files affected. Kind regards,  Patrick ------------- Commit messages: - 8265746: Update java.time to use instanceof pattern variable (part II) Changes: https://git.openjdk.java.net/jdk/pull/3650/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3650&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265746 Stats: 152 lines in 20 files changed: 0 ins; 48 del; 104 mod Patch: https://git.openjdk.java.net/jdk/pull/3650.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3650/head:pull/3650 PR: https://git.openjdk.java.net/jdk/pull/3650

6 11

RFR: 8264031: Fix typo in ZipFileSystem.deleteFile ZipException
by Simon Legner 26 Apr '21

26 Apr '21

8264031: Fix typo in ZipFileSystem.deleteFile ZipException ------------- Commit messages: - ZipFileSystem: fix typo in ZipException Changes: https://git.openjdk.java.net/jdk/pull/2588/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2588&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264031 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2588.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2588/head:pull/2588 PR: https://git.openjdk.java.net/jdk/pull/2588

3 5

RFR: 8037397: Lost nested character class after intersection &&
by Ian Graves 25 Apr '21

25 Apr '21

Bug fix with the intersection `&&` operator in regex patterns. In JDK-8037397, some character classes on the right hand side of the operator are dropped in cases where nested `[..]` classes are used with non "nested" ones. ------------- Commit messages: - Fixing a regex intersection bug that drops expressions on the right hand side Changes: https://git.openjdk.java.net/jdk/pull/3291/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3291&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8037397 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/3291.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3291/head:pull/3291 PR: https://git.openjdk.java.net/jdk/pull/3291

4 11

New Collections interface - Sized
by Stephen Colebourne 23 Apr '21

23 Apr '21

Hi all, While a discussion on ReversibleCollection is going on, I'd like to raise the interface I've always found most missing from the framework - Sized public interface Sized { int size(); default boolean isEmpty() { return size() == 0; } default boolean isNotEmpty() { return !isEmpty(); } } This would be applied to Collection and Map, providing a missing unification. Anything else that has a size could also be retrofitted, such as String. Ideally arrays too, but that could come later. Note that Iterable would not implement it. WDYT? Stephen

4 8

RFR: 8264208: Console charset API
by Naoto Sato 23 Apr '21

23 Apr '21

Please review the changes for the subject issue. This has been suggested in a recent discussion thread for the JEP 400 [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.…)] A CSR has also been drafted, and comments are welcome [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)] ------------- Commit messages: - 8264208: Console charset API Changes: https://git.openjdk.java.net/jdk/pull/3419/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3419&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264208 Stats: 202 lines in 9 files changed: 174 ins; 17 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/3419.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3419/head:pull/3419 PR: https://git.openjdk.java.net/jdk/pull/3419

7 43

RFR: 8265793: Remove duplicate jtreg TEST.groups references for some client tests
by Phil Race 22 Apr '21

22 Apr '21

Delete some duplicates ------------- Commit messages: - 8265793: Remove duplicate jtreg TEST.groups references for some client tests Changes: https://git.openjdk.java.net/jdk/pull/3642/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3642&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265793 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3642.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3642/head:pull/3642 PR: https://git.openjdk.java.net/jdk/pull/3642

2 2