May 2021 - core-libs-dev

RFR: 8266579: Update test/jdk/java/lang/ProcessHandle/PermissionTest.java & test/jdk/java/sql/testng/util/TestPolicy.java
by Lance Andersen 06 May '21

06 May '21

Hi all, Please review this patch which updates test/jdk/java/lang/ProcessHandle/PermissionTest.java & test/jdk/java/sql/testng/util/TestPolicy.java to include : `new PropertyPermission("testng.memory.friendly", "read"); ` Which will be needed by TestNG 7.4 Best, Lance ------------- Commit messages: - Add additional permission required by TestNG 7.4 Changes: https://git.openjdk.java.net/jdk/pull/3888/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3888&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266579 Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3888/head:pull/3888 PR: https://git.openjdk.java.net/jdk/pull/3888

4 4

RFR: 8266168: -Wmaybe-uninitialized happens in check_code.c
by Yasumasa Suenaga 06 May '21

06 May '21

We can see following compiler warning in check_code.c on GCC 11. ------------- Commit messages: - 8266168: -Wmaybe-uninitialized happens in check_code.c Changes: https://git.openjdk.java.net/jdk/pull/3787/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3787&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266168 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/3787.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3787/head:pull/3787 PR: https://git.openjdk.java.net/jdk/pull/3787

2 3

Re: RFR: 8265518: C1: Intrinsic support for Preconditions.checkIndex [v8]
by Yi Yang 06 May '21

06 May '21

> The JDK codebase re-created many variants of checkIndex(`grep -I -r 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which annotated with @IntrinsicCandidate and it only has a corresponding C1 intrinsic version. > > In fact, there is an utility method `jdk.internal.util.Preconditions.checkIndex`(wrapped by java.lang.Objects.checkIndex) that behaves the same as these variants of checkIndex, we can replace these re-created variants of checkIndex by Objects.checkIndex, it would significantly reduce duplicated code and enjoys performance improvement because Preconditions.checkIndex is @IntrinsicCandidate and it has a corresponding intrinsic method in HotSpot. > > But, the problem is currently HotSpot only implements the C2 version of Preconditions.checkIndex. To reuse it global-widely in JDK code, I think we can firstly implement its C1 counterpart. There are also a few kinds of stuff we can do later: > > 1. Replace all variants of checkIndex by Objects.checkIndex in the whole JDK codebase. > 2. Remove Buffer.checkIndex and obsolete/deprecate InlineNIOCheckIndex flag > > Testing: cds, compiler and jdk Yi Yang has updated the pull request incrementally with one additional commit since the last revision: build failed ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3615/files - new: https://git.openjdk.java.net/jdk/pull/3615/files/e4959148..f996c99f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3615&range=07 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3615&range=06-07 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/3615.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3615/head:pull/3615 PR: https://git.openjdk.java.net/jdk/pull/3615

1 0

Re: RFR: 8265518: C1: Intrinsic support for Preconditions.checkIndex [v7]
by Yi Yang 06 May '21

06 May '21

> The JDK codebase re-created many variants of checkIndex(`grep -I -r 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which annotated with @IntrinsicCandidate and it only has a corresponding C1 intrinsic version. > > In fact, there is an utility method `jdk.internal.util.Preconditions.checkIndex`(wrapped by java.lang.Objects.checkIndex) that behaves the same as these variants of checkIndex, we can replace these re-created variants of checkIndex by Objects.checkIndex, it would significantly reduce duplicated code and enjoys performance improvement because Preconditions.checkIndex is @IntrinsicCandidate and it has a corresponding intrinsic method in HotSpot. > > But, the problem is currently HotSpot only implements the C2 version of Preconditions.checkIndex. To reuse it global-widely in JDK code, I think we can firstly implement its C1 counterpart. There are also a few kinds of stuff we can do later: > > 1. Replace all variants of checkIndex by Objects.checkIndex in the whole JDK codebase. > 2. Remove Buffer.checkIndex and obsolete/deprecate InlineNIOCheckIndex flag > > Testing: cds, compiler and jdk Yi Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - cmp clobbers its left argument on x86_32 - Merge branch 'master' into consolidate_checkindex - better check1-4 - AssertionError when expected exception was not thrown - remove extra newline - remove InlineNIOCheckIndex flag - remove java_nio_Buffer in javaClasses.hpp - consolidate ------------- Changes: https://git.openjdk.java.net/jdk/pull/3615/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3615&range=06 Stats: 331 lines in 11 files changed: 235 ins; 78 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/3615.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3615/head:pull/3615 PR: https://git.openjdk.java.net/jdk/pull/3615

1 0

[11u] RFR 8266352: Add parallel heap iteration for jmap –histo
by buddyliao(廖彬) 06 May '21

06 May '21

Dear all, Would you help me to review the following backport from jdk-master? Original bug: https://bugs.openjdk.java.net/browse/JDK-8215624 http://hg.openjdk.java.net/jdk/jdk/rev/b1afb7c82d59 Original CSR: https://bugs.openjdk.java.net/browse/JDK-8266353 Original patch does not apply cleanly to 11u, because jmap command parameter is different between each other, and the code structure has little changed. Notably, I had to change the src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java<http://hg.openjdk.java.net/jdk/jdk/file/b1afb7c82d59/src/jdk.jcmd/share/cla…> to make it matches 11u-dev 11u webrev: https://cr.openjdk.java.net/~lzang/BuddyLiao/8266352/webrev01/ Testing: x86_64 build, affected tests, tier1 Thanks, -Buddy

2 1

[11u] RFR 8266354: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id
by buddyliao(廖彬) 06 May '21

06 May '21

Dear all, Would you help me to review the following backport from jdk-master? This backport is bugfix for the prefer backport https://bugs.openjdk.java.net/browse/JDK-8266352 Original bug: https://bugs.openjdk.java.net/browse/JDK-8251570<https://bugs.openjdk.java.net/browse/JDK-8215624> https://hg.openjdk.java.net/jdk/jdk/rev/dd827a012e43 Original patch does not apply cleanly to 11u, since the code structure has changed. Notably, I had to make it fit with 11u-dev. 11u webrev: https://cr.openjdk.java.net/~lzang/BuddyLiao/8266354/webrev01/ Testing: x86_64 build, affected tests, tier1 Thanks, -Buddy

1 0

Re: RFR: 8244146: javac changes for JEP 306
by Srikanth Adayapalam 05 May '21

05 May '21

On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy <darcy(a)openjdk.org> wrote: > 8244146: javac changes for JEP 306 src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line 1704: > 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source)) > 1703: result = result & ~STRICTFP; > 1704: Nitpick: Doing in Rome as ... would mean this is better written as result &= ~STRICTFP; to be in harmony with the code in the vicinity Also I am OK with the feature-allowed-in-source-check, but wonder if it is an overkill for smaller focussed changes like this one. I will say I don't know what is the standard operating procedure. See that elsewhere in Lint.java you are doing if (source.compareTo(Source.JDK17) >= 0) { values.add(LintCategory.STRICTFP); } ------------- PR: https://git.openjdk.java.net/jdk/pull/3831

4 3

Re: RFR: 8244146: javac changes for JEP 306
by Srikanth Adayapalam 05 May '21

05 May '21

On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy <darcy(a)openjdk.org> wrote: > 8244146: javac changes for JEP 306 src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties line 1769: > 1767: compiler.warn.strictfp=\ > 1768: as of release 17, all floating-point expressions are evaluated strictly and ''strictfp'' is not required > 1769: Nitpick: Three other uses of floating point in the same file use the non-hyphenated form. ------------- PR: https://git.openjdk.java.net/jdk/pull/3831

2 2

Re: RFR: 8244146: javac changes for JEP 306 [v2]
by Joe Darcy 05 May '21

05 May '21

> 8244146: javac changes for JEP 306 Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3831/files - new: https://git.openjdk.java.net/jdk/pull/3831/files/a0a68baa..ec4d163a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3831&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3831&range=00-01 Stats: 19 lines in 9 files changed: 10 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jdk/pull/3831.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3831/head:pull/3831 PR: https://git.openjdk.java.net/jdk/pull/3831

3 3

Re: RFR: 8244146: javac changes for JEP 306 [v3]
by Joe Darcy 05 May '21

05 May '21

> 8244146: javac changes for JEP 306 Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3831/files - new: https://git.openjdk.java.net/jdk/pull/3831/files/ec4d163a..9773a8a5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3831&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3831&range=01-02 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/3831.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3831/head:pull/3831 PR: https://git.openjdk.java.net/jdk/pull/3831

1 0