May 2021 - core-libs-dev

RFR: JDK-8266527 RandomTestCoverage.java failing due to API removal
by Jim Laskey 04 May '21

04 May '21

RandomTestCoverage.java was overlooked when doing local test. Apologies. ------------- Commit messages: - Adjust testing for API removal Changes: https://git.openjdk.java.net/jdk/pull/3867/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3867&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266527 Stats: 15 lines in 1 file changed: 5 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jdk/pull/3867.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3867/head:pull/3867 PR: https://git.openjdk.java.net/jdk/pull/3867

2 2

RFR: JDK-8266227: Fix help text for --mac-signing-keychain
by Andy Herrick 04 May '21

04 May '21

JDK-8266227: Fix help text for --mac-signing-keychain ------------- Commit messages: - JDK-8266227: Fix help text for --mac-signing-keychain Changes: https://git.openjdk.java.net/jdk/pull/3819/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3819&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266227 Stats: 89 lines in 3 files changed: 27 ins; 5 del; 57 mod Patch: https://git.openjdk.java.net/jdk/pull/3819.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3819/head:pull/3819 PR: https://git.openjdk.java.net/jdk/pull/3819

3 5

Fast and cheap (Double|Float)::toString Java algorithm
by Raffaello Giulietti 04 May '21

04 May '21

Hello, as a reminder, a Java implementation of Schubfach [1] intended to replace the current slow and expensive OpenJDK (Double|Float)::toString algorithm has been discussed, presented and contributed to this mailing list in several posts. The last implementation is available in pre-Skara webrev form, as referenced in [2]. On my laptop hardware, the speedup factor is 17.7x wrt OpenJDK. Recently, Alexander Bolz translated Schubfach to C++ for the purpose of comparing the performance of several bin2dec floating-point numbers algorithms [3]. In the meantime, Junekey Jeon implemented and perfected his own Dragonbox in C++, a new algorithm based on Schubfach [4]. From [5]: "In addition to the core idea of Schubfach, Dragonbox utilizes some Grisu-like ideas to minimize the number of expensive 128-bit × 64-bit multiplications, at the cost of having more branches and divisions-by-constants." In the C++ ecosystem, Schubfach has been the fastest known algorithm before being gently pushed aside by Dragonbox, as can be seen in the graphs in [3]. While developing Schubfach back in 2018, I experimented myself with blending core Schubfach with my own earlier algorithm similar to Grisu. However, probably due to uncontrollable JIT compilation behavior, I could not observe any benefit. On the contrary, I measured performance drops probably because of the added complexity, which is public enemy nr. 1 for JIT compilers. Therefore, I opted for the simpler current design that seemed more suitable for (the then 2018 version of) C2. I hope this can somehow revive this community's interest and confidence toward Schubfach to definitely supplant the current expensive (Double|Float)::toString algorithm. Greetings Raffaello ---- [1] https://drive.google.com/open?id=1luHhyQF9zKlM8yJ1nebU0OgVYhfC6CBN [2] https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-March/065297.html [3] https://github.com/abolz/Drachennest [4] https://github.com/jk-jeon/dragonbox [5] https://github.com/jk-jeon/dragonbox/blob/master/other_files/Dragonbox.pdf

2 3

RFR: 8265989: System property for the native character encoding name
by Naoto Sato 04 May '21

04 May '21

After some internal discussion, we thought it was good to expose the native environment's default character encoding, which Charset.defaultCharset() is currently based on. This way applications will have a better migration path after the [JEP 400](https://openjdk.java.net/jeps/400) is implemented, in which Charset.defaultCharset() will return UTF-8, but the value of this new system property will remain intact. A [CSR](https://bugs.openjdk.java.net/browse/JDK-8266075) has been filed with more detailed information. ------------- Commit messages: - 8265989: System property for the native character encoding name Changes: https://git.openjdk.java.net/jdk/pull/3777/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3777&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265989 Stats: 15 lines in 3 files changed: 8 ins; 3 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/3777.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3777/head:pull/3777 PR: https://git.openjdk.java.net/jdk/pull/3777

6 22

RFR: 8265279: Remove unused RandomGeneratorFactory.all(Class<T> category)
by Jim Laskey 04 May '21

04 May '21

No longer needed ------------- Commit messages: - RandomGeneratorFactory.all(Class<T> category) no longer needed - Remove extraneous references to makeXXXSpliterator - Move makeXXXSpliterator methods to RandomSupport - change static final from 'proxy' to 'PROXY' - Make makeXXXSpliterator final - Move makeXXXSpilterator from public (@hidden) to protected. No API change. Changes: https://git.openjdk.java.net/jdk/pull/3516/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3516&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265279 Stats: 229 lines in 5 files changed: 19 ins; 184 del; 26 mod Patch: https://git.openjdk.java.net/jdk/pull/3516.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3516/head:pull/3516 PR: https://git.openjdk.java.net/jdk/pull/3516

2 3

RFR: 8265137: java.util.Random suddenly has new public methods nowhere documented
by Jim Laskey 04 May '21

04 May '21

Move makeXXXSpilterator from public (@hidden) to protected. No API ch ------------- Commit messages: - Move makeXXXSpilterator from public (@hidden) to protected. No API change. Changes: https://git.openjdk.java.net/jdk/pull/3469/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3469&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265137 Stats: 107 lines in 4 files changed: 0 ins; 91 del; 16 mod Patch: https://git.openjdk.java.net/jdk/pull/3469.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3469/head:pull/3469 PR: https://git.openjdk.java.net/jdk/pull/3469

5 23

RFR: JDK-8266391: Replace use of reflection in jdk.internal.platform.Metrics
by Mandy Chung 03 May '21

03 May '21

Replace the use of reflection with a direct method call to a platform-specific implementation class where `SystemMetrics::instance` returns `CgroupMetrics.getInstance()` on linux and returns null on other platforms. ------------- Commit messages: - fix whitespace - JDK-8266391: Replace use of reflection in jdk.internal.platform.Metrics Changes: https://git.openjdk.java.net/jdk/pull/3828/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3828&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266391 Stats: 103 lines in 4 files changed: 93 ins; 8 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/3828.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3828/head:pull/3828 PR: https://git.openjdk.java.net/jdk/pull/3828

2 2

RFR: JDK-8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with fastdebug
by Andy Herrick 01 May '21

01 May '21

JDK-8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with fastdebug just disabling this test when vm.debug ------------- Commit messages: - JDK-8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with fastdebug Changes: https://git.openjdk.java.net/jdk/pull/3827/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3827&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266129 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3827.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3827/head:pull/3827 PR: https://git.openjdk.java.net/jdk/pull/3827

3 3

RFR: 8266193: BasicJMapTest should include testHistoParallel methods
by BuddyLiao 01 May '21

01 May '21

The testHistoParallel* method are not included in the BasicJMapTest's main() method. They should be included. ------------- Commit messages: - 8266193: BasicJMapTest should include testHistoParallel methods Changes: https://git.openjdk.java.net/jdk/pull/3810/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3810&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266193 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3810.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3810/head:pull/3810 PR: https://git.openjdk.java.net/jdk/pull/3810

1 0

RFR: 8265356: need code example for getting canonical constructor of a Record
by Tagir F.Valeev 01 May '21

01 May '21

I decided to show a complete static method in the example, so it could be copied to user utility class as is. Not sure if it's reasonable to add `assert cls.isRecord();` there. Also I don't know whether there's a limitation on max characters in the sample code. Probable a line break in `static <T extends Record>\nConstructor<T> getCanonicalConstructor(Class<T> cls)` is unnecessary. --- Aside from this PR, I've found a couple of things to clean up in `java.lang.Class`: 1. There's erroneous JavaDoc link in `getSimpleName()` JavaDoc (introduced by @jddarcy in #3038). It should be `#isArray()` instead of `isArray()`. 2. Methods Atomic::casAnnotationType and Atomic::casAnnotationData have unused type parameters `<T>`. 3. Probably too much but AnnotationData can be nicely converted to a record! Not sure, probably nobody wants to have `java.lang.Record` initialized too early or increasing the footprint of such a basic class in the metaspace, so I don't insist on this. private record AnnotationData( Map<Class<? extends Annotation>, Annotation> annotations, Map<Class<? extends Annotation>, Annotation> declaredAnnotations, // Value of classRedefinedCount when we created this AnnotationData instance int redefinedCount) { } Please tell me if it's ok to fix 1 and 2 along with this PR. ------------- Commit messages: - 8265356: need code example for getting canonical constructor of a Record Changes: https://git.openjdk.java.net/jdk/pull/3556/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3556&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265356 Stats: 13 lines in 1 file changed: 13 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3556.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3556/head:pull/3556 PR: https://git.openjdk.java.net/jdk/pull/3556

2 7