May 2021 - core-libs-dev

RFR: 8267521: Post JEP 411 refactoring: maximum covering > 50K
by Weijun Wang 02 Jun '21

02 Jun '21

The code change refactors classes that have a `SuppressWarnings("removal")` annotation that covers more than 50KB of code. The big annotation is often quite faraway from the actual deprecated API usage it is suppressing, and with the annotation covering too big a portion it's easy to call other deprecated methods without being noticed. ------------- Depends on: https://git.openjdk.java.net/jdk/pull/4073 Commit messages: - 8267521: Post JEP 411 refactoring: maximum covering > 50K Changes: https://git.openjdk.java.net/jdk/pull/4138/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4138&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267521 Stats: 226 lines in 18 files changed: 142 ins; 29 del; 55 mod Patch: https://git.openjdk.java.net/jdk/pull/4138.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4138/head:pull/4138 PR: https://git.openjdk.java.net/jdk/pull/4138

4 15

RFR: 8265130: Make ConstantDesc class hierarchy sealed
by Gavin Bierman 02 Jun '21

02 Jun '21

Hi all, Please review this patch to make the ConstantDesc hierarchy `sealed`, as was promised in its Javadoc, now that sealed classes are finalising in JDK 17. Thanks, Gavin ------------- Commit messages: - 8265130: Make ConstantDesc class hierarchy sealed Changes: https://git.openjdk.java.net/jdk/pull/4135/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4135&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265130 Stats: 25 lines in 6 files changed: 16 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/4135.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4135/head:pull/4135 PR: https://git.openjdk.java.net/jdk/pull/4135

7 15

RFR: 8263561: Re-examine uses of LinkedList
by Сергей Цыпанов 02 Jun '21

02 Jun '21

The usage of `LinkedList` is senseless and can be replaced with either `ArrayList` or `ArrayDeque` which are both more compact and effective. jdk:tier1 and jdk:tier2 are both ok ------------- Commit messages: - Remove remaining usages of LinkedList in java.base Changes: https://git.openjdk.java.net/jdk/pull/2744/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2744&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263561 Stats: 40 lines in 9 files changed: 0 ins; 2 del; 38 mod Patch: https://git.openjdk.java.net/jdk/pull/2744.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2744/head:pull/2744 PR: https://git.openjdk.java.net/jdk/pull/2744

7 27

RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal
by Weijun Wang 02 Jun '21

02 Jun '21

Please review this implementation of [JEP 411](https://openjdk.java.net/jeps/411). The code change is divided into 3 commits. Please review them one by one. 1. https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be794… The essential change for this JEP, including the `@Deprecate` annotations and spec change. It also update the default value of the `java.security.manager` system property to "disallow", and necessary test change following this update. 2. https://github.com/openjdk/jdk/commit/26a54a835e9f84aa528740a7c5c35d07355a8… Manual changes to several files so that the next commit can be generated programatically. 3. https://github.com/openjdk/jdk/commit/eb6c566ff9207974a03a53335e0e697cffcf0… Automatic changes to other source files to avoid javac warnings on deprecation for removal The 1st and 2nd commits should be reviewed carefully. The 3rd one is generated programmatically, see the comment below for more details. If you are only interested in a portion of the 3rd commit and would like to review it as a separate file, please comment here and I'll generate an individual webrev. Due to the size of this PR, no attempt is made to update copyright years for any file to minimize unnecessary merge conflict. Furthermore, since the default value of `java.security.manager` system property is now "disallow", most of the tests calling `System.setSecurityManager()` need to launched with `-Djava.security.manager=allow`. This is covered in a different PR at https://github.com/openjdk/jdk/pull/4071. ------------- Commit messages: - add supresswarnings annotations automatically - manual change before automatic annotating - 8266459: Implement JEP 411: Deprecate the Security Manager for Removal Changes: https://git.openjdk.java.net/jdk/pull/4073/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4073&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266459 Stats: 2018 lines in 826 files changed: 1884 ins; 9 del; 125 mod Patch: https://git.openjdk.java.net/jdk/pull/4073.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4073/head:pull/4073 PR: https://git.openjdk.java.net/jdk/pull/4073

13 55

RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator)
by Maurizio Cimadamore 02 Jun '21

02 Jun '21

This PR contains the API and implementation changes for JEP-412 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. [1] - https://openjdk.java.net/jeps/412 ------------- Commit messages: - Add linker test excludes for x86 and other platforms which do not support `CLinker` - Integrate latest API tweaks - Fix x86 build - Fix `TestLinkToNativeRBP` - Initial push Changes: https://git.openjdk.java.net/jdk/pull/3699/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3699&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264774 Stats: 14083 lines in 213 files changed: 8502 ins; 3605 del; 1976 mod Patch: https://git.openjdk.java.net/jdk/pull/3699.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3699/head:pull/3699 PR: https://git.openjdk.java.net/jdk/pull/3699

8 81

RFR: 8266559: XPathEvaluationResult.XPathResultType.NODESET maps to incorrect type
by Joe Wang 02 Jun '21

02 Jun '21

Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping. Clarifies the supported types for the evaluateExpression methods. Other changes were javadoc tag usages, e.g. s/the code tag/{@code ------------- Commit messages: - 8266559: XPathEvaluationResult.XPathResultType.NODESET maps to incorrect type Changes: https://git.openjdk.java.net/jdk/pull/4258/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4258&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266559 Stats: 77 lines in 4 files changed: 28 ins; 0 del; 49 mod Patch: https://git.openjdk.java.net/jdk/pull/4258.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4258/head:pull/4258 PR: https://git.openjdk.java.net/jdk/pull/4258

3 5

RFR: JDK-8267936: PreserveAllAnnotations option doesn't expose the annotation to Java code
by Jaroslav Tulach 01 Jun '21

01 Jun '21

This PR exposes runtime invisible annotations via `Class.getAnnotation` when `-XX:+PreserveAllAnnotations` option is passed to the JVM. Existing `-XX:+PreserveAllAnnotations` option can be very useful for code that needs to access annotations with `RetentionPolicy.CLASS` without the need to parse the .class files manually. While the RuntimeInvisibleAnnotations are kept in the runtime, they are not visible via java.lang.reflect API. I assume that's just an omission. This PR provides a test and a single line fix that makes `-XX:+PreserveAllAnnotations` useful in cooperation with `Class.getAnnotation(...)`. ------------- Commit messages: - Expose runtime invisible annotations via Class.getAnnotation when -XX:+PreserveAllAnnotations is on Changes: https://git.openjdk.java.net/jdk/pull/4245/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4245&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267936 Stats: 65 lines in 2 files changed: 61 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/4245.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4245/head:pull/4245 PR: https://git.openjdk.java.net/jdk/pull/4245

7 25

java.util.List missing from "Collections Framework Overview" javadoc
by Raffaello Giulietti 01 Jun '21

01 Jun '21

Hello, seems like java.util.List is missing from the list in the "Collection Interfaces" section in https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/doc-… Should be easy to fix and doesn't seem to require a CSR as the document is non-normative. Greetings Raffaello

2 2

RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions
by Patrick Concannon 01 Jun '21

01 Jun '21

Hi, Could someone please review my code for updating the code in the `java.io`, `java.math`, and `java.text` packages to make use of the switch expressions? Kind regards, Patrick ------------- Commit messages: - 8267670: Update java.io, java.math, and java.text to use switch expressions Changes: https://git.openjdk.java.net/jdk/pull/4182/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4182&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267670 Stats: 328 lines in 11 files changed: 1 ins; 187 del; 140 mod Patch: https://git.openjdk.java.net/jdk/pull/4182.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4182/head:pull/4182 PR: https://git.openjdk.java.net/jdk/pull/4182

9 31

RFR: 8267921: Remove redundant loop from sun.reflect.misc.ReflectUtil.privateCheckPackageAccess()
by Сергей Цыпанов 31 May '21

31 May '21

This a tiny follop-up of https://github.com/openjdk/jdk/pull/3571. The loop in `sun.reflect.misc.ReflectUtil.privateCheckPackageAccess()` is redundant since `Class.getPackageName()` will already return the package name of the innermost component type. ------------- Commit messages: - 8267921: Remove redundant loop from sun.reflect.misc.ReflectUtil.privateCheckPackageAccess() Changes: https://git.openjdk.java.net/jdk/pull/4268/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4268&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267921 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4268.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4268/head:pull/4268 PR: https://git.openjdk.java.net/jdk/pull/4268

3 3