July 2021 - core-libs-dev

RFR: 8171382: java.time.Duration missing isPositive method
by Naoto Sato 26 Jul '21

26 Jul '21

Please review this PR to introduce `java.time.Duration.isPositive()` method. A CSR is also drafted. ------------- Commit messages: - 8171382: java.time.Duration missing isPositive method Changes: https://git.openjdk.java.net/jdk/pull/4892/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4892&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8171382 Stats: 31 lines in 2 files changed: 30 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/4892.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4892/head:pull/4892 PR: https://git.openjdk.java.net/jdk/pull/4892

6 8

RFR: 8265474: Dubious 'null' assignment in CompactByteArray.expand
by Andrey Turbanov 26 Jul '21

26 Jul '21

I propose to remove 'null' assignment of field CompactByteArray.values in `expand` method. In the next statement this field is overridden with another value - `tempArray`. This code was there from initial load of OpenJDK sources. I believe it was just leftovers from development phase of this class. There is no practical reason to assign `null` to non-volatile field and then overwrite it with another value. Also I've removed unused method `getArray`. I hope it's ok to cleanup such unused stuff in the same PR. ------------- Commit messages: - 8265474: Dubious 'null' assignment in CompactByteArray.expand - [PATCH] Remove dubious 'null' assignment to CompactByteArray.values Changes: https://git.openjdk.java.net/jdk/pull/1880/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1880&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265474 Stats: 9 lines in 1 file changed: 0 ins; 6 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/1880.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1880/head:pull/1880 PR: https://git.openjdk.java.net/jdk/pull/1880

3 4

RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes
by Ian Graves 23 Jul '21

23 Jul '21

8199594: Add doc describing how (?x) ignores spaces in character classes ------------- Commit messages: - Updating documentation on comments mode and character class whitespace Changes: https://git.openjdk.java.net/jdk/pull/4618/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4618&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8199594 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/4618.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4618/head:pull/4618 PR: https://git.openjdk.java.net/jdk/pull/4618

7 13

RFR: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
by Jaikiran Pai 23 Jul '21

23 Jul '21

Can I please get a review of this proposed fix for https://bugs.openjdk.java.net/browse/JDK-8251329? As noted in that issue, if a zip filesystem created on top of a jar containing a "./" entry is "walked" using the `Files.walkFileTree`, it leads to a infinite never ending iteration (which ultimately fails with Java heap space OOM). Alan notes in that issue that: > This is more likely an issue with the zipfs DirectoryStream implementation. A DirectoryStream is specified to not include elements that for the special links to the current or parent directory. It should be rare. This indeed turned out to be an issue in the `jdk.nio.zipfs.ZipDirectoryStream#iterator()` implementation where it calls the `jdk.nio.zipfs.ZipFileSystem#iteratorOf(...)` implementation. The implementation, unlike what the javadoc of `java.nio.file.DirectoryStream` states, was including the "." and ".." paths in its returned iterator: > The elements returned by the iterator are in no specific order. Some file systems maintain special links to the directory itself and the directory's parent directory. Entries representing these links are not returned by the iterator. The proposed fix in this patch checks the paths for "." and "..", similar to what the `sun.nio.fs.UnixDirectoryStream` does in its `isSelfOrParent` and skips those paths from being added into the returned iterator. The `jdk.nio.zipfs.ZipFileSystem#iteratorOf(...)` (where this change has been done) is currently only used by `jdk.nio.zipfs.ZipDirectoryStream#iterator()` and has package-private visibility, so this change shouldn't impact any other usage/expectations. A new jtreg test has been added to reproduce this issue and verify the fix. Local testing of the `test/jdk/jdk/nio/` (including this new test) went fine without any issues after this change. I will be triggering a `tier1` test locally in a while. ------------- Commit messages: - 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside Changes: https://git.openjdk.java.net/jdk/pull/4604/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4604&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251329 Stats: 173 lines in 3 files changed: 170 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/4604.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4604/head:pull/4604 PR: https://git.openjdk.java.net/jdk/pull/4604

6 19

[jdk17] RFR: 8271155: Wrong path separator in env variable
by Alexey Semenyuk 23 Jul '21

23 Jul '21

Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher. ------------- Commit messages: - 8271155: Wrong path separator in env variable Changes: https://git.openjdk.java.net/jdk17/pull/271/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=271&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271155 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17/pull/271.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/271/head:pull/271 PR: https://git.openjdk.java.net/jdk17/pull/271

6 8

RFR: 8247373: ArraysSupport.newLength doc, test, and exception message
by Stuart Marks 23 Jul '21

23 Jul '21

This rewrites the doc of ArraysSupport.newLength, adds detail to the exception message, and adds a test. In addition to some renaming and a bit of refactoring of the actual code, I also made two changes of substance to the code: 1. I fixed a problem with overflow checking. In the original code, if oldLength and prefGrowth were both very large (say, Integer.MAX_VALUE), this method could return a negative value. It turns out that writing tests helps find bugs! 2. Under the old policy, if oldLength and minGrowth required a length above SOFT_MAX_ARRAY_LENGTH but not above Integer.MAX_VALUE, this method would return Integer.MAX_VALUE. That doesn't make any sense, because attempting to allocate an array of that length will almost certainly cause the Hotspot to throw OOME because its implementation limit was exceeded. Instead, if the required length is in this range, this method returns that required length. Separately, I'll work on retrofitting various call sites around the JDK to use this method. ------------- Commit messages: - 8247373: ArraysSupport.newLength doc, test, and exception message Changes: https://git.openjdk.java.net/jdk/pull/1617/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1617&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247373 Stats: 171 lines in 4 files changed: 137 ins; 3 del; 31 mod Patch: https://git.openjdk.java.net/jdk/pull/1617.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1617/head:pull/1617 PR: https://git.openjdk.java.net/jdk/pull/1617

7 31

RFR: 8271147: java/nio/file/Path.java javadoc typo
by Jaikiran Pai 23 Jul '21

23 Jul '21

Can I please get a review for this change which fixes the typo noted in https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked fine and the generated javadoc looks fine. ------------- Commit messages: - 8271147: java/nio/file/Path.java javadoc typo Changes: https://git.openjdk.java.net/jdk/pull/4884/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4884&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271147 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/4884.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4884/head:pull/4884 PR: https://git.openjdk.java.net/jdk/pull/4884

2 3

RFR: Merge jdk17
by Jesper Wilhelmsson 23 Jul '21

23 Jul '21

Forwardport JDK 17 -> JDK 18 ------------- Commit messages: - Merge - 8271162: runtime/StackTrace/LargeClassTest.java can be run in driver mode - 8271158: runtime/handshake/HandshakeTimeoutTest.java test doesn't check exit code - 8271169: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java can be run in driver mode - 8271160: runtime/jni/checked/TestCheckedJniExceptionCheck.java doesn't set -Djava.library.path - 8271155: Wrong path separator in env variable - 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1 - 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code - 8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test - 8270085: Suspend during block transition may deadlock if lock held - ... and 2 more: https://git.openjdk.java.net/jdk/compare/a7d30123...b6b24fa0 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4883&range=00.0 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4883&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/4883/files Stats: 268 lines in 20 files changed: 178 ins; 43 del; 47 mod Patch: https://git.openjdk.java.net/jdk/pull/4883.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4883/head:pull/4883 PR: https://git.openjdk.java.net/jdk/pull/4883

1 1

jpackage - override postinstall script (Mac OS PKG)
by Bruno Borges 23 Jul '21

23 Jul '21

Is it possible to replace the postinstall (pre too, if needed) script created by jpackage for the PKG installer on Mac OS ?

1 0

RFR: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values
by Brian Burkhalter 22 Jul '21

22 Jul '21

Please consider this proposal to add some test coverage comparing `Math` and `StrictMath` results of `pow()`. ------------- Commit messages: - 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values Changes: https://git.openjdk.java.net/jdk/pull/4758/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4758&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8211002 Stats: 18 lines in 1 file changed: 17 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/4758.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4758/head:pull/4758 PR: https://git.openjdk.java.net/jdk/pull/4758

2 7