July 2021 - core-libs-dev

[jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC
by Jorn Vernee 17 Jul '21

17 Jul '21

This patch rewrites the prologue and epilogue of panama upcalls, in order to fix the test failure from the title. Previously, we did a call to potentially attach the current thread to the VM, and then afterwards did the same suspend and stack reguard checks that we do on the back-edge of a native downcall. Then, on the back edge of the upcall we did another conditional call to detach the thread. I've changed these 2 calls to mimic what is done by JavaCallWrapper instead (with attach and detach included), and removed the old suspend and stack reguard checks (now handled by the call). FWIW, this removes the JavaFrameAnchor save/restore MacroAssembler code. This is now written in C++. Also, MacroAssembler code was added to save/restore the result of the upcall around the call on the back-edge, which was previously missing. Since the new code allocates a handle block as well, I've added handling for those oops to frame & OptimizedUpcallBlob. Testing: local running of `jdk_foreign` on Windows and Linux (WSL). Tier 1-3 ------------- Commit messages: - Remove whitespace - Add Shenandoah test case as well - Add zgc requires tags - Typo in MACOS_AARCH64_ONLY part - Polish - Some more build fixes - build fixes - re-write upcall code to mimic JavaCallWrapper Changes: https://git.openjdk.java.net/jdk17/pull/149/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=149&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269240 Stats: 516 lines in 18 files changed: 338 ins; 147 del; 31 mod Patch: https://git.openjdk.java.net/jdk17/pull/149.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/149/head:pull/149 PR: https://git.openjdk.java.net/jdk17/pull/149

5 25

RFR: 8270547: java.util.Random contains unnecessary @SuppressWarnings("exports")
by Jan Lahoda 16 Jul '21

16 Jul '21

Removing unnecessary `@SuppressWarnings("exports")`. The reason for the suppress warnings was, as far as I can tell, removed by https://bugs.openjdk.java.net/browse/JDK-8265137. ------------- Commit messages: - 8270547: java.util.Random contains unnecessary @SuppressWarnings("exports") Changes: https://git.openjdk.java.net/jdk/pull/4793/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4793&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270547 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4793.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4793/head:pull/4793 PR: https://git.openjdk.java.net/jdk/pull/4793

3 3

RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers
by Andy Herrick 15 Jul '21

15 Jul '21

JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers ------------- Commit messages: - JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers - JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers - JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers - JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers Changes: https://git.openjdk.java.net/jdk/pull/4730/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4730&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269387 Stats: 298 lines in 11 files changed: 240 ins; 5 del; 53 mod Patch: https://git.openjdk.java.net/jdk/pull/4730.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4730/head:pull/4730 PR: https://git.openjdk.java.net/jdk/pull/4730

4 13

RFR: Merge jdk17
by Jesper Wilhelmsson 14 Jul '21

14 Jul '21

Forwardport JDK 17 -> JDK 18 ------------- Commit messages: - Merge - 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848 - 8266313: (JEP-356) - RandomGenerator spec implementation requirements tightly coupled to JDK internal classes - 8270075: SplittableRandom extends AbstractSplittableGenerator - 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run - 8259499: Handling type arguments from outer classes for inner class in javadoc - 8268620: InfiniteLoopException test may fail on x86 platforms - 8269865: Async UL needs to handle ERANGE on exceeding SEM_VALUE_MAX - 8270056: Generated lambda class can not access protected static method of target class The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4786&range=00.0 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4786&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/4786/files Stats: 328 lines in 19 files changed: 240 ins; 14 del; 74 mod Patch: https://git.openjdk.java.net/jdk/pull/4786.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4786/head:pull/4786 PR: https://git.openjdk.java.net/jdk/pull/4786

1 1

RFR: 8266936: Add a finalization JFR event
by Brent Christian 14 Jul '21

14 Jul '21

Please review this enhancement to add a new JFR event, generated whenever a finalizer is run. (The makeup is similar to the Deserialization event, [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).) The event's only datum (beyond those common to all jfr events) is the class of the object that was finalized. The Category for the event: `"Java Virtual Machine" / "GC" / "Finalization"` is what made sense to me, even though the event is generated from library code. Along with the new regtest, I added a run mode to the basic finalizer test to enable jfr. Automated testing looks good so far. Thanks, -Brent ------------- Commit messages: - Fix jcheck some more - Fix jcheck - Merge branch 'master' into 8266936 - Add jfr mode to test/jdk/java/lang/ref/FinalizeOverride.java - Fix spacing in new regtest - Remove extraneous comments from new regtest - Removed unintentional changes from FinalizeOverride.java - Actually check in new regtest - Update TestActiveSettingEvent.java - Update TestDefaultConfigurations.java and .jfc files - ... and 2 more: https://git.openjdk.java.net/jdk/compare/e6705c0e...200268ab Changes: https://git.openjdk.java.net/jdk/pull/4101/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4101&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266936 Stats: 191 lines in 11 files changed: 190 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/4101.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4101/head:pull/4101 PR: https://git.openjdk.java.net/jdk/pull/4101

7 12

[jdk17] RFR: JDK-8266313 (JEP-356) - RandomGenerator spec implementation requirements tightly coupled to JDK internal classes
by Jim Laskey 14 Jul '21

14 Jul '21

The wording of the @implSpec referred to internal methods in the description. The patch rewords the @implSpec to be more descriptive of the algorithm than the methods used. ------------- Commit messages: - non-infinite to finite - Use limiting - Remove use of clamping - Merge branch 'master' of https://github.com/openjdk/jdk17 into 8266313 - Javadoc changes Changes: https://git.openjdk.java.net/jdk17/pull/151/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=151&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266313 Stats: 51 lines in 2 files changed: 22 ins; 4 del; 25 mod Patch: https://git.openjdk.java.net/jdk17/pull/151.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/151/head:pull/151 PR: https://git.openjdk.java.net/jdk17/pull/151

2 9

[jdk17] RFR: JDK-8270075 SplittableRandom extends AbstractSplittableGenerator
by Jim Laskey 14 Jul '21

14 Jul '21

Random.AbstractSplittableGenerator is an internal class that should not be exposed in a public API. ------------- Commit messages: - Remove public exposure of AbstractSplittableGenerator Changes: https://git.openjdk.java.net/jdk17/pull/243/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=243&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270075 Stats: 48 lines in 1 file changed: 29 ins; 1 del; 18 mod Patch: https://git.openjdk.java.net/jdk17/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/243/head:pull/243 PR: https://git.openjdk.java.net/jdk17/pull/243

3 4

RFR: Merge jdk17
by Jesper Wilhelmsson 14 Jul '21

14 Jul '21

Forwardport JDK 17 -> JDK 18 ------------- Commit messages: - Merge - 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE - 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas - 8269281: java/foreign/Test{Down,Up}call.java time out - 8269635: Stress test SEGV while emitting OldObjectSample - 8269525: Deadlock during Volano with JFR - 8259848: Interim javadoc build does not support platform links - 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV - 8270203: Missing build dependency between jdk.jfr-gendata and buildtools-hotspot The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4771&range=00.0 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4771&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/4771/files Stats: 388 lines in 13 files changed: 322 ins; 18 del; 48 mod Patch: https://git.openjdk.java.net/jdk/pull/4771.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4771/head:pull/4771 PR: https://git.openjdk.java.net/jdk/pull/4771

1 1

[jdk17] RFR: 8270056: Generated lambda class can not access protected static method of target class
by Yi Yang 14 Jul '21

14 Jul '21

Hi all, this pull request contains a backport of commit 07e90524 from the openjdk/jdk repository. The commit being backported was authored by Yi Yang on 13 Jul 2021 and was reviewed by Mandy Chung. Thanks! ------------- Commit messages: - Backport 07e90524576f159fc16523430f1db62327c89a3b Changes: https://git.openjdk.java.net/jdk17/pull/245/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=245&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270056 Stats: 324 lines in 3 files changed: 181 ins; 141 del; 2 mod Patch: https://git.openjdk.java.net/jdk17/pull/245.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/245/head:pull/245 PR: https://git.openjdk.java.net/jdk17/pull/245

2 2

SplittableGenerator of JEP 356
by Michael Bien 14 Jul '21

14 Jul '21

Hello, i was wondering if SplittableGenerator.split(SplittableGenerator source) is missing out on a potential usecase when the source itself is not splittable. The implementation looks like it only requires basic calls which could be also provided by the RandomGenerator interface as source. best regards, michael

2 3