August 2021 - core-libs-dev

RFR: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
by Naoto Sato 26 Aug '21

26 Aug '21

Please review the fix to the subject issue. When instant seconds and zone co-exist in parsed data, instant seconds was not resolved correctly from them. ------------- Commit messages: - 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong Changes: https://git.openjdk.java.net/jdk/pull/5225/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5225&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272473 Stats: 14 lines in 2 files changed: 8 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/5225.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5225/head:pull/5225 PR: https://git.openjdk.java.net/jdk/pull/5225

6 6

RFR: 8272836: Optimize run time for java/lang/invoke/LFCaching tests
by Aleksey Shipilev 26 Aug '21

26 Aug '21

See the RFE for discussion. Current PR improves the test time like this: $ make run-test TEST=java/lang/invoke/LFCaching/ # Before real 3m51.608s user 5m21.612s sys 0m5.391s # After real 1m13.606s user 2m26.827s sys 0m4.761s ------------- Commit messages: - 8272836: Optimize run time for java/lang/invoke/LFCaching tests Changes: https://git.openjdk.java.net/jdk/pull/5214/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5214&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272836 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5214.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5214/head:pull/5214 PR: https://git.openjdk.java.net/jdk/pull/5214

3 10

Re: JPackage and ask for microphone permissions broken on OSX...
by Filteredaccount1 25 Aug '21

25 Aug '21

Hi Andy, During the wait for JDK 18, would it be possible to describe on the bug ticket what manual workaround steps are required to apply to an existing jPackaged app for distribution both inside and outside the app store? There are two info.plist files inside a jPackaged app. In my experience adding keys to both didn’t turn the ask microphone permissions on. <key>com.apple.security.device.audio-input</key> <true/> <key>NSMicrophoneUsageDescription</key> <string>The application is requesting access to the microphone.</string> Also, I raised at http://bugreport.java.com/ 9071230. So developer time isn’t wasted, could this be cancelled? (seems setup so the general public cannot). Thank You, Ben S. > Date: Wed, 18 Aug 2021 08:43:08 -0400 > From: Andy Herrick <andy.herrick(a)oracle.com> > To: core-libs-dev(a)openjdk.java.net > Subject: Re: JPackage and ask for microphone permissions broken on > OSX... > Message-ID: <1534b02b-262a-f338-aae5-d1693d0072b3(a)oracle.com> > Content-Type: text/plain; charset=utf-8; format=flowed > > OK - I have reproduced this problem, filed an issue, and found the fix. > > You can see the issue in https://bugs.openjdk.java.net/browse/JDK-8272639. > > Basically another key is needed in application plist to cause > application to ask for microphone access. > > It is far to late to get any fix into JDK17, but I will fix in JDK18 and > you can work around this issue in JDK17 (or JDK16) by using the > --resource-dir option:

4 5

Implementing MethodHandleProxies#asInterfaceInstance with hidden classes
by - 25 Aug '21

25 Aug '21

Currently, java.lang.invoke.MethodHandleProxies#asInterfaceInstance [1] is implemented with java.lang.reflect.Proxy. After looking at its public API, including Javadoc, it seems that MethodHandleProxies would benefit from a hidden class implementation without changing its public API definition (including Javadocs). Recently, there is JEP 416 [2] for reimplementing reflection based on method handles. This implementation utilizes hidden classes with method handles passed in classdata and retrieved to condy, which allows generic method handles (beyond regular constable ones) to be optimized in method calls. Similarly, for MethodHandleProxies, hidden classes allow the implementations to detach from classloaders and be freely recyclable; they can use class data to store the adapted method handles (which can significantly speed up invocations); and it can allow it to support implementing single-abstract-method abstract classes in the future (as discussed in its Javadoc) as well, with only minor tweaks. Does this sound feasible? I want to ensure it is a good idea before any implementation is attempted. If there is any issue with this vision, please don't hesitate to point it out. Feel free to comment, too! If this looks good, I hope an issue can be created for it. Best [1] https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/lang/invo… [2] https://openjdk.java.net/jeps/416

4 5

RFR: JDK-8272639: jpackaged applications using microphone on mac
by Andy Herrick 24 Aug '21

24 Aug '21

JDK-8272639: jpackaged applications using microphone on mac ------------- Commit messages: - JDK-8272639: jpackaged applications using microphone on mac Changes: https://git.openjdk.java.net/jdk/pull/5186/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5186&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272639 Stats: 5 lines in 3 files changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5186.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5186/head:pull/5186 PR: https://git.openjdk.java.net/jdk/pull/5186

3 6

RFR: 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java
by Calvin Cheung 24 Aug '21

24 Aug '21

Please review this trivial change for fixing the copyright year of the two files (jlink.properties and ImagePluginStack.java) which were modified unintentionally during the fix for JDK-8264322. ------------- Commit messages: - 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java Changes: https://git.openjdk.java.net/jdk/pull/5240/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5240&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272916 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/5240.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5240/head:pull/5240 PR: https://git.openjdk.java.net/jdk/pull/5240

2 3

Dangling class-level javadoc comments in JDK
by Andrey Turbanov 24 Aug '21

24 Aug '21

Hello. I found a few internal classes in the JDK codebase which don't have proper javadoc, but have dangling javadoc-like comments. Dangling Javadoc comments are ignored by the javadoc tool and IDE. Perhaps it was intentional to not add proper javadoc to them? I believe it's better to convert them to proper javadoc to make developing JDK a bit more friendly within IDE. What do you think? List of classes: com.sun.beans.editors.BooleanEditor com.sun.beans.editors.ByteEditor com.sun.beans.editors.DoubleEditor com.sun.beans.editors.FloatEditor com.sun.beans.editors.IntegerEditor com.sun.beans.editors.LongEditor com.sun.beans.editors.NumberEditor com.sun.beans.editors.ShortEditor com.sun.jndi.toolkit.dir.ContainmentFilter com.sun.jndi.toolkit.dir.LazySearchEnumerationImpl com.sun.security.auth.module.Crypt java.math.MutableBigInteger java.net.DefaultInterface javax.swing.GraphicsWrapper jdk.internal.access.JavaAWTFontAccess jdk.javadoc.internal.doclets.toolkit.CommentUtils sun.awt.X11.XAtom sun.awt.X11.XAwtState sun.java2d.xr.XRBackend sun.java2d.xr.XRDrawLine sun.jvm.hotspot.debugger.PageCache sun.jvm.hotspot.runtime.JavaThreadFactory sun.jvm.hotspot.utilities.Interval sun.jvm.hotspot.utilities.MessageQueueBackend sun.jvm.hotspot.utilities.RBTree sun.launcher.LauncherHelper sun.net.www.content.text.plain sun.net.www.protocol.file.FileURLConnection sun.nio.ch.Interruptible sun.security.pkcs.ParsingException sun.security.provider.SeedGenerator sun.security.util.ByteArrayTagOrder sun.security.util.IOUtils Andrey Turbanov

4 5

RFR: 8264322: Generate CDS archive when creating custom JDK image
by Calvin Cheung 24 Aug '21

24 Aug '21

Please review this change for adding a `jlink` command line option `--generate-cds-archive` for generating CDS archives as a post processing step during the creation of a custom JDK image. Details can be found in the corresponding CSR [JDK-8269178](https://bugs.openjdk.java.net/browse/JDK-8269178). Testing: - [x] tiers 1,2 (including the new test) ------------- Commit messages: - fix trailing whitespace - 8264322: Generate CDS archive when creating custom JDK image Changes: https://git.openjdk.java.net/jdk/pull/5174/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5174&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264322 Stats: 394 lines in 11 files changed: 354 ins; 7 del; 33 mod Patch: https://git.openjdk.java.net/jdk/pull/5174.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5174/head:pull/5174 PR: https://git.openjdk.java.net/jdk/pull/5174

3 11

RFR: JDK-8267936: PreserveAllAnnotations option isn't tested
by Jaroslav Tulach 24 Aug '21

24 Aug '21

There doesn't seem to be much support for the complete changes in #4245. To get at least something useful from that endeavor I have extracted the test for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it in this pull request without any changes to the JVM behavior. ------------- Commit messages: - Test long time existing behavior of -XX:+PreserveAllAnnotations Changes: https://git.openjdk.java.net/jdk/pull/4280/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4280&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267936 Stats: 172 lines in 1 file changed: 172 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4280.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4280/head:pull/4280 PR: https://git.openjdk.java.net/jdk/pull/4280

9 37

[(Much) faster java.util.LinkedList]
by Rodion Efremov 23 Aug '21

23 Aug '21

Hello, I have implemented a heuristic, indexed doubly-linked list data structure [1][2] implementing java.util.List and java.util.Deque interfaces that has superior performance compared to java.util.LinkedList and java.util.ArrayList. I would like to propose it into the upcoming versions of OpenJDK, but, first, I need to know what do you think about it? Best regards, rodde [1] https://github.com/coderodde/LinkedList [2] http://coderodde.github.io/weblog/#eill

2 1