- core-libs-dev - openjdk.org

[PATCH] BigInteger - minor performance & cleanup
by Pascal S. de Kloe 04 Jul '07

04 Jul '07

The patch introduces arraycopy and a little cleanup in BigInteger#add(int[], int[]). I started reading the source today with BigInteger and this was the first thing I noticed. Would you be interested in more of these very small patches? Cheers, Pascal

1 3

about socket reuse in RMI
by zhang Jackie 26 Jun '07

26 Jun '07

hi socket reuse in RMI confused me much for several reasons: In my opionion, one socket is boud some information about server and port(right?), how such socket can be reused to communicate to another server,just change the IP address and port number? Is it possible to do so in user space of linux? ServerSocket is used to accept new connection, one ServerSocket instance can fit the need of application, why reuse is needed. What the socket reuse of RMI means? Some one give me such a comment: *RMI will reuse sockets if the socket was created by the same socket factory. So, if two remote object's socket factories that are .equal() then RMI will reuse a client's socket to talk with each RMI object. It will also reuse that socket for multiple calls to those remote objects. * So this is not socket factory reuse ,rather than socket reuse. I was confused greatly, Do everyone can give me a clear explanation about this topic? thanks for any reply!

2 1

External zlib patches
by Anthony Petrov 14 Jun '07

14 Jun '07

Hello folks, Some time ago Diego Pettenò sent out a couple of patches that allow JDK use an external zlib library. A number of other fixes from this author sent to the awt-dev@ alias depend on the mentioned zlib patches, and cannot be easily applied without the zlib-patch applied first. Could anyone confirm whether the zlib-patches are currently being considered to be applied? -- best regards, Anthony

2 1

[Patch] Patch for javax.xml.parsers.DocumentBuilder
by Jeffrey Haškovec 14 Jun '07

14 Jun '07

Is it possible to get 2 more parse methods added to DocumentBuilder as below: /** * Parse the content of the given <code>Reader</code> as an XML * document and return a new DOM {@link Document} object. * An <code>IllegalArgumentException</code> is thrown if the * <code>Reader</code> is null. * * @param is Reader containing the content to be parsed. * * @return <code>Document</code> result of parsing the * <code>Reader</code> * * @throws IOException If any IO errors occur. * @throws SAXException If any parse errors occur. * @throws IllegalArgumentException When <code>is</code> is <code>null</code> * * @see org.xml.sax.DocumentHandler */ public Document parse(Reader reader) throws SAXException, IOException { if (reader == null) { throw new IllegalArgumentException("Reader cannot be null"); } InputSource in = new InputSource(reader); return parse(in); } /** * Parse the content of the given <code>Reader</code> as an * XML document and return a new DOM {@link Document} object. * An <code>IllegalArgumentException</code> is thrown if the * <code>Reader</code> is null. * * @param is Reader containing the content to be parsed. * @param systemId Provide a base for resolving relative URIs. * * @return A new DOM Document object. * * @throws IOException If any IO errors occur. * @throws SAXException If any parse errors occur. * @throws IllegalArgumentException When <code>is</code> is <code>null</code> * * @see org.xml.sax.DocumentHandler */ public Document parse(Reader reader, String systemId) throws SAXException, IOException { if (reader == null) { throw new IllegalArgumentException("Reader cannot be null"); } InputSource in = new InputSource(reader); in.setSystemId(systemId); return parse(in); } Basically InputSource will already accept a Reader. StringBufferInputStream is deprecated and says to use StringReader. DocumentBuilder won't parse a reader, so my problem is I can't parse an XML file that I have as a String in Memory. Thanks for your consideration, Jeffrey Haskovec

2 1

[PATCH] Identify language and country based on LC_MESSAGES rather than LC_CTYPE
by Diego 'Flameeyes' Pettenò 12 Jun '07

12 Jun '07

Hi, The attached patch changes the code that currently parses LC_CTYPE to set encoding, encoding variants, language and country to use LC_CTYPE just to set the encoding, and instead uses LC_MESSAGES to set country and language. The reason for this change si that in a system where LC_MESSAGES is set to English, you'd expect Java to answer in English, rather than Italian by default (this is true for both JDK's commands and for Java-based interfaces). The patch is probably rough, so I'd be happy to hear comments on what to improve of it. -- Diego "Flameeyes" Pettenò http://farragut.flameeyes.is-a-geek.org/

1 0

[PATCH] Add option to use external zlib (without awt/splashscreen changes)
by Diego 'Flameeyes' Pettenò 08 Jun '07

08 Jun '07

Hi, as I've just mailed to awt-dev a reduced copy of my previous external-zlib patch that only changes splashscreen support (as it's needed for external jpeg/giflib/libpng), I'm sending back a new copy of external-zlib that excludes that particular part. -- Diego "Flameeyes" Pettenò http://farragut.flameeyes.is-a-geek.org/

1 0

Re: [PATCH] Re: jar launcher not able to handle -march=nocona
by Kumar Srinivasan 01 Jun '07

01 Jun '07

Hello Petteri, Thank you for taking the time to post a fix for the issue you encountered. However, upon checking the Sun Contributor Agreement Signatories List, I don't find your name listed there. Sorry, we cannot evaluate or accept any code contributions made by a non signatory individual. If you think, you have already signed this, and error please let me know, I will pursue this matter with our administration staff. Thanks and regards, -- Kumar Srinivasan Sun Microsystems, Java Software.

1 0

jar launcher not able to handle -march=nocona
by Petteri Räty 30 May '07

30 May '07

<<<Finished Recursively making audio all @ Mon May 28 19:55:30 EEST 2007. >>>Recursively making dcpr all @ Mon May 28 19:55:30 EEST 2007 ... make[4]: Entering directory `/var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/j2se/make/sun/dcpr' /bin/mkdir -p /var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/control/build/linux-i586/classes /bin/echo -e "Copying classes from /opt/sun-jdk-1.7.0.0_alpha13/jre/lib/rt.jar" Copying classes from /opt/sun-jdk-1.7.0.0_alpha13/jre/lib/rt.jar (cd /var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/control/build/linux-i586/classes ; /var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/control/build/linux-i586/bin/jar xvf /opt/sun-jdk-1.7.0.0_alpha13/jre/lib/rt.jar sun/dc) /bin/sh: line 1: 17527 Segmentation fault /var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/control/build/linux-i586/bin/jar xvf /opt/sun-jdk-1.7.0.0_alpha13/jre/lib/rt.jar sun/dc make[4]: *** [copy-closed-src-classes] Error 139 make[4]: Leaving directory `/var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/j2se/make/sun/dcpr' make[3]: *** [all] Error 1 make[3]: Leaving directory `/var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/j2se/make/sun' make[2]: *** [all] Error 1 make[2]: Leaving directory `/var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/j2se/make' make[1]: *** [j2se-build] Error 2 make[1]: Leaving directory `/var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/control/make' make: *** [dev-build] Error 2 !!! ERROR: dev-java/openjdk-1.7.0.0_alpha13 failed. Call stack: ebuild.sh, line 1615: Called dyn_compile ebuild.sh, line 972: Called qa_call 'src_compile' ebuild.sh, line 44: Called src_compile openjdk-1.7.0.0_alpha13.ebuild, line 120: Called die In this case I am building with "-O2 -march=nocona -g" and using the following patches: http://overlays.gentoo.org/proj/java/browser/java-experimental/dev-java/ope… Here is the bt I get. The line numbers probably don't match because of O2: (gdb) set args xvf /opt/sun-jdk-1.7.0.0_alpha13/jre/lib/rt.jar sun/dc (gdb) run Starting program: /var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/control/build/linux-i586/bin/jar xvf /opt/sun-jdk-1.7.0.0_alpha13/jre/lib/rt.jar sun/dc [Thread debugging using libthread_db enabled] [New Thread -1209010512 (LWP 14559)] Program received signal SIGSEGV, Segmentation fault. [Switching to Thread -1209010512 (LWP 14559)] hyperthreading_support () at ../../../src/solaris/bin/java_md.c:1189 1189 if (_launcher_debug) { (gdb) bt #0 hyperthreading_support () at ../../../src/solaris/bin/java_md.c:1189 #1 0x0804daf3 in logical_processors_per_package () at ../../../src/solaris/bin/java_md.c:1259 #2 0x0804db97 in physical_processors () at ../../../src/solaris/bin/java_md.c:1284 #3 0x0804dc05 in linux_i586_ServerClassMachine () at ../../../src/solaris/bin/java_md.c:1349 #4 0x0804dc66 in ServerClassMachine () at ../../../src/solaris/bin/java_md.c:1376 #5 0x0804a434 in CheckJvmType (pargc=0xbff8f660, argv=0xbff8f664, speculative=0 '\0') at ../../../src/share/bin/java.c:709 #6 0x0804e0df in CreateExecutionEnvironment (_argcp=0xbff8f660, _argvp=0xbff8f664, jrepath=0xbff8e5d8 "/var/tmp/portage/dev-java/openjdk-1.7.0.0_alpha13/work/o/control/build/linux-i586", so_jrepath=4096, jvmpath=0xbff8d5d8 "", so_jvmpath=4096, original_argv=0x8052008) at ../../../src/solaris/bin/java_md.c:295 #7 0x0804bbd2 in main (argc=0, argv=0x8052098) at ../../../src/share/bin/java.c:253 I am in the process of trying to replicate this without -O2 to get a back trace but any thoughts on the issue would be appreciated. Regards, Petteri

2 3

Fixing compiler warnings
by Petteri Räty 24 May '07

24 May '07

This silences some QA warnings given by GCC. I don't have access to Solaris so it would probably be safest to test there before committing although man gettimeofday is claiming that the function is quite standard: CONFORMING TO SVr4, 4.3BSD. POSIX.1-2001 describes gettimeofday() but not settimeofday(). I haven't signed the SCA but this is hardly copyrightable. Regards, Petteri -- Gentoo/Java project lead

2 1

test message
by Tom Marble 19 May '07

19 May '07

All: Please ignore this test message. --Tom

1 0