After Phil Race's suggestion, I'm forwarding this to core-libs, as it
might be more appropriate.
Begin forwarded message:
Date: Fri, 11 May 2007 07:39:39 +0200
From: Diego 'Flameeyes' Pettenò <flameeyes(a)gmail.com>
To: build-dev(a)openjdk.java.net
Subject: [PATCH] Allow usage of external zlib copy
Most distributions have policies about using external copies of
libraries whenever possible. OpenJDK ships with a series of libraries
that are usually available on a system, like zlib and jpeg, thus
breaking such a policy.
The attached patch tries to correct part of this by letting use of
external zlib copy when passing EXTERNAL_ZLIB=true at the make process.
I'm also gonna work on a similar patch to use external jpeg library
(that will likely depend on this one because of some of the files
touched being the same).
--
Diego "Flameeyes" Pettenò
http://farragut.flameeyes.is-a-geek.org/
--
Diego "Flameeyes" Pettenò
http://farragut.flameeyes.is-a-geek.org/
(I hope this is the right mailing list for this, if it isn't, please
tell me where to post this :) )
I was looking at one warning coming from ld about the use of tmpname()
function rather than something like mkstemp, and while looking at that,
I found that the string returned by tempnam() was not being freed after
use.
I admit I don't have a Solaris box at hand to check if it's true there
too, but at least Linux's and FreeBSD's versions of tempnam() allocates
with malloc() the returned string. (My lack of a Solaris box at the
moment is what stops me from trying to use mkstemp() already; I'll try
to prepare a virtual machine with that as soon as I can).
The attached very very trivial patch fixes the leak by freeing the
string after use; it's a very small leak, but if I understand the code
well (but I won't bet I do) if a software uses that code repeatedly, it
might be significant.
Anyway, I hope this can be of help.
--
Diego "Flameeyes" Pettenò
http://farragut.flameeyes.is-a-geek.org/