January 2023 - hotspot-jfr-dev

Re: RFR: JDK-8300783: Consolidate byteswap implementations [v7]
by Justin King 24 Jan '23

24 Jan '23

> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078. Justin King has updated the pull request incrementally with one additional commit since the last revision: Add missing static_cast to XL C/C++ implementation Signed-off-by: Justin King <jcking(a)google.com> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12114/files - new: https://git.openjdk.org/jdk/pull/12114/files/4e98d704..428520cc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=05-06 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/12114.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114 PR: https://git.openjdk.org/jdk/pull/12114

1 0

RFR: 8290918: Initial nroff manpage generation for JDK 21
by David Holmes 24 Jan '23

24 Jan '23

Please review this simple update to the manpage to set the version to 21-ea. This change also corrects a typo in javac.1 that was manually introduced by JDK-8300591 Thanks. ------------- Commit messages: - 8290918: Initial nroff manpage generation for JDK 21 Changes: https://git.openjdk.org/jdk/pull/12154/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12154&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290918 Stats: 28 lines in 27 files changed: 0 ins; 0 del; 28 mod Patch: https://git.openjdk.org/jdk/pull/12154.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12154/head:pull/12154 PR: https://git.openjdk.org/jdk/pull/12154

4 7

RFR: Merge jdk20
by Jesper Wilhelmsson 23 Jan '23

23 Jan '23

Forwardport JDK 20 -> JDK 21 ------------- Commit messages: - Merge - 8290919: Update nroff pages in JDK 20 before RC The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk&pr=12150&range=00.0 - jdk20: https://webrevs.openjdk.org/?repo=jdk&pr=12150&range=00.1 Changes: https://git.openjdk.org/jdk/pull/12150/files Stats: 28 lines in 27 files changed: 1 ins; 0 del; 27 mod Patch: https://git.openjdk.org/jdk/pull/12150.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12150/head:pull/12150 PR: https://git.openjdk.org/jdk/pull/12150

1 1

[jdk20] RFR: 8290919: Update nroff pages in JDK 20 before RC
by David Holmes 23 Jan '23

23 Jan '23

There was one missing update in javac.1 from: [JDK-8245246](https://bugs.openjdk.org/browse/JDK-8245246): Deprecate -profile option in javac otherwise the change is limited to dropping the "-ea". Thanks. ------------- Commit messages: - Merge branch 'master' into 8290919-manpages - 8290919: Update nroff pages in JDK 20 before RC Changes: https://git.openjdk.org/jdk20/pull/112/files Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=112&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290919 Stats: 29 lines in 28 files changed: 1 ins; 0 del; 28 mod Patch: https://git.openjdk.org/jdk20/pull/112.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/112/head:pull/112 PR: https://git.openjdk.org/jdk20/pull/112

3 4

RFR: 8298377: JfrVframeStream causes deadlocks in ZGC
by Stefan Karlsson 19 Jan '23

19 Jan '23

The JfrVFrameStream is used while generating stack traces for events. One of the events are the ZPage allocation event. This event is sometimes sent when ZGC is relocating. The current implementation of JfrVFrameStream uses WalkContinuation::include, which causes JFR to walk the continuation and perform GC barriers. This is problematic, since ZGC has a requirement that we never perform load barriers while running the relocation code. If we do, we might end up performing other reloctions from the the relocation code, and in some cases that causes dead locks. I propose that JFR doesn't walk the continuations when sending events. An alternative could be to limit this to ZGC, but I'd like to get some feedback around that from JFR / Loom devs. We've been testing this patch in the Generational ZGC repository. ------------- Commit messages: - 8298377: JfrVframeStream causes deadlocks in ZGC Changes: https://git.openjdk.org/jdk/pull/11586/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11586&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298377 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11586.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11586/head:pull/11586 PR: https://git.openjdk.org/jdk/pull/11586

7 40

RFR: JDK-8300042: Improve CPU related JFR events descriptions
by Matthias Baesken 19 Jan '23

19 Jan '23

There are a number of JFR events dealing with CPU related information. Those sometimes miss descriptions or have very limited descriptions, this can be improved. ------------- Commit messages: - JDK-8300042 Changes: https://git.openjdk.org/jdk/pull/11969/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11969&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300042 Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/11969.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11969/head:pull/11969 PR: https://git.openjdk.org/jdk/pull/11969

4 11

RFR: Merge jdk20
by Jesper Wilhelmsson 18 Jan '23

18 Jan '23

Forwardport JDK 20 -> JDK 21 ------------- Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8300275: SegmentScope.isAccessibleBy returning incorrect values - 8300195: Fall-through issue occurs when using record pattern in switch statements - 8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error - 8295687: Better BMP bounds - 8293742: Better Banking of Sounds - 8293554: Enhanced DH Key Exchanges - 8287411: Enhance DTLS Performance - 8293717: Objective view of ObjectView - 8293734: Improve BMP image handling - ... and 5 more: https://git.openjdk.org/jdk/compare/8b70c432...77fb81ec The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk&pr=12085&range=00.0 - jdk20: https://webrevs.openjdk.org/?repo=jdk&pr=12085&range=00.1 Changes: https://git.openjdk.org/jdk/pull/12085/files Stats: 564 lines in 27 files changed: 332 ins; 117 del; 115 mod Patch: https://git.openjdk.org/jdk/pull/12085.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12085/head:pull/12085 PR: https://git.openjdk.org/jdk/pull/12085

1 1

RFR: 8292266: Add JFR event for total Reference processing time
by Sangheon Kim 18 Jan '23

18 Jan '23

Hi all, Can I have reviews for this change that adds a new JFR event for total Reference Processing time? The goal is to generate a new JFR event if there is already measured time. This CR doesn't add new time measurement. Testing: hs-tier1 ~ 3 Thanks, Sangheon ------------- Commit messages: - Remove comment out code. - Combine GCTrace::report method. - Separate GCTrace::report method. Changes: https://git.openjdk.org/jdk/pull/11230/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11230&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292266 Stats: 141 lines in 11 files changed: 135 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/11230.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11230/head:pull/11230 PR: https://git.openjdk.org/jdk/pull/11230

6 19

RFR: 8297877: Risk for uninitialized memory in case of CHECK macro early return as part of field access
by Markus Grönlund 13 Jan '23

13 Jan '23

Greetings, this change removes the risk of accessing uninitialized memory as part of field access when using the jfrJavaSupport abstraction, in case the klass->initialize(CHECK) early outs. It includes a small refactoring when in the area. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - 8297877 Changes: https://git.openjdk.org/jdk/pull/11950/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11950&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297877 Stats: 44 lines in 3 files changed: 13 ins; 15 del; 16 mod Patch: https://git.openjdk.org/jdk/pull/11950.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11950/head:pull/11950 PR: https://git.openjdk.org/jdk/pull/11950

3 7

RFR: 8297877: jfr functions should check JavaValue result before use
by Calvin Cheung 11 Jan '23

11 Jan '23

Please review this changeset including: 1) change `JfrJavaSupport::get_field_global_ref()` to return a `bool` so that in `install_chunk_monitor()` in `jfrChunkRotation.cpp`, it checks the return status before doing `result.get_jobject()`. 2) add an `assert` in `JfrDCmd::print_help()` to make sure the `result` is of `T_OBJECT` type. Passed tiers 1 - 4 testing. ------------- Commit messages: - 8297877: jfr functions should check JavaValue result before use Changes: https://git.openjdk.org/jdk/pull/11934/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11934&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297877 Stats: 10 lines in 4 files changed: 5 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/11934.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11934/head:pull/11934 PR: https://git.openjdk.org/jdk/pull/11934

1 2