January 2023 - hotspot-jfr-dev

RFR: 8297874: get_dump_directory() in jfrEmergencyDump.cpp should pass correct length to jio_snprintf
by Calvin Cheung 10 Jan '23

10 Jan '23

Please review this simple fix for correcting the length passing to` jio_snprintf `in the `get_dump_directory()` function in `jfrEmergencyDump.cpp`. Passed tiers 1 - 4 testing. ------------- Commit messages: - 8297874: get_dump_directory() in jfrEmergencyDump.cpp should pass correct length to jio_snprintf Changes: https://git.openjdk.org/jdk/pull/11916/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11916&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297874 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11916.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11916/head:pull/11916 PR: https://git.openjdk.org/jdk/pull/11916

2 4

RFR: JDK-8299520: TestPrintXML.java output error messages in case compare fails
by Matthias Baesken 03 Jan '23

03 Jan '23

Currently the compare function in the jfr related test TestPrintXML.java does not output anything in case of failing event comparisons. This should be enhanced. ------------- Commit messages: - JDK-8299520 Changes: https://git.openjdk.org/jdk/pull/11827/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11827&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299520 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11827.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11827/head:pull/11827 PR: https://git.openjdk.org/jdk/pull/11827

2 3

RFR: 8299380: conflict assert definitions
by Xue-Lei Andrew Fan 03 Jan '23

03 Jan '23

May I have this code cleanup reviewed? The following failure occurs while building on MacOS M1: In file included from /Users/xueleifan/workspace/jdk-dev/test/hotspot/gtest/jfr/test_networkUtilization.cpp:222: ------------- Commit messages: - update copyright date - 8299380: conflict assert definitions Changes: https://git.openjdk.org/jdk/pull/11792/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11792&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299380 Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/11792.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11792/head:pull/11792 PR: https://git.openjdk.org/jdk/pull/11792

3 11