[OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

Jim Graham Jim.A.Graham at Sun.COM
Mon Oct 19 20:04:14 UTC 2009


Hi Mario,

That's just what I was trying to describe, thanks!  Looks good to go...

		...jim

Mario Torre wrote:
> Il 25/09/2009 22:29, Jim Graham ha scritto:
> 
> Hi Jim,
> 
>> I think we could add a quick "if (loops == null) {...}" in those 2
>> classes and maybe add a comment "// assert(some pipe will always be a
>> LoopBasedPipe)" to indicate that we aren't checking the types of the
>> pipes because we think it is always true in case that assumption changes
>> in the future. Does that make sense?
> 
> Not sure if this is what you mean:
> 
> http://cr.openjdk.java.net/~neugens/100068/webrev.09
> 
> Looks like it doesn't break stuff, I did the usual test with Java2D demo.
> 
> Cheers,
> Mario



More information about the 2d-dev mailing list