[OpenJDK 2D-Dev] Please review patch for 7150134

Clemens Eisserer linuxhippy at gmail.com
Fri Apr 13 23:35:45 UTC 2012


Hi Jim,

> I don't understand.  You are checking to see if the line is inside the clip,
> but your test will think that something is inside the clip when it is not so
> the "fast path" code will be used for lines outside the clip.  If the case
> can handle lines outside the clip then why test at all?

The xrender pipeline uses bresenham to transform diagonal lines into a
lists of rectangles, without clipping it was possible with large
line-coordinates to cause an OOM because of the huge amount of
rectangles generated. The corner-case of a complex clip where both
line end-points are contained would cause unnecessary rectangles to be
generated, but still only a few thanks to the component clip. The
unnecessary rects would be clipped away by the XServer later.

- Clemens



More information about the 2d-dev mailing list