[OpenJDK 2D-Dev] [8] request for review: 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances
Mario Torre
neugens at redhat.com
Mon Jul 29 15:21:18 UTC 2013
On Mon, 2013-07-29 at 19:05 +0400, Andrew Brygin wrote:
> Hi Mario,
>
> thanks for the comments!
>
> I agree that 'stream' and 'streamRef' are not appropriate names now,
> because these entities point to instances of writer/reader.
>
> However, these entities use the writer/reader only as a holder of
> certain set of I/O routines, so probably names for these entities
> should reflect their I/O nature.
>
> Would 'ioRef' and 'input'/'output' sound better than 'stream'?
Hi Andrew,
Those seems better defaults, yes.
At first I got confused with "stream" because the struct used to hold
the Input/Output stream for real. I guess what really bothers me though
is the comment:
jweak streamRef; // ImageInputStream or ImageOutputStream
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Which is misleading now :) so thanks for addressing this!
Cheers,
Mario
More information about the 2d-dev
mailing list