[OpenJDK 2D-Dev] Request for review: Additional fix for JDK-7159455
Jim Graham
james.graham at oracle.com
Wed Nov 6 21:44:52 UTC 2013
Hi Clemens,
On 11/6/13 9:38 AM, Clemens Eisserer wrote:
>> A new question/issue - on line 314, what happens if the case is both
>> quadrant rotated and extra-alpha'd? Either of those will get us into that
>> code block, but also both of them could be true at the same time in which
>> case it looks like you forego the retreival of the EA mask...?
>
> In this case a 1x1 mask with EA prepared in advance by
> XRCompositionManager will be used, returned by
> xrMgr.getExtraAlphaMask().
I think I had that backwards. I was referring to the other case which
does not call xrMgr.getExtraAlphaMask():
312 // For quadrant-transformed blits geometry is not
stored inside the mask
313 // therefore we can use a repeating 1x1 mask for
applying extra alpha.
314 int maskPicture = isQuadrantRotated ?
xrMgr.getExtraAlphaMask()
315 : mask.prepareBlitMask(x11sdDst, maskTX,
width, height);
In the "mask.prepareBlitMask" case I don't see where extra alpha is
processed, but perhaps I am missing something and it is already
registered in some data structure somewhere?
...jim
More information about the 2d-dev
mailing list