[OpenJDK 2D-Dev] Request for review: Additional fix for JDK-7159455

Clemens Eisserer linuxhippy at gmail.com
Wed Nov 6 21:51:51 UTC 2013


> I think I had that backwards.  I was referring to the other case which does
> not call xrMgr.getExtraAlphaMask():
>
>  312                 // For quadrant-transformed blits geometry is not
> stored inside the mask
>  313                 // therefore we can use a repeating 1x1 mask for
> applying extra alpha.
>  314                 int maskPicture = isQuadrantRotated ?
> xrMgr.getExtraAlphaMask()
>  315                         : mask.prepareBlitMask(x11sdDst, maskTX, width,
> height);
>
> In the "mask.prepareBlitMask" case I don't see where extra alpha is
> processed, but perhaps I am missing something and it is already registered
> in some data structure somewhere?

Yes, prepareBlitMask handles EA too - the XRMaskImage instance of
actually fetched from XRCompositeManager, which was designed to
encapsulate EA handling.
I hope to get especially this piece of code into more consistent state
with JDK9, as there is no real need to handle EA explicitly inside the
Blits.

Thanks, Clemens



More information about the 2d-dev mailing list