[OpenJDK 2D-Dev] RFR 8078654: CloseTTFontFileFunc callback should be removed

[Phil Race]

I think this fix should be fine. There should be no reason
we need to do anything here as the file should already be
closed by the Java side which has demonstrably gone away
so should have already closed the file before then.

-phil.

On 04/27/2015 03:07 AM, Andrew Dinn wrote:
> Please review this proposed patch to remove a redundant callback in the
> truetype native scaler code. The urgency for this removal comes from the
> fact that the callback occasionally falls foul of a race condition which
> leads to an NPE:
>
>    http://cr.openjdk.java.net/~adinn/8078654/webrev.00/
>
> The problematic code is the same in JDK9, JDK8 and JDK7.
>
> Previous discussion with Phil Race (tentatively) confirmed that the
> removed callback is redundant:
>
>    http://mail.openjdk.java.net/pipermail/2d-dev/2015-January/005015.html
>
> Red Hat support staff subsequently identified the race condition:
>
>    http://mail.openjdk.java.net/pipermail/2d-dev/2015-April/005257.html
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in UK and Wales under Company Registration No. 3798903
> Directors: Michael Cunningham (USA), Matt Parson (USA), Charlie Peters
> (USA), Michael O'Neill (Ireland)