[OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

[Sergey Bylokhov]

On 15/01/16 09:59, Semyon Sadetsky wrote:
> Hi Phil & Sergey,
>
> I have integrated Intel GPU i5 and cannot test other hardware.
> On Mac's retina display the screen capture doesn't return exact pixel to
> pixel image but the scaled one. So Mac platform should be excluded from
> testing:
> http://cr.openjdk.java.net/~ssadetsky/8146042/webrev.01/

In this cases non-retina hw will not be covered. If there are some 
issues in the Robot, then you can skip it and use VolatileImage as a 
destination for rendering.

>
> --Semyon
>
> On 1/14/2016 9:23 PM, Phil Race wrote:
>> This fudge factor was last adjusted in
>> https://bugs.openjdk.java.net/browse/JDK-6597822
>> way back before the D3D pipeline was released and the comments seem to
>> indicate that
>> there was a fair amount of testing on different hardware.
>>
>> I don't know why this seems to be in un-specified hardware-dependent
>> territory but
>> it seems quite possible that this could just as easily introduce a
>> different artifact
>> on some other hardware.
>>
>> What exactly are you testing on ? And I think it needs to include at
>> least one Nvidia
>> and one AMD/ATI card.
>>
>> -phil.
>>
>> On 1/14/2016 10:09 AM, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review the fix for jdk9.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8146042
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8146042/webrev.00/
>>>
>>> The root cause is incorrect coordinate rounding in D3D renderer. To
>>> fix the issue one of fudge factors was adjusted.
>>>
>>> Another issue mentioning in the JIRA ticket is taken out as a
>>> separate bug.
>>>
>>> --Semyon
>>>
>>
>


-- 
Best regards, Sergey.