[OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations have issues with coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux systems

Clemens Eisserer linuxhippy at gmail.com
Wed Sep 28 05:45:07 UTC 2016


HI Jim,

> All of those conditions are optimized equivalents to getting the
> determinant.
>
> invert() is a destructive call, but since getTransform is documented to
> return a copy, that is fine - but getDeterminant() will involve less math to
> check the condition...

Thanks for the clarification.

Please find the latest version of the patch at
http://93.83.133.214/8162591/webrev.04/ - where catching the Exception
has been replaced with a != 0.0 check against the determinant. Please
commit  in case no further issues are found.

Best regards, Clemens



More information about the 2d-dev mailing list