[OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations have issues with coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux systems

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Sep 28 19:41:36 UTC 2016


Thanks.

On 28.09.16 8:45, Clemens Eisserer wrote:
> HI Jim,
>
>> All of those conditions are optimized equivalents to getting the
>> determinant.
>>
>> invert() is a destructive call, but since getTransform is documented to
>> return a copy, that is fine - but getDeterminant() will involve less math to
>> check the condition...
>
> Thanks for the clarification.
>
> Please find the latest version of the patch at
> http://93.83.133.214/8162591/webrev.04/ - where catching the Exception
> has been replaced with a != 0.0 check against the determinant. Please
> commit  in case no further issues are found.
>
> Best regards, Clemens
>


-- 
Best regards, Sergey.



More information about the 2d-dev mailing list