[OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

[Jayathirth D v]

Thanks for both the reviews.
Yes embed link and it is going to wrong bug. Thanks for pointing to proper link.

Regards,
Jay

> On 17-Apr-2020, at 3:21 AM, Philip Race <philip.race at oracle.com> wrote:
> 
> +1
> 
> BTW your bug link goes to the wrong bug, should go here : https://bugs.openjdk.java.net/browse/JDK-8195841 <https://bugs.openjdk.java.net/browse/JDK-8195841>
> 
> -phil.
> 
> On 4/13/20, 2:40 AM, Jayathirth D v wrote:
>> 
>> Hello All,
>> 
>> Please review the following fix for JDK 15:
>> 
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8195841 <https://bugs.openjdk.java.net/browse/JDK-6532025>
>> Webrev : http://cr.openjdk.java.net/~jdv/8195841/ <http://cr.openjdk.java.net/%7Ejdv/8195841/> 
>> 
>> Issue : PNGImageReader doesn’t check null terminated string for keyword when its length is maximum length
>> Solution : After we are done with reading the keyword stream make sure that last byte read is NUL.
>> 
>> Thanks,
>> Jay

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20200417/28bd6943/attachment.htm>