[RFR] jdk9.0.4+12 + functionality

[Andrey Petushkov]

> On 11 Apr 2018, at 18:46, Edward Nevill <edward.nevill at gmail.com> wrote:
> 
> On Wed, 2018-04-11 at 17:22 +0300, Andrey Petushkov wrote:
>>> On 11 Apr 2018, at 15:05, Edward Nevill <edward.nevill at gmail.com> wrote:
>>> 
>>> 
>> So how we proceed then? We should still have some way of pushing jdk9u history into our repo, right?
>> 
> 
> I think the way forward would be to get ops to populate the aarch32 area with a clean jdk9u tree.
> 
> The diffs for the aarch32 port could then be pushed to this. With a bit of care it might be possible to preserve the history from the jdk9 tree but even if that is lost it is not a big deal.
> 
Makes sense. Could you please do that as a project owner?
> I tried building the jdk9u merge. I notice that the generate-configure.sh is out of date with respect to platform.m4 so if I build the tree as is it builds 'arm'. But if I rengenerate the generated-configure.sh by doing
> 
> cd common/autoconf
> bash autogen.sh
> 
> it now builds 'aarch32' but the build fails because many *_arch32* files are missing. For example
> 
> /work/ed/aarch32/azul/hotspot/src/share/vm/runtime/globals.hpp:47:32: fatal error: c1_globals_aarch32.hpp: No such file or directory
> #include CPU_HEADER(c1_globals)
> 
> These files are included in your 'functionality' patch. It would seem that the merged repo does not build correctly without your second patchset so there is little point in considering them as two separate patchs.
> 
> Instead they should be considered as a single patch which adds c1/c2 functionality to the jdk9u base.
> 
Really I was not considering “update” patch as something which adds anything beyond just upstream changes. Yes, if you’d like to have something meaningful both patches should be taken together
> I subsequently tried building the combined patches 'merge' + 'functionality'
> 
> The configure line I used was
> 
> bash ./configure --disable-warnings-as-errors --with-boot-jdk=/work/ed/images/jdk1.8.0_65 --with-jobs=2 --with-jvm-variants=client
> 
> This fails with the error
> 
> Compiling 4 files for BUILD_JIGSAW_TOOLS
> Error: missing `server' JVM at `/work/ed/aarch32/azul_c2/build/linux-aarch32-normal-client-release/jdk/lib/server/libjvm.so'.
> Please install or use the JRE or JDK that contains these missing components.
> ExplodedImageOptimize.gmk:40: recipe for target '/work/ed/aarch32/azul_c2/build/linux-aarch32-normal-client-release/jdk/_packages_attribute.done' failed
> 
> So it has build the jdk, but has an incorrectly configured jvm.cfg file.
Right, but we really have never resolved a problem of building right jvm.cfg :(
One simple workaround would be to build with —with-build-jdk configure option which also saves time by not building buildjdk. Of course jvm.cfg in the final output should still be fixed in order to run it..
> 
> I'll try the c2 build next,
> Ed.
Thank you,
Andrey
>