[RFR] jdk9.0.4+12 + functionality

[Andrey Petushkov]

On Wed, Apr 11, 2018 at 9:11 PM Edward Nevill <edward.nevill at gmail.com>
wrote:

> On Wed, 2018-04-11 at 18:57 +0300, Andrey Petushkov wrote:
> > > On 11 Apr 2018, at 18:46, Edward Nevill <edward.nevill at gmail.com>
> wrote:
> > >
> > > I'll try the c2 build next,
> > > Ed.
> >
>
> The c2 build seems to build OK and I have done a few basic tests on the
> resultant image.
>
> I notice that the default build is 'aarch32' which means that there is no
> way to specify the 'arm' build.
>
> From the help
>
>   --with-cpu-port         specify sources to use for Hotspot 64-bit ARM
> port
>                           (arm64,aarch64,aarch32) [aarch64]
>
> If the default is aarch32 then there needs to be another option 'arm' to
> allow you to build the existing arm32 c2.
>
Ah, sorry, did not think of it. Will work it out

>
>
> I am uneasy about your copyright notices:-
>
> +// This file is a derivative work resulting from (and including)
> modifications
> +// made by Azul Systems, Inc.  The dates of such changes are 2013-2018.
> +// Copyright 2013-2018 Azul Systems, Inc.  All Rights Reserved.
> +//
> +// Please contact Azul Systems, 385 Moffett Park Drive, Suite 115,
> Sunnyvale,
> <https://maps.google.com/?q=act+Azul+Systems,+385+Moffett+Park+Drive,+Suite+115,+Sunnyvale,&entry=gmail&source=g>
> +// CA 94089 USA or visit www.azul.com if you need additional information
> or
> +// have any questions.
>
> If you are unable to use the existing copyright format, viz
>
>  * Copyright (c) 2014, Red Hat Inc. All rights reserved.
>  * Copyright (c) 2015, Linaro Ltd. All rights reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>
> then the copyright notices will have to be reviewed by someone in
> authority at Oracle.
>
Unfortunately that is our organization wide policy. I'll ask our CTO Gil
Tene to help with that, I'm pretty sure this is solvable

>
> Also, I notice in some cases you have applied copyright notices where
> there are no changes to the file (other than the copyright notices).
>
That should be somewhere inside hotspot/src/cpu/aarch32, right? In this
case they have been added at early project times when we were merging our
initial effort with what you have put on bitbucket. Indeed there is no
value there so I can remove them if you'd like.
OTOH if they are somewhere in shared code that should be mistake. I'll
review the code once again for that

>
> I need to spend more time looking through your patch in more detail.
> Unfortunately I am at work for the next few days so it is likely to be the
> start of next week before I can have a detailed look at this.
>
Sure no problem. You've been so kind actively looking at the subject last
days which I did not dare to hope when I sent an RFR, really appreciate
that!

Best regards,
Andrey

PS. Finished CRC32C and on the way with CompactStrings. Will follow up with
that but probably once we sort current changes out. Just for the sake of
clean baseline for that patch

>
> All the best,
> Ed.
>
>