[aarch64-port-dev ] Use an explicit set of registers rather than a bitmap for psh and pop operations.

Andrew Haley aph at redhat.com
Wed Apr 23 09:29:52 UTC 2014


On 04/23/2014 09:34 AM, Edward Nevill wrote:
> Hi Andrew,
> 
> It looks fine to me. A couple of small points
> 
>> Use an explicit set of registers rather than a bitmap for psh and pop operations.
> 
> 'push' rather than 'psh' in the commit comment
> 
> (if this is a pain to fix don't bother)
> 
> In class RegSet for consistency I would provide
> 
>   RegSet operator-(Register r1)
> 
> You have RegSet + Register and RegSet - RegSet. I would be surprised if RegSet - Register did not work for me.

OK.  I think I'll provide a conversion operator from Register to RegSet
so that'll just work.

Thanks,
Andrew.




More information about the aarch64-port-dev mailing list