[aarch64-port-dev ] RFR [M] : 8087333, Optionally Pre-Generate the HotSpot Template Interpreter

[Andrew Haley]

On 06/23/2015 01:49 PM, Bertrand Delsart wrote:
> On 23/06/2015 12:22, Andrew Haley wrote:
>> On 23/06/15 10:15, Bertrand Delsart wrote:
>>> While investigating why I had added the .S files for this CR, I noticed
>>> that aarch64 open port has some .S files checked-in but no rules to
>>> compile them. To avoid triggering the compilation and linking of these
>>> (obsolete?) files in the open aarch64 port, I had to modify the change
>>> in vm.make.
>>
>> Both of these .S files are used by simulator builds.  We probably don't
>> need them any more.
> 
> Thanks Andrew,
> 
> Let me know whether you prefer my new extensible Src_Files_BASE based 
> findsrc rule in hotspot/make/linux/makefiles/vm.make or whether I can 
> hard code the fact that .S files, if present, should be compiled.
> 
> In the later case, I can either delete your .S files or add them in 
> Src_Files_EXCLUDE
> 
> See
> http://cr.openjdk.java.net/~bdelsart/8087333/webrev.00-02/webrev/make/linux/makefiles/vm.make.udiff.html
> 
> (The addition of .S files for our extensions was moved to make/closed, 
> using a simple/extensible "Src_Files_BASE += \*.S")

Hmmm.  Ed, Andrew Dinn, do you understand the issue here?

Andrew.