[aarch64-port-dev ] RFR [M] : 8087333, Optionally Pre-Generate the HotSpot Template Interpreter

Bertrand Delsart bertrand.delsart at oracle.com
Tue Jun 23 15:05:18 UTC 2015


On 23/06/2015 16:30, Andrew Haley wrote:
> On 06/23/2015 01:49 PM, Bertrand Delsart wrote:
>> On 23/06/2015 12:22, Andrew Haley wrote:
>>> On 23/06/15 10:15, Bertrand Delsart wrote:
>>>> While investigating why I had added the .S files for this CR, I noticed
>>>> that aarch64 open port has some .S files checked-in but no rules to
>>>> compile them. To avoid triggering the compilation and linking of these
>>>> (obsolete?) files in the open aarch64 port, I had to modify the change
>>>> in vm.make.
>>>
>>> Both of these .S files are used by simulator builds.  We probably don't
>>> need them any more.
>>
>> Thanks Andrew,
>>
>> Let me know whether you prefer my new extensible Src_Files_BASE based
>> findsrc rule in hotspot/make/linux/makefiles/vm.make or whether I can
>> hard code the fact that .S files, if present, should be compiled.
>>
>> In the later case, I can either delete your .S files or add them in
>> Src_Files_EXCLUDE
>>
>> See
>> http://cr.openjdk.java.net/~bdelsart/8087333/webrev.00-02/webrev/make/linux/makefiles/vm.make.udiff.html
>>
>> (The addition of .S files for our extensions was moved to make/closed,
>> using a simple/extensible "Src_Files_BASE += \*.S")
>
> Hmmm.  Ed, Andrew Dinn, do you understand the issue here?

Stated differently, I need to add support for finding and compiling .S 
files for this extension. In Hotspot, this is done thanks to:
- a rule to compile them
- 'findsrc', which builds the list of files to compile and link

During reviews, I realized there are .S files in your code. These files 
are currently ignored by openjdk builds. However, my initial 
modification was going to cause these files to be spotted by findsrc 
(and hence compiled and linked with your JVM).

To avoid compiling and linking them, I need either:
- to remove them
- or to ensure findsrc does not look for them (thanks to my
   proposed Src_Files_BASE mechanism)
- or to ensure findsrc excludes them (through Src_Files_EXCLUDE)

Hope this helps,

Bertrand.

>
> Andrew.
>
>


-- 
Bertrand Delsart,                     Grenoble Engineering Center
Oracle,         180 av. de l'Europe,          ZIRST de Montbonnot
38330 Montbonnot Saint Martin,                             FRANCE
bertrand.delsart at oracle.com             Phone : +33 4 76 18 81 23

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE: This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or
distribution is prohibited. If you are not the intended recipient,
please contact the sender by reply email and destroy all copies of
the original message.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


More information about the aarch64-port-dev mailing list