[aarch64-port-dev ] RFR: 8079507: jdk9: aarch64: fails to build after merge from hs-comp

[Vladimir Kozlov]

This looks good.

Thanks,
Vladimir

On 5/7/15 7:03 AM, Edward Nevill wrote:
> On Wed, 2015-05-06 at 09:06 -0700, Vladimir Kozlov wrote:
>> On 5/6/15 8:45 AM, Edward Nevill wrote:
>>> Hi,
>>>
>>> After the latest merge from hs-comp, jdk9/dev fails to build for aarch64.
>>>
>>> JIRA report here
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8079507
>>>
>>> webrev here
>>>
>>> http://cr.openjdk.java.net/~enevill/8079507/webrev.00/
>>
>> Instead of repeated (!is_static && rc == may_rewrite) checks can you add
>> and use one boolean calculated before the code?
>
> New webrev at
>
> http://cr.openjdk.java.net/~enevill/8079507/webrev.02/
>
> Rather than create a new bool I set the RewriteControl rc to may_not_rewrite like so
>
>    // Dont rewrite getstatic, only getfield
>    if (is_static) rc = may_not_rewrite;
>
> Then the condition for each case becomes
>
>    if (rc == may_rewrite) {
>      ...
>    }
>
> I think this is more in the spirit of the RewriteControl enum having values may_rewrite and may_not_rewrite than creating a separate bool.
>
> Vladimir: I have marked you as reviewer. If you are happy with this change please let me know and I will go ahead and push.
>
> All the best,
> Ed.
>
>