[aarch64-port-dev ] Freeze aarch64/jdk8

[Andrew Dinn]

On 29/02/16 16:19, Andrew Dinn wrote:
> On 29/02/16 16:14, Andrew Hughes wrote:
>> The other changes appear to have been included and the build on s390 is
>> now broken as a result (mismatch between the types of
>> CODE_CACHE_DEFAULT_LIMIT and ReservedCodeCacheSize * 5 in the min2 macro).
>> Can I revert the changes to these two files?
>> (src/share/vm/utilities/globalDefinitions.hpp & src/share/vm/runtime/arguments.cpp)
> 
> Andrew Haley followed up with a note explaining that these changes are
> needed on AArch64 (which is why I put them back in again). I think it
> might be better to fix the breakage to the PPC code. Perhaps Andrew
> Haley can comment?

Sorry, that should have read breakage to the PPC build -- since the
error appears to be in code that is part of the patch.

I am not sure I follow what is happening here. ReservedCodeCacheSize is
an int. CODE_CACHE_DEFAULT_LIMIT defaults to CODE_CACHE_SIZE_LIMIT which
is defined as (2 * G). AArch64 redefines it to (128 * M). G and M are
both of type size_t. Do we just need a cast when we pass the arguments
to min2?

Andrew Hughes, can you provide more details on the error?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul
Argiry (US)