[aarch64-port-dev ] Freeze aarch64/jdk8

[Andrew Hughes]

----- Original Message -----
> On 29/02/16 16:19, Andrew Dinn wrote:
> > On 29/02/16 16:14, Andrew Hughes wrote:
> >> The other changes appear to have been included and the build on s390 is
> >> now broken as a result (mismatch between the types of
> >> CODE_CACHE_DEFAULT_LIMIT and ReservedCodeCacheSize * 5 in the min2 macro).
> >> Can I revert the changes to these two files?
> >> (src/share/vm/utilities/globalDefinitions.hpp &
> >> src/share/vm/runtime/arguments.cpp)
> > 
> > Andrew Haley followed up with a note explaining that these changes are
> > needed on AArch64 (which is why I put them back in again). I think it
> > might be better to fix the breakage to the PPC code. Perhaps Andrew
> > Haley can comment?
> 
> Sorry, that should have read breakage to the PPC build -- since the
> error appears to be in code that is part of the patch.
> 
> I am not sure I follow what is happening here. ReservedCodeCacheSize is
> an int. CODE_CACHE_DEFAULT_LIMIT defaults to CODE_CACHE_SIZE_LIMIT which
> is defined as (2 * G). AArch64 redefines it to (128 * M). G and M are
> both of type size_t. Do we just need a cast when we pass the arguments
> to min2?
> 

In short, yes.

It's s390. On s390, size_t is a long unsigned int, while the right-hand
side, ReservedCodeCacheSize * 5, is a uintx:

/builddir/build/BUILD/java-1.8.0-openjdk-1.8.0.72-5.b16.el7.s390/openjdk/hotspot/src/share/vm/runtime/arguments.cpp:1141:78: e\
rror: no matching function for call to 'MIN2(long unsigned int, uintx)'
                      MIN2(CODE_CACHE_DEFAULT_LIMIT, ReservedCodeCacheSize * 5));

We have a lot of cases of this on s390 which we have to fix, and getting
that upstream has been an uphill task, with them throwing rocks down at us
all the time.

We can fix it with a cast, but here I don't think this change should be even
made on non-AArch64, as it's a divergence from 8u. See the suggestion in my
previous e-mail.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222