[aarch64-port-dev ] Freeze aarch64/jdk8
Andrew Dinn
adinn at redhat.com
Mon Feb 29 16:47:41 UTC 2016
On 29/02/16 16:44, Andrew Hughes wrote:
> In short, yes.
>
> It's s390. On s390, size_t is a long unsigned int, while the right-hand
> side, ReservedCodeCacheSize * 5, is a uintx:
>
> /builddir/build/BUILD/java-1.8.0-openjdk-1.8.0.72-5.b16.el7.s390/openjdk/hotspot/src/share/vm/runtime/arguments.cpp:1141:78: e\
> rror: no matching function for call to 'MIN2(long unsigned int, uintx)'
> MIN2(CODE_CACHE_DEFAULT_LIMIT, ReservedCodeCacheSize * 5));
>
> We have a lot of cases of this on s390 which we have to fix, and getting
> that upstream has been an uphill task, with them throwing rocks down at us
> all the time.
>
> We can fix it with a cast, but here I don't think this change should be even
> made on non-AArch64, as it's a divergence from 8u. See the suggestion in my
> previous e-mail.
Oh. yeeeurch! Yes, your suggestion looks like a much better idea than
trying to fix it any other way.
regards,
Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul
Argiry (US)
More information about the aarch64-port-dev
mailing list