[aarch64-port-dev ] RFR: AArch64: 8209415: Fix JVMTI test failure HS202

[Andrew Hughes]

On Tue, 13 Nov 2018 at 17:23, Andrew Dinn <adinn at redhat.com> wrote:
>
> On 13/11/2018 16:40, Andrew Haley wrote:
> > In a moment of madness one of us (no names, no pack drill!)  managed
> > to translate from x86
> >
> >     __ cmpb(Address(rbcp, 0), Bytecodes::_invokestatic);
> >     __ jcc(Assembler::notEqual, L_done);
> >
> > to
> >
> >     __ ldrb(rscratch1, Address(rbcp, 0));
> >     __ cmpw(r1, Bytecodes::_invokestatic);
> >     __ br(Assembler::EQ, L_done);
> >
> > Two bugs in thee lines... fixed thusly.
> >
> > http://cr.openjdk.java.net/~aph/8209415/
> >
> > OK for trunk and jdk8u ?
> Oh my goodness, that's a doozy. Amazing that it lay there for so long
> (the author seems to have checked it in in 2015 :-P )
>
> Patch is good!
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

Yep, it's there in 7 too:

https://icedtea.classpath.org/hg/release/icedtea7-forest-2.6/hotspot/file/tip/src/cpu/aarch64/vm/templateInterpreter_aarch64.cpp#l1885

I'll get it fixed there as well:
https://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3669.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222