[aarch64-port-dev ] RFR(XS): AARCH64: wrong encoding for exclusive and atomic load/stores

Dmitrij Pochepko dmitrij.pochepko at bell-sw.com
Thu Dec 6 14:37:03 UTC 2018


Hi all,

please review small fix for JDK-8214961: AARCH64: wrong encoding for 
exclusive and atomic load/stores

Intruction encoding for exclusive and atomic load/stores must allow sp 
as base addressing register by specification, but hotspot encoding 
implementation hits assert on trying it.

Fix is simple: use srf(...) call insead rf(...). "srf" call encode sp as 
number 31 register, while "rf" hits assert.


Testing: I modified existing code to use sp with affected instructions. 
Assert was hit without patch and wasn't hit with patch.


webrev: http://cr.openjdk.java.net/~dpochepk/8214961/webrev.01/

CR: https://bugs.openjdk.java.net/browse/JDK-8214961


Thanks,

Dmitrij



More information about the aarch64-port-dev mailing list