[aarch64-port-dev ] RFR(S): 8204473 - AARCH64: register post-index addressing mode is not supported directly

[Dmitrij Pochepko]

On 06.06.2018 19:59, Dmitrij Pochepko wrote:
>
>
> On 06.06.2018 19:37, Andrew Haley wrote:
>> On 06/06/2018 02:33 PM, Dmitrij Pochepko wrote:
>>> Hi all,
>>>
>>> please review patch for: JDK-8204473 -  AARCH64: register post-index
>>> addressing mode is not supported directly
>>>
>>> This patch adds new addressing mode: "post_reg"  (register post-index)
>>> with respective changes in code. It is used for ld* and st*
>>> instructions. Before this patch, this mode could be enabled by using
>>> base_plus_offset_reg, which makes code confusing.
>>>
>>>
>>> Testing: I launched hotspot jtreg compiler tests to ensure nothing is
>>> broken. No new failures found.
>>>
>>>
>>> webrev: http://cr.openjdk.java.net/~dpochepk/8204473/webrev.01/
>>>
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8204473
>> Did you run a debug build?
>>
>> # To suppress the following error report, specify this argument
>> # after -XX: or in .hotspotrc: 
>> SuppressErrorAt=/assembler_aarch64.hpp:2089
>> #
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> #  Internal Error 
>> (/local/jdk-jdk/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:2089), 
>> pid=31485, tid=31486
>> #  Error: ShouldNotReachHere()
>> #
>> # JRE version:  (11.0) (slowdebug build )
>> # Java VM: OpenJDK 64-Bit Server VM (slowdebug 
>> 11-internal+0-adhoc.aph.jdk-jdk, mixed mode, aot, sharing, tiered, 
>> compressed oops, g1 gc, linux-aarch64)
>> # Core dump will be written. Default location: 
>> /local/jdk-jdk/build/linux-aarch64-normal-server-slowdebug/jdk/bin/core.31485
>> #
>> # An error report file with more information is saved as:
>> # 
>> /local/jdk-jdk/build/linux-aarch64-normal-server-slowdebug/jdk/bin/hs_err_pid31485.log
>> #
>> # If you would like to submit a bug report, please visit:
>> #   http://bugreport.java.com/bugreport/crash.jsp
>> #
>> Current thread is 31486
>> Dumping core ...
>>
> Ahh, sorry. Missed single existing [ab]usage of such addressing in 
> fastdebug mode: 
> http://hg.openjdk.java.net/jdk/jdk/file/tip/src/hotspot/cpu/aarch64/assembler_aarch64.cpp#l1179
>
> However, there is a confusing comment there: "// BEGIN  Generated code 
> -- do not edit // Generated by aarch64-asmtest.py"
> What should we do about it? I don't see aarch64-asmtest.py to edit. Do 
> we need to edit this smoke test directly despite this comment?
>
> Thanks,
> Dmitrij
... there is still // END Generated code comment above, but I don't 
know, if aarch64-asmtest.py (if any will be ever used) will append 
hand-written code to a generated one. In that case, where it takes this 
code to append? Or it is safe to edit?

Thanks,
Dmitrij