[aarch64-port-dev ] RFR (trivial): 8234228: AArch64: Clean up redundant temp vars in generate_compare_long_string_different_encoding

[Patrick Zhang OS]

Thanks Andrew,
I uploaded a new webrev: http://cr.openjdk.java.net/~qpzhang/8234228/webrev.02. Nothing changed in code, I rebased it on the latest tip, checked building, and updated the reviewer list. Could you please help sponsor and push it? Thanks in advance.

With regards to the code refine for these intrinsics, Dmitrij had a nice patch for refactoring, as well as the inline document [1]. I believe the functions can be improved much once his code changes get pushed in future. FYI.
[1] http://cr.openjdk.java.net/~dpochepk/8218748/webrev.02/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp.sdiff.html 

Regards
Patrick

-----Original Message-----
From: Andrew Dinn <adinn at redhat.com> 
Sent: Thursday, December 19, 2019 1:28 AM
To: Patrick Zhang OS <patrick at os.amperecomputing.com>; aarch64-port-dev at openjdk.java.net
Subject: Re: [aarch64-port-dev ] RFR (trivial): 8234228: AArch64: Clean up redundant temp vars in generate_compare_long_string_different_encoding

Hi Patrick,

On 10/12/2019 05:43, Patrick Zhang OS wrote:
> Could anyone help review this patch, thanks.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8234228
> Webrev: http://cr.openjdk.java.net/~qpzhang/8234228/webrev.01
Thank you. This patch is good and ok to push.

It took me quite a while to figure out that this was a trivial patch because the code is *abysmally* written and *even more* badly explained.
The worst aspect of it is the register naming which is extremely misleading. However, it is terrible in many other respects. I think the code really needs a respray and, perhaps, some reorganization to make it clearer what is going on.

regards,


Andrew Dinn
-----------