[aarch64-port-dev ] 8248238: Implementation of JEP: Windows AArch64 Support

[Aleksey Shipilev]

On 8/19/20 11:52 PM, Bernhard Urban-Forster wrote:
> Hello everyone,
> 
> here is an updated changeset:
> http://cr.openjdk.java.net/~burban/8248238/webrev.01/

Looking briefly:

  *) make/autoconf/jvm-features.m4: are we sure Shenandoah does not work with Windows AArch64? I 
don't think there should be a problem with it. I also see there are Shenandoah-related changes 
elsewhere, so I assume it was built at some time?

  *) src/hotspot/cpu/aarch64/aarch64.ad: are these needed?

  993 #include "gc/shared/barrierSet.hpp"
  994 #include "gc/shared/barrierSetAssembler.hpp"

  *) src/hotspot/share/runtime/vm_version.hpp: new includes in the .hpp file? Wouldn't it be better 
to do them in the relevant compilation units?

   28 #include "memory/allocation.hpp"
   29 #include "utilities/ostream.hpp"

None of this blocks the push to staging repository, but maybe consider following up on these going 
forward?

-- 
Thanks,
-Aleksey