[aarch64-port-dev ] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints

Andrew Haley aph at redhat.com
Mon Jul 13 16:55:36 UTC 2020


On 13/07/2020 10:48, Andrew Dinn wrote:
> The patch looks fine except for this one change at assembler_aarch64.hpp:673
> 
>    void f(unsigned val, int msb) {
>      current->f(val, msb, msb);
>    }
> -  void sf(long val, int msb, int lsb) {
> +  void sf(uint64_t val, int msb, int lsb) {
>      current->sf(val, msb, lsb);
>    }
> 
> I think val ought to be declared as int64_t.

Wow! How did I miss that one? Well spotted.

Is it OK with that change?

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the aarch64-port-dev mailing list