jtreg jenkins builds 4.1 and calls it 4.2-snapshot

Stanislav Baiduzhyi sbaiduzh at redhat.com
Tue May 19 08:53:32 UTC 2015


On Tuesday 19 May 2015 01:22:03 Mani Sarkar wrote:
> Thanks Stanislav, everything is in order, you can see the new version is
> also refactored into its own function for better oversight. And duplicate
> code has been removed.
> 
> Your script missed out on JCommander, I have applied it back to the script.

Hi Mani,

Looks good. Except for some strange broken encoding on line 127. Plus I would 
probably add a check for already downloaded jcommander.

And one more thing, I don't see any options in jenkins to clear the workspace 
before building, I don't know if it always makes a fresh clone or updates 
existing if found. In latter case the tip will be the same as the tag 
previously built. To make sure that tip is build I would add the checkout of 
the tip before building the tip. If it is the former than feel free to drop 
those lines.

So, please review the latest 2 changesets, unfortunately there were lots of 
trailing spaces cleanup so the changeset is little noisy:
https://gist.github.com/TheIndifferent/8573be7b18c2fdcf772f/revisions

-- 
Regards,
    Stas



More information about the adoption-discuss mailing list