jtreg jenkins builds 4.1 and calls it 4.2-snapshot

[Mani Sarkar]

Thanks for the tweaks, much required and this looks must more robust now.

Although I haven't see the ASM_HOME=... setting have any effect on the
jtreg binary produced - whats your experience there ?

Cheers,
Mani

On Tue, May 19, 2015 at 9:53 AM, Stanislav Baiduzhyi <sbaiduzh at redhat.com>
wrote:

> On Tuesday 19 May 2015 01:22:03 Mani Sarkar wrote:
> > Thanks Stanislav, everything is in order, you can see the new version is
> > also refactored into its own function for better oversight. And duplicate
> > code has been removed.
> >
> > Your script missed out on JCommander, I have applied it back to the
> script.
>
> Hi Mani,
>
> Looks good. Except for some strange broken encoding on line 127. Plus I
> would
> probably add a check for already downloaded jcommander.
>
> And one more thing, I don't see any options in jenkins to clear the
> workspace
> before building, I don't know if it always makes a fresh clone or updates
> existing if found. In latter case the tip will be the same as the tag
> previously built. To make sure that tip is build I would add the checkout
> of
> the tip before building the tip. If it is the former than feel free to drop
> those lines.
>
> So, please review the latest 2 changesets, unfortunately there were lots of
> trailing spaces cleanup so the changeset is little noisy:
> https://gist.github.com/TheIndifferent/8573be7b18c2fdcf772f/revisions
>
> --
> Regards,
>     Stas
>
>


-- 
@theNeomatrix369 <http://twitter.com/theNeomatrix369>*  |  **Blog
<http://neomatrix369.wordpress.com>**  |  *LJC Associate & LJC Advocate
(@adoptopenjdk & @adoptajsr programs)
*Meet-a-Project - *MutabilityDetector
<https://github.com/MutabilityDetector>*  |  **Bitbucket
<https://bitbucket.org/neomatrix369>* * |  **Github
<https://github.com/neomatrix369>* * |  **LinkedIn
<http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
*Come to Devoxx UK 2015:* http://www.devoxx.co.uk/

*Don't chase success, rather aim for "Excellence", and success will come
chasing after you!*